[AKS] az aks update: Set CMK property "enabled" to false and reserve other CMK properties for a PMK-enabled and CMK-disabled cluster#9398
Conversation
️✔️Azure CLI Extensions Breaking Change Test
|
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
|
There was a problem hiding this comment.
Pull Request Overview
This PR updates the behavior when disabling Customer-Managed Keys (CMK) on Azure Kubernetes Service clusters to preserve CMK configuration properties rather than clearing them.
- Modified the KMS update logic to preserve existing CMK properties (key_id, key_vault_resource_id, key_vault_network_access) when setting enabled=False
- Updated tests to reflect the new behavior of retaining CMK configuration on disable
- Bumped version to 19.0.0b12
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/aks-preview/setup.py | Version bump from 19.0.0b11 to 19.0.0b12 |
| src/aks-preview/HISTORY.rst | Added release notes for version 19.0.0b12 describing the CMK property preservation behavior |
| src/aks-preview/azext_aks_preview/managed_cluster_decorator.py | Removed initialization of empty AzureKeyVaultKms object to preserve existing CMK properties when disabling |
| src/aks-preview/azext_aks_preview/tests/latest/test_managed_cluster_decorator.py | Updated test expectations to verify CMK properties are preserved when disabled, added key_vault_network_access values to test data |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
…e other CMK properties for a PMK-enabled and CMK-disabled cluster
ab47f20 to
d5dda3d
Compare
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
[Release] Update index.json for extension [ aks-preview-19.0.0b13 ] : https://dev.azure.com/msazure/One/_build/results?buildId=142984065&view=results |
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.