Skip to content

[confcom] Make lib a module#9418

Merged
kairu-ms merged 3 commits intoAzure:mainfrom
DomAyre:fix-lib
Nov 12, 2025
Merged

[confcom] Make lib a module#9418
kairu-ms merged 3 commits intoAzure:mainfrom
DomAyre:fix-lib

Conversation

@DomAyre
Copy link
Copy Markdown
Contributor

@DomAyre DomAyre commented Nov 12, 2025

Why

We added a new module lib in #9409 but without __init__.py this isn't picked up in releases


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

Copilot AI review requested due to automatic review settings November 12, 2025 12:51
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

@azure-client-tools-bot-prd
Copy link
Copy Markdown

azure-client-tools-bot-prd bot commented Nov 12, 2025

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

@azure-client-tools-bot-prd
Copy link
Copy Markdown

Hi @DomAyre,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Copy Markdown
Collaborator

yonzhan commented Nov 12, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

@github-actions
Copy link
Copy Markdown
Contributor

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

@DomAyre
Copy link
Copy Markdown
Contributor Author

DomAyre commented Nov 12, 2025

The failures in Release Version Calculation comes from the existing issue this PR fixes, so shouldn't be considered a blocker for this PR

@kairu-ms kairu-ms merged commit 878d6cc into Azure:main Nov 12, 2025
28 of 30 checks passed
@azclibot
Copy link
Copy Markdown
Collaborator

[Release] Update index.json for extension [ confcom ] : https://dev.azure.com/msazure/One/_build/results?buildId=143545457&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants