Skip to content

{edge-action} Add edge-action extension for Edge Actions (2025-09-01-preview)#9439

Merged
kairu-ms merged 7 commits intoAzure:mainfrom
tundwed:feature/edge-action-extension
Nov 21, 2025
Merged

{edge-action} Add edge-action extension for Edge Actions (2025-09-01-preview)#9439
kairu-ms merged 7 commits intoAzure:mainfrom
tundwed:feature/edge-action-extension

Conversation

@tundwed
Copy link
Copy Markdown
Member

@tundwed tundwed commented Nov 20, 2025


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

edge-action

General Guidelines

  • [ x] Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • [ x] Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • [x ] My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Danny Tundwe (from Dev Box) added 4 commits November 19, 2025 22:44
- Generated extension structure from AAZ
- Added custom deploy-from-file command for file/zip deployment
- Migrated 5 test scenarios with recordings from main CLI repo
- Supports both file (.js) and zip deployment types
- Auto-detection of deployment type from file extension
- Added linter_exclusions.yml for long parameter names
- Added parameter help documentation for deploy-from-file command
- Fixed line length in _params.py
- Fixed pylint warning in custom.py (initialized encoded_content)
- All tests passing (5/5) in playback mode
- Updated README.md with comprehensive usage examples
- Clarified service is Azure Front Door Edge Actions (not generic CDN)
- Added installation instructions and command examples
- Updated setup.py description to mention Azure Front Door
- Added azext.summary following Azure CLI extension guidelines
- Summary is concise (under 140 chars), specific, and uses correct branding
- Verified with test_index.py validation
Copilot AI review requested due to automatic review settings November 20, 2025 07:23
@azure-client-tools-bot-prd
Copy link
Copy Markdown

Validation for Breaking Change Starting...

Thanks for your contribution!

@azure-client-tools-bot-prd
Copy link
Copy Markdown

Hi @tundwed,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Copy Markdown
Collaborator

yonzhan commented Nov 20, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

@github-actions
Copy link
Copy Markdown
Contributor

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

@github-actions
Copy link
Copy Markdown
Contributor

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

@github-actions
Copy link
Copy Markdown
Contributor

- Added command help with short and long summaries
- Added 3 examples covering JavaScript, zip, and explicit deployment type
- Fixes missing_command_example linter error
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a new CLI extension edge-action for managing Azure Front Door Edge Actions with API version 2025-09-01-preview. The extension provides commands for CRUD operations on edge actions and their versions, including deployment capabilities from files or zip archives.

Reviewed Changes

Copilot reviewed 51 out of 52 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
setup.py Defines package metadata, dependencies, and classifiers for the edge-action extension
setup.cfg Minimal setup configuration file
linter_exclusions.yml Configures linter rule exclusions for long parameter names in execution-filter commands
test_edge_action.py Comprehensive test suite covering CRUD operations, version management, and file/zip deployments
test_files/sample_edge_action.js Sample JavaScript handler for testing edge action deployments
test_files/sample_edge_action.zip Zipped version of the sample JavaScript file for testing zip deployments
test recordings/*.yaml HTTP interaction recordings for test playback
init.py Standard Python package initialization file

Comment thread src/edge-action/azext_edge_action/tests/latest/test_edge_action.py Outdated
@yonzhan yonzhan requested review from jsntcy and kairu-ms November 20, 2025 07:41
- Moved 'import base64' from inside test method to top-level imports
- Follows Python best practices for import organization
- All imports now grouped at the top of the file
@kairu-ms
Copy link
Copy Markdown
Contributor

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 2 pipeline(s).

@kairu-ms
Copy link
Copy Markdown
Contributor

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 2 pipeline(s).

@kairu-ms kairu-ms merged commit e59a3ad into Azure:main Nov 21, 2025
24 checks passed
@azclibot
Copy link
Copy Markdown
Collaborator

[Release] Update index.json for extension [ edge-action-1.0.0b1 ] : https://dev.azure.com/msazure/One/_build/results?buildId=144415687&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants