-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Update endpoint pattern regex for long TLD #9456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
d0e94ec
f8dad44
cc88ea6
e00232c
b77b626
e3af87f
f7d891d
6ed3d3b
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| { | ||
| "azext.isExperimental": true, | ||
| "azext.isPreview": true, | ||
| "azext.minCliCoreVersion": "2.11.0" | ||
| } |
Large diffs are not rendered by default.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,20 +1,20 @@ | ||
| |Scenario|Result|ErrorMessage|ErrorStack|ErrorNormalized|StartDt|EndDt| | ||
| |step__profiles_put_create_or_update_a_footprint_profile_|successed||||2020-08-18 22:22:11.639664|2020-08-18 22:22:55.697462| | ||
| |step__profiles_get_get_the_details_of_a_footprint_profile_|successed||||2020-08-18 22:22:55.697462|2020-08-18 22:22:56.835470| | ||
| |step__profiles_get_list_all_footprint_profiles_under_a_resource_group_|successed||||2020-08-18 22:22:56.835470|2020-08-18 22:22:57.912519| | ||
| |step__profiles_get_list_all_footprint_profiles_under_a_subscription_|successed||||2020-08-18 22:22:57.912519|2020-08-18 22:22:59.172658| | ||
| |step__profiles_patch_update_a_footprint_profile_|successed||||2020-08-18 22:22:59.172658|2020-08-18 22:23:00.365159| | ||
| |step__experiments_put_create_or_update_an_experiment_|successed||||2020-08-18 22:23:00.365159|2020-08-18 22:23:05.881296| | ||
| |step__experiments_get_get_the_details_of_an_experiment_|successed||||2020-08-18 22:23:05.882295|2020-08-18 22:23:06.878597| | ||
| |step__experiments_get_list_all_experiments_under_a_footprint_profile_|successed||||2020-08-18 22:23:06.878597|2020-08-18 22:23:07.847313| | ||
| |step__measurementendpoints_put_create_or_update_a_measurement_endpoint_|successed||||2020-08-18 22:23:07.848309|2020-08-18 22:23:14.516788| | ||
| |step__measurementendpoints_get_get_the_details_of_a_measurement_endpoint_|successed||||2020-08-18 22:23:14.516788|2020-08-18 22:23:15.493906| | ||
| |step__measurementendpoints_get_list_all_the_measurement_endpoints_under_a_footprint_profile_|successed||||2020-08-18 22:23:15.493906|2020-08-18 22:23:16.698742| | ||
| |step__measurementendpointconditions_put_create_or_update_a_measurement_endpoint_condition_|successed||||2020-08-18 22:23:16.698742|2020-08-18 22:23:28.010368| | ||
| |step__measurementendpointconditions_get_get_the_details_of_a_measurement_endpoint_condition_|successed||||2020-08-18 22:23:28.011367|2020-08-18 22:23:29.276407| | ||
| |step__measurementendpointconditions_get_list_all_conditions_under_a_measurement_endpoint_|successed||||2020-08-18 22:23:29.276407|2020-08-18 22:23:30.574658| | ||
| |step__measurementendpointconditions_delete_delete_a_measurement_endpoint_condition_|successed||||2020-08-18 22:23:30.575663|2020-08-18 22:23:35.114155| | ||
| |step__experiments_delete_delete_an_experiment_|successed||||2020-08-18 22:23:35.114155|2020-08-18 22:23:39.818973| | ||
| |step__measurementendpoints_delete_delete_a_measurement_endpoint_|successed||||2020-08-18 22:23:39.818973|2020-08-18 22:23:46.433847| | ||
| |step__profiles_delete_delete_a_footprint_profile_|successed||||2020-08-18 22:23:46.434832|2020-08-18 22:23:53.642127| | ||
| |step__profiles_put_create_or_update_a_footprint_profile_|successed||||2025-12-05 20:58:20.964070|2025-12-05 20:58:21.295223| | ||
| |step__profiles_get_get_the_details_of_a_footprint_profile_|successed||||2025-12-05 20:58:21.295223|2025-12-05 20:58:21.439761| | ||
| |step__profiles_get_list_all_footprint_profiles_under_a_resource_group_|successed||||2025-12-05 20:58:21.439761|2025-12-05 20:58:21.624313| | ||
| |step__profiles_get_list_all_footprint_profiles_under_a_subscription_|successed||||2025-12-05 20:58:21.624313|2025-12-05 20:58:21.773844| | ||
| |step__profiles_patch_update_a_footprint_profile_|successed||||2025-12-05 20:58:21.774854|2025-12-05 20:58:21.911483| | ||
| |step__experiments_put_create_or_update_an_experiment_|successed||||2025-12-05 20:58:21.911483|2025-12-05 20:58:22.048772| | ||
| |step__experiments_get_get_the_details_of_an_experiment_|successed||||2025-12-05 20:58:22.048772|2025-12-05 20:58:22.198601| | ||
| |step__experiments_get_list_all_experiments_under_a_footprint_profile_|successed||||2025-12-05 20:58:22.199601|2025-12-05 20:58:22.337807| | ||
| |step__measurementendpoints_put_create_or_update_a_measurement_endpoint_|successed||||2025-12-05 20:58:22.337807|2025-12-05 20:58:22.489003| | ||
| |step__measurementendpoints_get_get_the_details_of_a_measurement_endpoint_|successed||||2025-12-05 20:58:22.489003|2025-12-05 20:58:22.631628| | ||
| |step__measurementendpoints_get_list_all_the_measurement_endpoints_under_a_footprint_profile_|successed||||2025-12-05 20:58:22.631628|2025-12-05 20:58:22.782326| | ||
| |step__measurementendpointconditions_put_create_or_update_a_measurement_endpoint_condition_|successed||||2025-12-05 20:58:22.782326|2025-12-05 20:58:22.949807| | ||
| |step__measurementendpointconditions_get_get_the_details_of_a_measurement_endpoint_condition_|successed||||2025-12-05 20:58:22.950690|2025-12-05 20:58:23.091858| | ||
| |step__measurementendpointconditions_get_list_all_conditions_under_a_measurement_endpoint_|successed||||2025-12-05 20:58:23.091858|2025-12-05 20:58:23.234372| | ||
| |step__measurementendpointconditions_delete_delete_a_measurement_endpoint_condition_|successed||||2025-12-05 20:58:23.234372|2025-12-05 20:58:23.382437| | ||
| |step__experiments_delete_delete_an_experiment_|successed||||2025-12-05 20:58:23.383442|2025-12-05 20:58:23.530699| | ||
| |step__measurementendpoints_delete_delete_a_measurement_endpoint_|successed||||2025-12-05 20:58:23.531599|2025-12-05 20:58:23.680833| | ||
| |step__profiles_delete_delete_a_footprint_profile_|successed||||2025-12-05 20:58:23.680833|2025-12-05 20:58:23.820734| | ||
| Coverage: 18/18 |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -213,7 +213,7 @@ class MeasurementEndpoint(SubResource): | |
| 'name': {'readonly': True}, | ||
| 'type': {'readonly': True}, | ||
| 'endpoint_id': {'readonly': True, 'max_length': 32, 'min_length': 32, 'pattern': r'[a-f0-9]{32}'}, | ||
| 'endpoint': {'required': True, 'max_length': 1024, 'min_length': 0, 'pattern': r'^[a-z0-9\*]+([\-\.]{1}[a-z0-9]+)*\.[a-z]{2,5}(:[0-9]{1,5})?$'}, | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The change is applied in SDK, but not in CLI extension?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thanks for your review @jsntcy. This change needs to be done in both places. Our requests go to RPaaS whose specification can be found here https://github.com/Azure/azure-rest-api-specs-pr/blob/RPSaaSMaster/specification/footprintmonitoring/resource-manager/Microsoft.FootprintMonitoring/preview/2024-09-16-preview/footprintProfiles.json#L1375C11-L1375C87 Is there an additional path that I'm missing? |
||
| 'endpoint': {'required': True, 'max_length': 1024, 'min_length': 0, 'pattern': r'^[a-z0-9\*]+([\-\.]{1}[a-z0-9]+)*\.[a-z]{2,}(:[0-9]{1,5})?$'}, | ||
| 'measurement_type': {'required': True}, | ||
| 'weight': {'required': True, 'maximum': 2147483647, 'minimum': 0}, | ||
| 'experiment_id': {'max_length': 32, 'min_length': 32, 'pattern': r'[a-f0-9]{32}'}, | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.