Conversation
kumdeepakgit
requested review from
evelyn-ys,
jiasli,
jsntcy,
kairu-ms,
necusjz,
wangzelin007 and
zhoxing-ms
as code owners
️✔️Azure CLI Extensions Breaking Change Test
|
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
Hi @kumdeepakgit, |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
|
There was a problem hiding this comment.
Pull request overview
This PR adds version 1.11.5 of the stack-hci-vm Azure CLI extension to the extension index. The change appears to be a routine version addition, though there's a discrepancy between the PR description's guidance and the actual changes made.
Key Changes
- Adds stack-hci-vm version 1.11.5 entry to src/index.json with complete metadata and download information
- Follows the same structure and format as existing stack-hci-vm versions (1.11.1 and 1.11.3)
| }, | ||
| { | ||
| "downloadUrl": "https://hciarcvmsstorage.z13.web.core.windows.net/cli-extensions/stack_hci_vm-1.11.5-py3-none-any.whl", | ||
| "filename": "stack_hci_vm-1.11.5-py3-none-any.whl", | ||
| "metadata": { | ||
| "azext.minCliCoreVersion": "2.15.0", | ||
| "classifiers": [ | ||
| "Development Status :: 4 - Beta", | ||
| "Intended Audience :: Developers", | ||
| "Intended Audience :: System Administrators", | ||
| "Programming Language :: Python", | ||
| "Programming Language :: Python :: 3", | ||
| "Programming Language :: Python :: 3.6", | ||
| "Programming Language :: Python :: 3.7", | ||
| "Programming Language :: Python :: 3.8", | ||
| "License :: OSI Approved :: MIT License" | ||
| ], | ||
| "extensions": { | ||
| "python.details": { | ||
| "contacts": [ | ||
| { | ||
| "email": "azpycli@microsoft.com", | ||
| "name": "Microsoft Corporation", | ||
| "role": "author" | ||
| } | ||
| ], | ||
| "document_names": { | ||
| "description": "DESCRIPTION.rst" | ||
| }, | ||
| "project_urls": { | ||
| "Home": "https://github.com/Azure/azure-cli-extensions/tree/master/src/stack-hci-vm" | ||
| } | ||
| } | ||
| }, | ||
| "generator": "bdist_wheel (0.30.0)", | ||
| "license": "MIT", | ||
| "metadata_version": "2.0", | ||
| "name": "stack-hci-vm", | ||
| "summary": "Microsoft Azure Command-Line Tools Stack-HCi-VM Extension", | ||
| "version": "1.11.5" | ||
| }, | ||
| "sha256Digest": "090acad77353d4fd25e7f9ab51f81b7beb9c0887699356651dd55081c026f64f" | ||
| } |
There was a problem hiding this comment.
The PR description states that developers should not manually modify src/index.json, and that this file will be updated automatically after merging changes to setup.py and HISTORY.rst. However, this PR only modifies src/index.json without any corresponding changes to setup.py or HISTORY.rst.
If this is intended to be a manual addition (perhaps the automated process didn't work), please clarify in the PR description. If this is the automated PR, consider using a different PR template that reflects the automated nature of the change.
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
/azp run |
|
Commenter does not have sufficient privileges for PR 9476 in repo Azure/azure-cli-extensions |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.