{FrontDoor} Add sub command for waf#9532
Merged
necusjz merged 7 commits intoAzure:mainfrom Jan 27, 2026
Merged
Conversation
❌Azure CLI Extensions Breaking Change Test
|
|
Hi @Ptnan7, |
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
Contributor
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
Contributor
CodeGen Tools Feedback CollectionThank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey |
Contributor
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the deprecated --defer flag functionality from Azure Front Door WAF policy commands and refactors command registration to use class-based commands (AAZ pattern). It also adds new managed rule definition commands.
Changes:
- Removed
--deferflag from all WAF policy custom rule and match condition commands - Refactored command registration from function-based to class-based AAZ pattern
- Added new managed rule definition list command
- Updated tests to work without defer flag, requiring match conditions at rule creation
- Updated minimum CLI version to 2.75.0
Reviewed changes
Copilot reviewed 11 out of 13 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| test_waf_scenarios.py | Removed --defer flag usage, updated tests to provide required match conditions during rule creation, adjusted error messages and test assertions |
| commands.py | Refactored from function-based to class-based command registration using AAZ pattern |
| azext_metadata.json | Updated minimum CLI core version from 2.70.0 to 2.75.0 |
| managed_rule_definition/* | Added new AAZ-generated files for managed rule definition list command |
| *.yaml (recordings) | Updated test recordings with new timestamps and API version changes |
added 2 commits
January 19, 2026 15:42
Member
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
added 3 commits
January 20, 2026 10:08
Member
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Member
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Ptnan7
force-pushed
the
waf-subcommand
branch
from
e1e7381 to
b023383
Compare
Member
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Member
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
necusjz
approved these changes
Jan 27, 2026
Collaborator
|
[Release] Update index.json for extension [ front-door-2.0.0 ] : https://dev.azure.com/msazure/One/_build/results?buildId=150711478&view=results |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.