Skip to content

{aks-agent}: remove user MSI from aks-agent#9559

Merged
yanzhudd merged 3 commits intoAzure:mainfrom
mainred:update-sa-with-workload-identity
Jan 29, 2026
Merged

{aks-agent}: remove user MSI from aks-agent#9559
yanzhudd merged 3 commits intoAzure:mainfrom
mainred:update-sa-with-workload-identity

Conversation

@mainred
Copy link
Copy Markdown
Member

@mainred mainred commented Jan 29, 2026


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copilot AI review requested due to automatic review settings January 29, 2026 03:49
@azure-client-tools-bot-prd
Copy link
Copy Markdown

azure-client-tools-bot-prd bot commented Jan 29, 2026

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

@azure-client-tools-bot-prd
Copy link
Copy Markdown

Hi @mainred,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Copy Markdown
Collaborator

yonzhan commented Jan 29, 2026

Thank you for your contribution! We will review the pull request and get back to you soon.

@github-actions
Copy link
Copy Markdown
Contributor

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

@mainred mainred force-pushed the update-sa-with-workload-identity branch from 29693ba to bcd7aeb Compare January 29, 2026 03:50
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jan 29, 2026

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes the interactive “managed identity client ID” configuration path from az aks agent-init and stops emitting the corresponding workload identity values into the Helm values, shifting guidance toward service-account-based configuration.

Changes:

  • Remove managed identity client ID prompts from the init/Helm deployment interactive flow and update console guidance.
  • Remove managed identity client ID state/loading and workloadIdentity/azure.clientId Helm values generation from AKSAgentManager.
  • Add a changelog entry documenting the behavior change.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.

File Description
src/aks-agent/azext_aks_agent/custom.py Removes managed identity prompting during Helm setup and adds guidance about annotating the service account for Azure access.
src/aks-agent/azext_aks_agent/agent/k8s/aks_agent_manager.py Removes managed identity client ID handling and stops generating workload identity-related Helm values.
src/aks-agent/HISTORY.rst Documents the change in the release history (new 1.0.0b17 entry).

Comment thread src/aks-agent/HISTORY.rst Outdated
Comment thread src/aks-agent/HISTORY.rst
Comment thread src/aks-agent/azext_aks_agent/custom.py Outdated
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@yanzhudd yanzhudd merged commit 03c06b7 into Azure:main Jan 29, 2026
24 checks passed
@azclibot
Copy link
Copy Markdown
Collaborator

[Release] Update index.json for extension [ aks-agent-1.0.0b17 ] : https://dev.azure.com/msazure/One/_build/results?buildId=151068359&view=results

jepetty pushed a commit to jepetty/azure-cli-extensions that referenced this pull request Feb 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AKS Auto-Assign Auto assign by bot

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants