{aks-agent}: remove user MSI from aks-agent#9559
Conversation
️✔️Azure CLI Extensions Breaking Change Test
|
|
Hi @mainred, |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
29693ba to
bcd7aeb
Compare
|
There was a problem hiding this comment.
Pull request overview
Removes the interactive “managed identity client ID” configuration path from az aks agent-init and stops emitting the corresponding workload identity values into the Helm values, shifting guidance toward service-account-based configuration.
Changes:
- Remove managed identity client ID prompts from the init/Helm deployment interactive flow and update console guidance.
- Remove managed identity client ID state/loading and
workloadIdentity/azure.clientIdHelm values generation fromAKSAgentManager. - Add a changelog entry documenting the behavior change.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
src/aks-agent/azext_aks_agent/custom.py |
Removes managed identity prompting during Helm setup and adds guidance about annotating the service account for Azure access. |
src/aks-agent/azext_aks_agent/agent/k8s/aks_agent_manager.py |
Removes managed identity client ID handling and stops generating workload identity-related Helm values. |
src/aks-agent/HISTORY.rst |
Documents the change in the release history (new 1.0.0b17 entry). |
…ate-sa-with-workload-identity
|
[Release] Update index.json for extension [ aks-agent-1.0.0b17 ] : https://dev.azure.com/msazure/One/_build/results?buildId=151068359&view=results |
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.