Skip to content

Feature managedcleanroom frontend#9572

Merged
yanzhudd merged 14 commits intoAzure:mainfrom
sakshamgargMS:feature-managedcleanroom-frontend
Feb 13, 2026
Merged

Feature managedcleanroom frontend#9572
yanzhudd merged 14 commits intoAzure:mainfrom
sakshamgargMS:feature-managedcleanroom-frontend

Conversation

@sakshamgargMS
Copy link
Copy Markdown
Contributor

@sakshamgargMS sakshamgargMS commented Feb 2, 2026


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@azure-client-tools-bot-prd
Copy link
Copy Markdown

azure-client-tools-bot-prd bot commented Feb 2, 2026

⚠️Azure CLI Extensions Breaking Change Test
⚠️managedcleanroom
rule cmd_name rule_message suggest_message
⚠️ 1011 - SubgroupAdd managedcleanroom frontend sub group managedcleanroom frontend added

@azure-client-tools-bot-prd
Copy link
Copy Markdown

Hi @sakshamgargMS,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Copy Markdown
Collaborator

yonzhan commented Feb 2, 2026

Thank you for your contribution! We will review the pull request and get back to you soon.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 2, 2026

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

@microsoft-github-policy-service microsoft-github-policy-service bot added the customer-reported Issues that are reported by GitHub users external to the Azure organization. label Feb 2, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 2, 2026

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 2, 2026

logger.debug("Using Azure CLI (az login) token")
return profile.get_raw_token(
subscription=subscription,
resource='https://management.azure.com/'
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://management.azure.com/

Are we hard-coding it here? Different clouds will have different ARM URL. It should be taken up from the user context.

# For production, use standard bearer token policy with HTTPS enforcement
auth_policy = BearerTokenCredentialPolicy(
credential,
'https://management.azure.com/.default'
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://management.azure.com/.default

Same applies here, can we fetch it from user context?

@yonzhan yonzhan requested review from kairu-ms and necusjz February 2, 2026 11:23
@yonzhan yonzhan requested a review from jsntcy February 2, 2026 11:23
return client.collaboration.analytics_queries_query_id_get(collaboration_id, query_id)


def frontend_collaboration_query_publish(cmd, collaboration_id, query_id):
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here it seems we are only passing the contents of the parameters to be passed to the query publish URL but not the publish HTTP request body. Could you please validate once, there are required properties expected by the query publish endpoint?

return client.collaboration.analytics_dataset_id_get(collaboration_id, dataset_id)


def frontend_collaboration_dataset_publish(cmd, collaboration_id, dataset_id):
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similarly, here it seems we are only passing the contents of the parameters to be passed to the dataset publish URL but not the publish HTTP request body. Could you please validate once, there are required properties expected by the dataset publish endpoint?

@github-actions github-actions bot added the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label Feb 2, 2026
@sakshamgargMS
Copy link
Copy Markdown
Contributor Author

@microsoft-github-policy-service agree company="Microsoft"

@github-actions github-actions bot removed the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label Feb 5, 2026
@sakshamgargMS sakshamgargMS marked this pull request as ready for review February 6, 2026 17:48

# Show command at frontend level (requires --collaboration-id)
with loader.command_group('managedcleanroom frontend', custom_command_type=frontend_custom) as g:
g.custom_show_command('show', 'frontend_collaboration_show')
Copy link
Copy Markdown

@anantshankar17 anantshankar17 Feb 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All cmds below this require the --collaboration-id param, should those cmd grps be derived from g then or be sub groups ? #Resolved

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can create everything as a subgroup - but then we will have to build parsing on the commands to know what method to call - right now it structured in a way where all cmdlets call the sdk directly and so this was the simplest way to register the commands without building some parsing logic

Copy link
Copy Markdown

@anantshankar17 anantshankar17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@sakshamgargMS
Copy link
Copy Markdown
Contributor Author

@necusjz - can you please help with this PR review - this is to add frontend cmdlets for the new managedcleanroom service

@necusjz
Copy link
Copy Markdown
Member

necusjz commented Feb 11, 2026

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 2 pipeline(s).

@yanzhudd
Copy link
Copy Markdown
Contributor

please fix the CI issue

@sakshamgargMS
Copy link
Copy Markdown
Contributor Author

/azp run

@azure-pipelines
Copy link
Copy Markdown

Commenter does not have sufficient privileges for PR 9572 in repo Azure/azure-cli-extensions

@yonzhan
Copy link
Copy Markdown
Collaborator

yonzhan commented Feb 12, 2026

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 2 pipeline(s).

@yonzhan
Copy link
Copy Markdown
Collaborator

yonzhan commented Feb 12, 2026

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 2 pipeline(s).

@yanzhudd yanzhudd merged commit 35b686e into Azure:main Feb 13, 2026
24 checks passed
@azclibot
Copy link
Copy Markdown
Collaborator

[Release] Update index.json for extension [ managedcleanroom-1.0.0b2 ] : https://dev.azure.com/msazure/One/_build/results?buildId=153039404&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

customer-reported Issues that are reported by GitHub users external to the Azure organization.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants