Feature managedcleanroom frontend#9572
Conversation
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| managedcleanroom frontend | sub group managedcleanroom frontend added |
|
Hi @sakshamgargMS, |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
CodeGen Tools Feedback CollectionThank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey |
|
| logger.debug("Using Azure CLI (az login) token") | ||
| return profile.get_raw_token( | ||
| subscription=subscription, | ||
| resource='https://management.azure.com/' |
There was a problem hiding this comment.
Are we hard-coding it here? Different clouds will have different ARM URL. It should be taken up from the user context.
| # For production, use standard bearer token policy with HTTPS enforcement | ||
| auth_policy = BearerTokenCredentialPolicy( | ||
| credential, | ||
| 'https://management.azure.com/.default' |
There was a problem hiding this comment.
Same applies here, can we fetch it from user context?
| return client.collaboration.analytics_queries_query_id_get(collaboration_id, query_id) | ||
|
|
||
|
|
||
| def frontend_collaboration_query_publish(cmd, collaboration_id, query_id): |
There was a problem hiding this comment.
Here it seems we are only passing the contents of the parameters to be passed to the query publish URL but not the publish HTTP request body. Could you please validate once, there are required properties expected by the query publish endpoint?
| return client.collaboration.analytics_dataset_id_get(collaboration_id, dataset_id) | ||
|
|
||
|
|
||
| def frontend_collaboration_dataset_publish(cmd, collaboration_id, dataset_id): |
There was a problem hiding this comment.
Similarly, here it seems we are only passing the contents of the parameters to be passed to the dataset publish URL but not the publish HTTP request body. Could you please validate once, there are required properties expected by the dataset publish endpoint?
|
@microsoft-github-policy-service agree company="Microsoft" |
|
|
||
| # Show command at frontend level (requires --collaboration-id) | ||
| with loader.command_group('managedcleanroom frontend', custom_command_type=frontend_custom) as g: | ||
| g.custom_show_command('show', 'frontend_collaboration_show') |
There was a problem hiding this comment.
All cmds below this require the --collaboration-id param, should those cmd grps be derived from g then or be sub groups ? #Resolved
There was a problem hiding this comment.
We can create everything as a subgroup - but then we will have to build parsing on the commands to know what method to call - right now it structured in a way where all cmdlets call the sdk directly and so this was the simplest way to register the commands without building some parsing logic
|
@necusjz - can you please help with this PR review - this is to add frontend cmdlets for the new managedcleanroom service |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
please fix the CI issue |
|
/azp run |
|
Commenter does not have sufficient privileges for PR 9572 in repo Azure/azure-cli-extensions |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
[Release] Update index.json for extension [ managedcleanroom-1.0.0b2 ] : https://dev.azure.com/msazure/One/_build/results?buildId=153039404&view=results |
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.