Skip to content

Fix akv secrete provider update operation fail #9573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yanzhudd merged 5 commits into from
Feb 19, 2026
Merged

Fix akv secrete provider update operation fail #9573

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a585d11
Fix: Call parent update_addon_profiles to enable keyvault secrets pro…
charleswool Feb 3, 2026
027abe3
Fix put_mc to explicitly wait for LRO in non-postprocessing path
charleswool Feb 11, 2026
6e65cf8
fix: explicitly wait for LRO in enable-addons and disable-addons
charleswool Feb 13, 2026
1fa3e19
revert: remove incorrect LRO handling changes in custom.py and put_mc
charleswool Feb 13, 2026
abf790c
docs: add HISTORY.rst entry for secret rotation fix
charleswool Feb 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/aks-preview/HISTORY.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ To release a new version, please select a new version number (usually plus 1 to

Pending
+++++++
* `az aks update`: Fix `--enable-secret-rotation`, `--disable-secret-rotation`, and `--rotation-poll-interval` flags being silently ignored when updating Azure Key Vault Secrets Provider addon configuration.
* `az aks create/update`: Add `--enable-azure-monitor-logs` support to container network logs validation.
* `az aks create/update`: Add `--enable-default-domain` and `--disable-default-domain` parameters to manage the default domain feature for web app routing.

Expand Down
4 changes: 4 additions & 0 deletions src/aks-preview/azext_aks_preview/managed_cluster_decorator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7425,6 +7425,10 @@ def update_addon_profiles(self, mc: ManagedCluster) -> ManagedCluster:
"""
self._ensure_mc(mc)

# Call the parent class method to handle base addon profile updates
# (including Azure Keyvault Secrets Provider secret rotation settings)
mc = super().update_addon_profiles(mc)

# Handle enable Azure Monitor logs
if self.context.get_enable_azure_monitor_logs():
self._setup_azure_monitor_logs(mc)
Expand Down
Loading