{AKS} `az aks create/update`: Add `--enable-default-domain` and `--disable-default-domain` parameters to manage the default domain feature for web app routing by OliverMKing · Pull Request #9578 · Azure/azure-cli-extensions

OliverMKing · 2026-02-05T03:46:36Z

This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
My extension version conforms to the Extension version schema

For new extensions:

My extension description/summary conforms to the Extension Summary Guidelines.

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

azure-client-tools-bot-prd · 2026-02-05T03:46:39Z

⚠️Azure CLI Extensions Breaking Change Test

⚠️aks-preview

rule cmd_name rule_message suggest_message

⚠️ 1011 - SubgroupAdd aks approuting defaultdomain sub group aks approuting defaultdomain added

⚠️ 1006 - ParaAdd aks approuting enable cmd aks approuting enable added parameter enable_default_domain

⚠️ 1006 - ParaAdd aks approuting update cmd aks approuting update added parameter disable_default_domain

⚠️ 1006 - ParaAdd aks approuting update cmd aks approuting update added parameter enable_default_domain

⚠️ 1006 - ParaAdd aks create cmd aks create added parameter enable_default_domain

azure-client-tools-bot-prd · 2026-02-05T03:46:42Z

Hi @OliverMKing,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

yonzhan · 2026-02-05T03:46:46Z

Thank you for your contribution! We will review the pull request and get back to you soon.

github-actions · 2026-02-05T03:46:47Z

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

github-actions · 2026-02-05T03:50:30Z

Hi @OliverMKing

Release Suggestions

Module: aks-preview

Update VERSION to 19.0.0b23 in src/aks-preview/setup.py

Notes

For more info about extension versioning, please refer to Extension version schema

github-actions · 2026-02-05T03:55:33Z

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

Copilot

Pull request overview

This pull request adds support for managing default domains in the AKS Application Routing addon through Azure CLI commands. The feature allows users to enable or disable a default domain for Application Routing, which provides automatic domain assignment to clusters.

Changes:

Added az aks approuting defaultdomain show command to display the default domain configuration
Added --enable-default-domain and --disable-default-domain flags to aks create, aks approuting enable, and aks approuting update commands
Implemented comprehensive test coverage for the default domain lifecycle

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
src/aks-preview/azext_aks_preview/tests/latest/test_aks_commands.py	Added two test cases covering default domain enable/disable/show operations and cluster creation with default domain
src/aks-preview/azext_aks_preview/managed_cluster_decorator.py	Added getter methods for default domain flags and logic to configure default domain during cluster creation and updates
src/aks-preview/azext_aks_preview/custom.py	Added `aks_approuting_default_domain_show` function and integrated default domain flags into enable/update commands with conflict validation
src/aks-preview/azext_aks_preview/commands.py	Registered the new `aks approuting defaultdomain show` command
src/aks-preview/azext_aks_preview/_params.py	Defined parameters for enable_default_domain and disable_default_domain flags across relevant commands
src/aks-preview/azext_aks_preview/_help.py	Added help documentation for the new command and parameters

Comments suppressed due to low confidence (1)

src/aks-preview/azext_aks_preview/custom.py:4137

While the default domain functionality is tested via the create and update commands, there is no test coverage for enabling default domain using the "aks approuting enable" command with the --enable-default-domain flag. Consider adding a test case to verify this code path works correctly.

def aks_mesh_upgrade_complete(
        cmd,
        client,
        resource_group_name,
        name,
        yes=False
):
    return _aks_mesh_update(
        cmd,
        client,
        resource_group_name,
        name,

Copilot · 2026-02-05T03:56:53Z

src/aks-preview/azext_aks_preview/managed_cluster_decorator.py

+
    def get_nginx(self):
        """Obtain the value of nginx, written to the update decorator context by _aks_approuting_update



Trailing whitespace detected after the function definition. Please remove the trailing spaces to maintain code cleanliness.

Copilot · 2026-02-05T03:56:53Z

src/aks-preview/azext_aks_preview/managed_cluster_decorator.py

                    )
                )

            if "web_application_routing" in addons:
                dns_zone_resource_ids = self.context.get_dns_zone_resource_ids()
                mc.ingress_profile.web_app_routing.dns_zone_resource_ids = dns_zone_resource_ids

+        if self.context.get_enable_default_domain() or self.context.get_disable_default_domain():
+            if mc.ingress_profile is None:
+                mc.ingress_profile = self.models.ManagedClusterIngressProfile()  # pylint: disable=no-member
+            if mc.ingress_profile.web_app_routing is None:
+                mc.ingress_profile.web_app_routing = (
+                    self.models.ManagedClusterIngressProfileWebAppRouting(enabled=True)  # pylint: disable=no-member
+                )
+
+            enable = True
+            if self.context.get_disable_default_domain():


The logic checking for disable_default_domain is unnecessary in set_up_ingress_web_app_routing since this function is only called during cluster creation, and disable_default_domain is not defined in the create command's argument context (only in update). The condition should be simplified to only check get_enable_default_domain(). This would make the code clearer and more maintainable.

Copilot · 2026-02-05T03:56:53Z

src/aks-preview/azext_aks_preview/managed_cluster_decorator.py

+                    self.models.ManagedClusterIngressProfileWebAppRouting(enabled=True)  # pylint: disable=no-member
+                )
+
+            enable = True


Trailing whitespace detected on empty lines. Please remove the trailing spaces to maintain code cleanliness.

Suggested change

enable = True

enable = True

Copilot · 2026-02-05T03:56:54Z

src/aks-preview/azext_aks_preview/managed_cluster_decorator.py

                dns_zone_resource_ids = self.context.get_dns_zone_resource_ids()
                mc.ingress_profile.web_app_routing.dns_zone_resource_ids = dns_zone_resource_ids

+        if self.context.get_enable_default_domain() or self.context.get_disable_default_domain():


The code implicitly enables App Routing (by creating web_app_routing with enabled=True) when enable_default_domain is specified, even if enable_app_routing is not set. While this is functionally correct (default domain requires App Routing), it creates implicit behavior that may be confusing. Consider adding validation to require --enable-app-routing when --enable-default-domain is used, or document this implicit behavior in the help text. This would make the dependency explicit and avoid user confusion.

Suggested change

if self.context.get_enable_default_domain() or self.context.get_disable_default_domain():

if self.context.get_enable_default_domain() or self.context.get_disable_default_domain():

# Default domain requires App Routing; make this dependency explicit to avoid

# implicitly enabling App Routing when the user has not requested it.

if not (self.context.get_enable_app_routing() or "web_application_routing" in addons):

raise ArgumentUsageError(

"--enable-default-domain/--disable-default-domain requires either "

"--enable-app-routing or --enable-addons web_application_routing."

)

FumingZhang · 2026-02-05T04:21:55Z

/azp run

azure-pipelines · 2026-02-05T04:22:08Z

Azure Pipelines successfully started running 2 pipeline(s).

FumingZhang · 2026-02-05T04:23:26Z

src/aks-preview/azext_aks_preview/tests/latest/test_aks_commands.py

        self.cmd(delete_cmd, checks=[self.is_empty()])

+    @AllowLargeResponse()
+    @AKSCustomResourceGroupPreparer(


Queued live test to validate the change, test passed!

Please also commit recording files to pass CI check

FumingZhang · 2026-02-05T04:24:15Z

src/aks-preview/azext_aks_preview/_params.py

            arg_type=get_enum_type(app_routing_nginx_configs),
            options_list=["--app-routing-default-nginx-controller", "--ardnc"]
        )
+        c.argument("enable_default_domain", action="store_true", is_preview=True)


I'm curious why only this occurrence is marked as is_preview, while the others are not.

added is_preview to the rest. Good catch!

FumingZhang · 2026-02-05T04:25:43Z

src/aks-preview/azext_aks_preview/managed_cluster_decorator.py


        return mc

    def set_up_ingress_web_app_routing(self, mc: ManagedCluster) -> ManagedCluster:


please also add some unit tests for changes in this file

FumingZhang · 2026-02-06T00:53:50Z

/azp run

azure-pipelines · 2026-02-06T00:54:04Z

Azure Pipelines successfully started running 2 pipeline(s).

FumingZhang · 2026-02-06T02:16:02Z

Azure.azure-cli-extensions (Integration Tests, Build Tests Python310)

FAILED src/aks-preview/azext_aks_preview/tests/latest/test_aks_commands.py::AzureKubernetesServiceScenarioTest::test_aks_approuting_defaultdomain
FAILED src/aks-preview/azext_aks_preview/tests/latest/test_aks_commands.py::AzureKubernetesServiceScenarioTest::test_aks_create_with_defaultdomain
FAILED src/aks-preview/azext_aks_preview/tests/latest/test_managed_cluster_decorator.py::AKSPreviewManagedClusterUpdateDecoratorTestCase::test_enable_container_network_logs

You can resolve the first 2 issues by committing the recording file to your branch, you can find them from pipeline artifact

The 3rd issue is being fixed by #9575

OliverMKing · 2026-02-10T20:29:55Z

/azp run

azure-pipelines · 2026-02-10T20:30:03Z

Commenter does not have sufficient privileges for PR 9578 in repo Azure/azure-cli-extensions

FumingZhang · 2026-02-11T02:44:14Z

src/aks-preview/HISTORY.rst

 19.0.0b22
 +++++++
 * `az aks create/update`: Automatically enable `--enable-high-log-scale-mode` when `--enable-container-network-logs` is specified. Raises an error if user explicitly disables HLSM while enabling CNL.
+* `az aks create/update`: Add `--enable-default-domain` and `--disable-default-domain` parameters to manage the default domain feature for web app routing.


it would be better to create a new version

Created a new version

OliverMKing · 2026-02-11T15:14:00Z

Should be good to go now :). Just need pipelines run

yonzhan · 2026-02-12T00:33:21Z

/azp run

azure-pipelines · 2026-02-12T00:33:35Z

Azure Pipelines successfully started running 2 pipeline(s).

yanzhudd · 2026-02-13T03:16:13Z

src/aks-preview/HISTORY.rst

+19.0.0b23
+++++++
+* `az aks create/update`: Add `--enable-default-domain` and `--disable-default-domain` parameters to manage the default domain feature for web app routing.
+


please pull the latest code from the main branch.
there should a feature in the pending session, please involve the changelog under the upcoming version:

azure-cli-extensions/src/aks-preview/HISTORY.rst

Lines 12 to 14 in 5f8e06e

Pending

+++++++

* `az aks create/update`: Add `--enable-azure-monitor-logs` support to container network logs validation.

updated to that. thank you!

FumingZhang · 2026-02-15T23:28:41Z

/azp run

azure-pipelines · 2026-02-15T23:28:54Z

Azure Pipelines successfully started running 2 pipeline(s).

OliverMKing requested a review from andyliuliming as a code owner February 5, 2026 03:46

Copilot AI review requested due to automatic review settings February 5, 2026 03:46

OliverMKing requested a review from FumingZhang as a code owner February 5, 2026 03:46

azure-client-tools-bot-prd bot added this to the March 2026 (2026-03-03) milestone Feb 5, 2026

microsoft-github-policy-service bot requested review from yanzhudd, yonzhan and zhoxing-ms February 5, 2026 03:47

Copilot started reviewing on behalf of OliverMKing February 5, 2026 03:47 View session

microsoft-github-policy-service bot assigned yanzhudd and zhoxing-ms Feb 5, 2026

microsoft-github-policy-service bot added Auto-Assign Auto assign by bot AKS labels Feb 5, 2026

OliverMKing force-pushed the kingoliver/defaultdomain branch from d35a8a2 to 34e9a1d Compare February 5, 2026 03:54

Copilot AI reviewed Feb 5, 2026

View reviewed changes

FumingZhang reviewed Feb 5, 2026

View reviewed changes

OliverMKing force-pushed the kingoliver/defaultdomain branch from f7b84f0 to 98583be Compare February 10, 2026 20:22

FumingZhang changed the title ~~add aks default domain az cli commands~~ {AKS} az aks create/update: Add --enable-default-domain and --disable-default-domain parameters to manage the default domain feature for web app routing Feb 11, 2026

FumingZhang reviewed Feb 11, 2026

View reviewed changes

OliverMKing dismissed FumingZhang’s stale review via b272b68 February 11, 2026 15:12

FumingZhang previously approved these changes Feb 12, 2026

View reviewed changes

yanzhudd reviewed Feb 13, 2026

View reviewed changes

OliverMKing added 15 commits February 13, 2026 12:53

add aks app routing default domain flags

b0c3c56

implement disable logic

cfd0f36

catch enable / disable at the same time

1d0f45c

update some stuff

16dade3

add helper

6463125

add default domain show

db6866d

add live test

4004507

add some stuff

d291762

add some additional tests

a0d8aeb

style

75f101d

add version

ba5c28e

add some tests + mark as preview

782d713

add recording

84aa667

update version

1e6646f

update the version to pending

64ecabb

OliverMKing dismissed FumingZhang’s stale review via 64ecabb February 13, 2026 17:56

OliverMKing force-pushed the kingoliver/defaultdomain branch from b272b68 to 64ecabb Compare February 13, 2026 17:56

FumingZhang approved these changes Feb 16, 2026

View reviewed changes

yanzhudd approved these changes Feb 16, 2026

View reviewed changes

yanzhudd merged commit 179e0c7 into Azure:main Feb 16, 2026
24 checks passed


		def get_nginx(self):
		"""Obtain the value of nginx, written to the update decorator context by _aks_approuting_update

-        if self.context.get_enable_default_domain() or self.context.get_disable_default_domain():
+        if self.context.get_enable_default_domain() or self.context.get_disable_default_domain():
+            # Default domain requires App Routing; make this dependency explicit to avoid
+            # implicitly enabling App Routing when the user has not requested it.
+            if not (self.context.get_enable_app_routing() or "web_application_routing" in addons):
+                raise ArgumentUsageError(
+                    "--enable-default-domain/--disable-default-domain requires either "
+                    "--enable-app-routing or --enable-addons web_application_routing."
+                )


		return mc

		def set_up_ingress_web_app_routing(self, mc: ManagedCluster) -> ManagedCluster:

	Pending
	+++++++
	* `az aks create/update`: Add `--enable-azure-monitor-logs` support to container network logs validation.

Conversation

OliverMKing commented Feb 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Related command

General Guidelines

About Extension Publish

Uh oh!

azure-client-tools-bot-prd bot commented Feb 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

azure-client-tools-bot-prd bot commented Feb 5, 2026

Uh oh!

yonzhan commented Feb 5, 2026

Uh oh!

github-actions bot commented Feb 5, 2026

Uh oh!

github-actions bot commented Feb 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Release Suggestions

Module: aks-preview

Notes

Uh oh!

github-actions bot commented Feb 5, 2026

CodeGen Tools Feedback Collection

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Feb 5, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 5, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 5, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 5, 2026

Choose a reason for hiding this comment

Uh oh!

FumingZhang commented Feb 5, 2026

Uh oh!

azure-pipelines bot commented Feb 5, 2026

Uh oh!

FumingZhang Feb 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

FumingZhang Feb 5, 2026

Choose a reason for hiding this comment

Uh oh!

OliverMKing Feb 5, 2026

Choose a reason for hiding this comment

Uh oh!

FumingZhang Feb 5, 2026

Choose a reason for hiding this comment

Uh oh!

FumingZhang commented Feb 6, 2026

Uh oh!

azure-pipelines bot commented Feb 6, 2026

Uh oh!

FumingZhang commented Feb 6, 2026

Uh oh!

OliverMKing commented Feb 10, 2026

Uh oh!

azure-pipelines bot commented Feb 10, 2026

Uh oh!

FumingZhang Feb 11, 2026

Choose a reason for hiding this comment

Uh oh!

OliverMKing Feb 11, 2026

Choose a reason for hiding this comment

Uh oh!

OliverMKing commented Feb 11, 2026

Uh oh!

yonzhan commented Feb 12, 2026

Uh oh!

azure-pipelines bot commented Feb 12, 2026

OliverMKing commented Feb 5, 2026 •

edited

Loading

azure-client-tools-bot-prd bot commented Feb 5, 2026 •

edited

Loading

github-actions bot commented Feb 5, 2026 •

edited

Loading

FumingZhang Feb 5, 2026 •

edited

Loading