Skip to content

[Containerapp] az containerapp sessionpool update: Fix issue about --no-wait and --mi-system-assigned#9583

Merged
yanzhudd merged 4 commits intoAzure:mainfrom
Greedygre:xinyu/20260209_fix_session_pool
Feb 11, 2026
Merged

[Containerapp] az containerapp sessionpool update: Fix issue about --no-wait and --mi-system-assigned#9583
yanzhudd merged 4 commits intoAzure:mainfrom
Greedygre:xinyu/20260209_fix_session_pool

Conversation

@Greedygre
Copy link
Copy Markdown
Contributor


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

az containerapp sessionpool update

  1. Fix an issue where --no-wait was exposed but not honored because it wasn’t forwarded to the underlying request
  2. Fix wrong default value for --mi-system-assigned

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@Greedygre Greedygre requested a review from howang-ms as a code owner February 9, 2026 07:58
Copilot AI review requested due to automatic review settings February 9, 2026 07:58
@Greedygre Greedygre requested a review from Juliehzl as a code owner February 9, 2026 07:58
@azure-client-tools-bot-prd
Copy link
Copy Markdown

azure-client-tools-bot-prd bot commented Feb 9, 2026

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

@azure-client-tools-bot-prd
Copy link
Copy Markdown

Hi @Greedygre,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Copy Markdown
Collaborator

yonzhan commented Feb 9, 2026

Thank you for your contribution! We will review the pull request and get back to you soon.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 9, 2026

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 9, 2026

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 9, 2026

Hi @Greedygre

Release Suggestions

Module: containerapp

  • Update VERSION to 1.3.0b2 in src/containerapp/setup.py

Notes

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes az containerapp sessionpool update behavior by properly honoring --no-wait, adjusting default handling for --mi-system-assigned to avoid unintended identity changes, and extending session pool update polling timeout.

Changes:

  • Add no_wait forwarding to the sessionpool update custom command handler.
  • Introduce a dedicated 2-hour polling timeout path for session pool updates and improve “poll returned empty” error handling.
  • Update extension changelog entries for the sessionpool update fixes.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

File Description
src/containerapp/azext_containerapp/custom.py Adds no_wait to update_session_pool and adjusts mi_system_assigned default handling.
src/containerapp/azext_containerapp/_clients.py Adds a polling helper with an extended timeout for session pool updates; refines timeout error handling/messages.
src/containerapp/HISTORY.rst Documents the sessionpool update fixes in the upcoming changelog.

@yanzhudd yanzhudd merged commit aaee9bb into Azure:main Feb 11, 2026
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Auto-Assign Auto assign by bot ContainerApp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants