[Containerapp] az containerapp sessionpool update: Fix issue about --no-wait and --mi-system-assigned#9583
Conversation
️✔️Azure CLI Extensions Breaking Change Test
|
|
Hi @Greedygre, |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
CodeGen Tools Feedback CollectionThank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey |
|
Hi @Greedygre Release SuggestionsModule: containerapp
Notes
|
There was a problem hiding this comment.
Pull request overview
This PR fixes az containerapp sessionpool update behavior by properly honoring --no-wait, adjusting default handling for --mi-system-assigned to avoid unintended identity changes, and extending session pool update polling timeout.
Changes:
- Add
no_waitforwarding to thesessionpool updatecustom command handler. - Introduce a dedicated 2-hour polling timeout path for session pool updates and improve “poll returned empty” error handling.
- Update extension changelog entries for the sessionpool update fixes.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
src/containerapp/azext_containerapp/custom.py |
Adds no_wait to update_session_pool and adjusts mi_system_assigned default handling. |
src/containerapp/azext_containerapp/_clients.py |
Adds a polling helper with an extended timeout for session pool updates; refines timeout error handling/messages. |
src/containerapp/HISTORY.rst |
Documents the sessionpool update fixes in the upcoming changelog. |
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
az containerapp sessionpool updateGeneral Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.