-
Notifications
You must be signed in to change notification settings - Fork 1.6k
[ACR] add breaking change message #9659
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
487b15f
add breaking change message
f7282a8
add doc link
760d417
fix style
a8dde69
fix style
029e7ae
log new version
c60f95b
fix style
1a8e2c1
fix test files
046ede2
add placeholder
d026f34
add test
f6404a3
Update src/acrtransfer/HISTORY.rst
nguyenm2151 75c3610
Apply suggestion from @Copilot
nguyenm2151 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| # -------------------------------------------------------------------------------------------- | ||
| # Copyright (c) Microsoft Corporation. All rights reserved. | ||
| # Licensed under the MIT License. See License.txt in the project root for license information. | ||
| # -------------------------------------------------------------------------------------------- | ||
|
|
||
| from azure.cli.core.breaking_change import register_logic_breaking_change | ||
|
|
||
| register_logic_breaking_change('acr export-pipeline create', 'Add required parameter --storage-access-mode', | ||
| detail='A new required parameter `--storage-access-mode` will be added. ' | ||
| 'Allowed values: `entra-mi-auth`, `storage-sas-token`.', | ||
| doc_link="https://aka.ms/acr/transfer") | ||
|
|
||
|
|
||
| register_logic_breaking_change('acr import-pipeline create', 'Add required parameter --storage-access-mode', | ||
| detail='A new required parameter `--storage-access-mode` will be added. ' | ||
| 'Allowed values: `entra-mi-auth`, `storage-sas-token`.', | ||
| doc_link="https://aka.ms/acr/transfer") | ||
File renamed without changes.
File renamed without changes.
416 changes: 416 additions & 0 deletions
416
...sfer/azext_acrtransfer/tests/latest/recordings/test_acrtransfer_import_pipeline_list.yaml
Large diffs are not rendered by default.
Oops, something went wrong.
5 changes: 0 additions & 5 deletions
5
src/acrtransfer/azext_acrtransfer/tests/latest/test_acrtransfer_scenario
This file was deleted.
Oops, something went wrong.
30 changes: 30 additions & 0 deletions
30
src/acrtransfer/azext_acrtransfer/tests/latest/test_acrtransfer_scenario.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| # -------------------------------------------------------------------------------------------- | ||
| # Copyright (c) Microsoft Corporation. All rights reserved. | ||
| # Licensed under the MIT License. See License.txt in the project root for license information. | ||
| # -------------------------------------------------------------------------------------------- | ||
|
|
||
| from azure.cli.testsdk import ScenarioTest, ResourceGroupPreparer | ||
|
|
||
|
|
||
| class AcrTransferScenarioTest(ScenarioTest): | ||
| @ResourceGroupPreparer() | ||
| def test_acrtransfer_import_pipeline_list(self, resource_group): | ||
| """Test listing import pipelines""" | ||
| self.kwargs.update({ | ||
| 'registry_name': self.create_random_name('acr', 20), | ||
| 'rg': resource_group, | ||
| 'location': 'eastus', | ||
| 'sku': 'Premium' | ||
| }) | ||
|
|
||
| self.cmd('acr create -n {registry_name} -g {rg} -l {location} --sku {sku}', checks=[ | ||
| self.check('name', '{registry_name}'), | ||
| self.check('location', '{location}'), | ||
| self.check('sku.name', '{sku}') | ||
| ]) | ||
|
|
||
| self.cmd('acr import-pipeline list -r {registry_name} -g {rg}', checks=[ | ||
| self.check('length(@)', 0) | ||
| ]) | ||
| self.cmd('acr delete -n {registry_name} -g {rg} -y') | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.