[AKS] az aks nodepool add/update --enable-managed-gpu option #9704
[AKS] az aks nodepool add/update --enable-managed-gpu option #9704yanzhudd merged 19 commits intoAzure:mainfrom
Conversation
❌Azure CLI Extensions Breaking Change Test
|
|
Hi @runzhen, |
There was a problem hiding this comment.
Pull request overview
Adds a preview --enable-managed-gpu flag to AKS nodepool add/update flows, wiring it through argument parsing, decorators, help text, and tests to set gpuProfile.nvidia.managementMode=Managed.
Changes:
- Add
--enable-managed-gputoaz aks nodepool addandaz aks nodepool updateargument sets and help. - Decorate AgentPool objects to set
gpu_profile.nvidia.management_mode = "Managed"when enabled. - Add unit and live tests verifying the flag sets
gpuProfile.nvidia.managementModetoManaged.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| src/aks-preview/azext_aks_preview/tests/latest/test_aks_commands.py | Adds live-only tests for nodepool add/update with --enable-managed-gpu. |
| src/aks-preview/azext_aks_preview/tests/latest/test_agentpool_decorator.py | Adds unit tests for context getter + add/update decorator behaviors for managed GPU. |
| src/aks-preview/azext_aks_preview/custom.py | Extends nodepool add/update custom function signatures with enable_managed_gpu. |
| src/aks-preview/azext_aks_preview/agentpool_decorator.py | Implements get_enable_managed_gpu, plus add/update mutation for managed GPU on AgentPool. |
| src/aks-preview/azext_aks_preview/_params.py | Registers enable_managed_gpu CLI argument for nodepool add/update. |
| src/aks-preview/azext_aks_preview/_help.py | Documents --enable-managed-gpu in command help. |
| src/aks-preview/azext_aks_preview/_consts.py | Adds constants for GPU management mode values. |
| src/aks-preview/HISTORY.rst | Adds changelog entry for the new managed GPU option. |
You can also share your feedback on Copilot code review. Take the survey.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
CodeGen Tools Feedback CollectionThank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey |
|
Hi @runzhen Release SuggestionsModule: aks-preview
Notes
|
1 similar comment
|
Hi @runzhen Release SuggestionsModule: aks-preview
Notes
|
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
@FumingZhang , can you run the pipeline again? |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
@FumingZhang can you run pipeline again ? |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
Hi @yanzhudd @FumingZhang , anything else need I to do? can you merge this PR now? |
Add managed GPU enablement option to node pool property in
az aks nodepool addandaz aks nodepool updateThis checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.