Skip to content

Quantum: update create new workspace template, fix e2e tests #9711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
necusjz merged 10 commits into from
Apr 16, 2026
Merged

Quantum: update create new workspace template, fix e2e tests #9711

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
b0cd555
Update create new workspace template, fix storage handling bug in submit
rigidit Mar 23, 2026
259562b
Updated History and setup
rigidit Mar 24, 2026
5124d31
Disable access keys only for new storage accounts, change default sto…
rigidit Mar 24, 2026
2c64b81
Updated History.rst
rigidit Mar 24, 2026
b2e82ec
Fixed get provider test
rigidit Mar 24, 2026
fe6837e
Improve create workspace template, add live test for job submission w…
rigidit Apr 7, 2026
9349066
Wait for role assignments to propagate in tests so the new workspace …
rigidit Apr 7, 2026
9987034
Minor wording fixes
rigidit Apr 7, 2026
5fa9a44
Revert passing storage when connecting to workspace in job submit
rigidit Apr 8, 2026
b4108de
Update api version in workspace template
rigidit Apr 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/quantum/HISTORY.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,11 @@
Release History
===============

1.0.0b13
+++++++++++++++
* Updated workspace create command to support job submissions with disabled access keys on linked storage account
* Updated new storage account to be v2 in workspace creation because of the retirement of General-Purpose v1 (GPv1) storage accounts on October 13, 2026

1.0.0b12
+++++++++++++++
* Added support for Data Plane v2 including specifying priority parameter as part of job params when submitting a job
Expand Down
35 changes: 30 additions & 5 deletions src/quantum/azext_quantum/operations/templates/create-workspace-and-assign-role.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,14 +62,24 @@
"metadata": {
"description": "Deployment name for role assignment operation"
}
},
"storageAccountAllowSharedKeyAccess": {
"type": "bool",
"defaultValue": false,
"metadata": {
"description": "Whether to allow shared key access on the storage account. Defaults to false (secure) for new accounts; existing accounts should pass their current value to avoid breaking changes."
}
}
},
"functions": [],
"variables": {},
"variables": {
"storageAccountContributorRoleId": "17d1049b-9a84-46fb-8f53-869881c3d3ab",
Comment thread
rigidit marked this conversation as resolved.
"storageBlobDataContributorRoleId": "ba92f5b4-2d11-453d-a403-e96b0029c9fe"
},
"resources": [
{
"type": "Microsoft.Quantum/workspaces",
"apiVersion": "2019-11-04-preview",
"apiVersion": "2025-12-15-preview",
"name": "[parameters('quantumWorkspaceName')]",
"location": "[parameters('location')]",
"tags": "[parameters('tags')]",
Expand Down Expand Up @@ -105,6 +115,7 @@
"kind": "[parameters('storageAccountKind')]",
"properties": {
"allowBlobPublicAccess": false,
"allowSharedKeyAccess": "[parameters('storageAccountAllowSharedKeyAccess')]",
"minimumTlsVersion": "TLS1_2"
},
"resources": [
Expand Down Expand Up @@ -145,12 +156,26 @@
},
{
"apiVersion": "2020-04-01-preview",
"name": "[concat(parameters('storageAccountName'), '/Microsoft.Authorization/', guid(reference(concat('Microsoft.Quantum/Workspaces/', parameters('quantumWorkspaceName')), '2019-11-04-preview', 'Full').identity.principalId))]",
"name": "[concat(parameters('storageAccountName'), '/Microsoft.Authorization/', guid(reference(concat('Microsoft.Quantum/Workspaces/', parameters('quantumWorkspaceName')), '2025-12-15-preview', 'Full').identity.principalId, variables('storageAccountContributorRoleId')))]",
"type": "Microsoft.Storage/storageAccounts/providers/roleAssignments",
"location": "[parameters('storageAccountLocation')]",
"properties": {
"roleDefinitionId": "[resourceId('Microsoft.Authorization/roleDefinitions', variables('storageAccountContributorRoleId'))]",
"principalId": "[reference(concat('Microsoft.Quantum/Workspaces/', parameters('quantumWorkspaceName')), '2025-12-15-preview', 'Full').identity.principalId]",
"principalType": "ServicePrincipal"
},
"dependsOn": [
"[parameters('storageAccountId')]"
]
},
{
"apiVersion": "2020-04-01-preview",
"name": "[concat(parameters('storageAccountName'), '/Microsoft.Authorization/', guid(reference(concat('Microsoft.Quantum/Workspaces/', parameters('quantumWorkspaceName')), '2025-12-15-preview', 'Full').identity.principalId, variables('storageBlobDataContributorRoleId')))]",
"type": "Microsoft.Storage/storageAccounts/providers/roleAssignments",
"location": "[parameters('storageAccountLocation')]",
"properties": {
"roleDefinitionId": "[resourceId('Microsoft.Authorization/roleDefinitions', '17d1049b-9a84-46fb-8f53-869881c3d3ab')]",
"principalId": "[reference(concat('Microsoft.Quantum/Workspaces/', parameters('quantumWorkspaceName')), '2019-11-04-preview', 'Full').identity.principalId]",
"roleDefinitionId": "[resourceId('Microsoft.Authorization/roleDefinitions', variables('storageBlobDataContributorRoleId'))]",
"principalId": "[reference(concat('Microsoft.Quantum/Workspaces/', parameters('quantumWorkspaceName')), '2025-12-15-preview', 'Full').identity.principalId]",
"principalType": "ServicePrincipal"
},
"dependsOn": [
Expand Down
8 changes: 7 additions & 1 deletion src/quantum/azext_quantum/operations/workspace.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
DEFAULT_WORKSPACE_LOCATION = 'westus'
DEFAULT_STORAGE_SKU = 'Standard_LRS'
DEFAULT_STORAGE_SKU_TIER = 'Standard'
DEFAULT_STORAGE_KIND = 'Storage'
DEFAULT_STORAGE_KIND = 'StorageV2'
SUPPORTED_STORAGE_SKU_TIERS = ['Standard']
SUPPORTED_STORAGE_KINDS = ['Storage', 'StorageV2']
DEPLOYMENT_NAME_PREFIX = 'Microsoft.AzureQuantum-'
Expand Down Expand Up @@ -240,6 +240,7 @@ def create(cmd, resource_group_name, workspace_name, location, storage_account,
storage_account_sku_tier = DEFAULT_STORAGE_SKU_TIER
storage_account_kind = DEFAULT_STORAGE_KIND
storage_account_location = location
storage_account_allow_shared_key_access = False # Secure default for new accounts

# Look for info on existing storage account
storage_account_list = list_storage_accounts(cmd, resource_group_name)
Expand All @@ -250,6 +251,10 @@ def create(cmd, resource_group_name, workspace_name, location, storage_account,
storage_account_sku_tier = storage_account_info.sku.tier
storage_account_kind = storage_account_info.kind
storage_account_location = storage_account_info.location
# Preserve the existing account's setting to avoid breaking customers
# who rely on shared-key auth/connection strings for that account.
if storage_account_info.allow_shared_key_access is not None:
storage_account_allow_shared_key_access = storage_account_info.allow_shared_key_access
break

# Validate the storage account SKU tier and kind
Expand All @@ -266,6 +271,7 @@ def create(cmd, resource_group_name, workspace_name, location, storage_account,
'storageAccountLocation': storage_account_location,
'storageAccountSku': storage_account_sku,
'storageAccountKind': storage_account_kind,
'storageAccountAllowSharedKeyAccess': storage_account_allow_shared_key_access,
'storageAccountDeploymentName': "Microsoft.StorageAccount-" + time.strftime("%d-%b-%Y-%H-%M-%S", time.gmtime())
}
parameters = {k: {'value': v} for k, v in parameters.items()}
Expand Down
Loading
Loading