Skip to content

[AKS] clean up some dead code #9768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yanzhudd merged 4 commits into from
Apr 14, 2026
+1 −6
Merged

[AKS] clean up some dead code #9768

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c3cc268
clean up
runzhen Apr 8, 2026
c4c97b3
remove dead code
runzhen Apr 9, 2026
148ce1c
add more comments
runzhen Apr 9, 2026
f9770be
Merge branch 'main' into mig
runzhen Apr 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/aks-preview/HISTORY.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ To release a new version, please select a new version number (usually plus 1 to

Pending
+++++++
* `az aks nodepool update`: clean up some useless code in the update managed gpu function.
* `az aks machine add`: Add `--spot-max-price` flag support to set the max price (in US Dollars) you are willing to pay for spot instances on a machine.
* `az aks machine add`: Add `--eviction-policy` flag support to set the eviction policy for a machine.
* `az aks machine add`: Add `--enable-ultra-ssd` flag support to enable ultra ssd on a machine.
Expand Down
6 changes: 0 additions & 6 deletions src/aks-preview/azext_aks_preview/agentpool_decorator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1826,16 +1826,10 @@ def update_managed_gpu(self, agentpool: AgentPool) -> AgentPool:
agentpool.gpu_profile = self.models.GPUProfile() # pylint: disable=no-member
if agentpool.gpu_profile.nvidia is None:
agentpool.gpu_profile.nvidia = self.models.NvidiaGPUProfile() # pylint: disable=no-member
# Check if already set to the desired value to avoid API error
if agentpool.gpu_profile.nvidia.management_mode == CONST_GPU_MANAGEMENT_MODE_MANAGED:
return agentpool
agentpool.gpu_profile.nvidia.management_mode = CONST_GPU_MANAGEMENT_MODE_MANAGED
agentpool.gpu_profile.driver = CONST_GPU_DRIVER_INSTALL
else:
if agentpool.gpu_profile and agentpool.gpu_profile.nvidia:
# Check if already set to the desired value to avoid API error
if agentpool.gpu_profile.nvidia.management_mode == CONST_GPU_MANAGEMENT_MODE_UNMANAGED:
return agentpool
agentpool.gpu_profile.nvidia.management_mode = CONST_GPU_MANAGEMENT_MODE_UNMANAGED

return agentpool
Expand Down
Loading