Skip to content

[SSH] Update error message for OpenSSH version incompatility #9777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vthiebaut10 wants to merge 1 commit into from
Closed

[SSH] Update error message for OpenSSH version incompatility #9777

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/ssh/azext_ssh/ssh_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,14 +251,16 @@ def _check_for_known_errors(error_message, delete_cert, log_lines):
(local_major > 8 or (local_major == 8 and local_minor >= 8)):
logger.warning("The OpenSSH server version in the target VM %d.%d is too old. "
"Version incompatible with OpenSSH client version %d.%d. "
"Refer to https://bugzilla.mindrot.org/show_bug.cgi?id=3351 for more information.",
"Refer to \"Potentially-incompatible changes\" in "
"https://www.openssh.org/txt/release-8.8 for more information.",
remote_major, remote_minor, local_major, local_minor)
Comment on lines 252 to 256
Copy link

Copilot AI Apr 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same reference text/URL is duplicated across both warnings. To reduce drift and make future updates easier, store the reference (section text + URL) in a single constant (or local variable) and reuse it in both logger.warning calls.

Copilot uses AI. Check for mistakes.

elif (local_major < 7 or (local_major == 7 and local_minor < 8)) and \
(remote_major > 8 or (remote_major == 8 and remote_minor >= 8)):
logger.warning("The OpenSSH client version %d.%d is too old. "
"Version incompatible with OpenSSH server version %d.%d in the target VM. "
"Refer to https://bugzilla.mindrot.org/show_bug.cgi?id=3351 for more information.",
"Refer to \"Potentially-incompatible changes\" in "
"https://www.openssh.org/txt/release-8.8 for more information.",
local_major, local_minor, remote_major, remote_minor)
Comment on lines 260 to 264
Copy link

Copilot AI Apr 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same reference text/URL is duplicated across both warnings. To reduce drift and make future updates easier, store the reference (section text + URL) in a single constant (or local variable) and reuse it in both logger.warning calls.

Copilot uses AI. Check for mistakes.

regex = ("{\"level\":\"fatal\",\"msg\":\"sshproxy: error copying information from the connection: "
Expand Down
Loading