fix: bug that wiped acns perf acceleration mode due to full put#9779
fix: bug that wiped acns perf acceleration mode due to full put#9779santhoshmprabhu wants to merge 3 commits intoAzure:mainfrom
Conversation
santhoshmprabhu
requested review from
FumingZhang and
andyliuliming
as code owners
️✔️Azure CLI Extensions Breaking Change Test
|
|
Hi @santhoshmprabhu, |
microsoft-github-policy-service
bot
requested review from
yanzhudd,
yonzhan and
zhoxing-ms
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
CodeGen Tools Feedback CollectionThank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey |
Release SuggestionsModule: aks-preview
Notes
|
There was a problem hiding this comment.
Pull request overview
Fixes an az aks update behavior in aks-preview where a full PUT on networkProfile.advancedNetworking could unintentionally wipe the existing ACNS performance acceleration mode when the user didn’t re-specify it.
Changes:
- Updated
get_acns_enablement()to return ACNS enablement including performance (4-tuple). - Updated ACNS update logic to preserve the existing
advanced_networking.performancewhen performance acceleration mode isn’t explicitly set during updates.
| @@ -851,15 +851,15 @@ def get_enable_cilium_dataplane(self) -> bool: | |||
| return bool(self.raw_param.get('enable_cilium_dataplane')) | |||
|
|
|||
| def get_acns_enablement(self) -> Tuple[ | |||
There was a problem hiding this comment.
Please include a unit test case for this change. It's surprising that modifying the function signature and return value structure didn't break any existing cases.
There was a problem hiding this comment.
The two signatures are exactly the same, we're in the process of removing the with_perf function across GA and extensions.
There was a problem hiding this comment.
Updated UTs.
|
Azure Pipelines: Successfully started running 2 pipeline(s). |
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
az aks updatein aks-preview would do a full put on advanced networking profile. The acceleration mode in the profile wasn't being checked in the current MC, so each time the acceleration mode needed to be set again to prevent being wiped out.General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.