{Serial Console} Migrate commands calling Compute module to aaz-based implementation by william051200 · Pull Request #9781 · Azure/azure-cli-extensions

william051200 · 2026-04-14T05:34:56Z

Migration from mgmt.compute to aaz-based

This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
My extension version conforms to the Extension version schema

For new extensions:

My extension description/summary conforms to the Extension Summary Guidelines.

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

azure-client-tools-bot-prd · 2026-04-14T05:35:01Z

️✔️Azure CLI Extensions Breaking Change Test

️✔️Non Breaking Changes

yonzhan · 2026-04-14T05:36:17Z

Thank you for your contribution! We will review the pull request and get back to you soon.

github-actions · 2026-04-14T05:36:19Z

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

Copilot

Pull request overview

This PR migrates the serial-console extension’s compute-related operations from azure.mgmt.compute client usage to Azure CLI’s AAZ-based compute command implementations, and publishes the migration as a new stable extension release.

Changes:

Switch VM/VMSS lookups in custom.py to AAZ-based command execution and update parsing to dictionary-style responses.
Remove the compute management client factory no longer needed after the migration.
Bump extension version and add release notes for the migration.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File	Description
`src/serial-console/setup.py`	Bumps the extension version to `1.1.0`.
`src/serial-console/azext_serialconsole/custom.py`	Migrates VM/VMSS compute calls to AAZ-based command usage and updates instance view parsing/error handling.
`src/serial-console/azext_serialconsole/_client_factory.py`	Removes the legacy compute client factory.
`src/serial-console/HISTORY.rst`	Adds `1.1.0` release entry documenting the migration.

Copilot · 2026-04-14T05:47:31Z

+        except HttpResponseError as e:
            try:
-                client.virtual_machine_scale_sets.get(resource_group_name, vm_vmss_name)
-            except ComputeClientResourceNotFoundError:
+                command_args = {
+                    'resource_group': resource_group_name,
+                    'vm_scale_set_name': vm_vmss_name
+                }
+                VMSSShow(cli_ctx=cli_ctx)(command_args=command_args)
+            except HttpResponseError:
                raise e from e
            error_message = e.message
            recommendation = ("We found that you specified a Virtual Machine Scale Set and not a VM. "
                              "Use the --instance-id parameter to select the VMSS instance you want to connect to.")
-            raise ResourceNotFoundError(
-                error_message, recommendation=recommendation) from e
+            raise ResourceNotFoundError(error_message, recommendation=recommendation) from e


The except HttpResponseError block will also catch non-404 failures (authz, throttling, transient network issues). In those cases, the code may incorrectly treat the VM lookup failure as a VMSS/VM mix-up and raise a ResourceNotFoundError with a misleading recommendation. Narrow the handler to azure.core.exceptions.ResourceNotFoundError (or check the HTTP status code == 404) and re-raise other HttpResponseErrors unchanged.

Copilot · 2026-04-14T05:47:31Z

@@ -704,40 +701,44 @@ def get_region_from_storage_account(cli_ctx, resource_group_name, vm_vmss_name,
                              'MyScaleSet -g MyResourceGroup --instance-ids *".')


The recommendation command string has an extra trailing quote after the JSON payload (...StorageUri\" : null}}\"\" ...), which makes the suggested az vmss update --set ... command invalid / hard to copy-paste. Remove the redundant quote so the JSON string is quoted exactly once in the rendered command.

azure-pipelines · 2026-04-15T00:49:38Z