[confcom] Windows support for the tooling#9783
Open
MahatiC wants to merge 31 commits intoAzure:mainfrom
Open
Conversation
…cy config for vn2
And add a fix to framework for rw_mount
…l 2.0.0 Suggested-by: Ken Gordon <kegordo@microsoft.com>
…t_device enforcement point This fixes unit tests
This is not, in fact, where parameters and variables are populated. That happens in the constructor for AciPolicy.
… parameters/variables
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| confcom acipolicygen | cmd confcom acipolicygen added parameter platform |
|
Hi @MahatiC, |
|
Azure Pipelines: 2 pipeline(s) require an authorized user to comment /azp run to run. |
MahatiC
changed the title
|
Azure Pipelines: 2 pipeline(s) require an authorized user to comment /azp run to run. |
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
Contributor
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
Contributor
|
Hi @MahatiC
|
github-actions
bot
added
the
release-version-block
MahatiC
force-pushed
the
latest-windows-support
branch
from
8910a7d to
fa1c0e2
Compare
|
Azure Pipelines: 2 pipeline(s) require an authorized user to comment /azp run to run. |
1 similar comment
|
Azure Pipelines: 2 pipeline(s) require an authorized user to comment /azp run to run. |
MahatiC
force-pushed
the
latest-windows-support
branch
from
3b54c39 to
53515f9
Compare
|
Azure Pipelines: 2 pipeline(s) require an authorized user to comment /azp run to run. |
|
Azure Pipelines: 2 pipeline(s) require an authorized user to comment /azp run to run. |
MahatiC
force-pushed
the
latest-windows-support
branch
from
4676ca8 to
f3e726c
Compare
|
Azure Pipelines: 2 pipeline(s) require an authorized user to comment /azp run to run. |
|
Azure Pipelines: 2 pipeline(s) require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds Windows container support to the confcom extension tooling by introducing a --platform switch (linux/amd64 vs windows/amd64), updating policy generation templates, and extending layer hashing to support Windows CIM-based flows.
Changes:
- Introduce
--platformacross policy generation entrypoints and propagate platform into container definitions/policy serialization. - Update dmverity-vhd integration to v2.0 and adjust layer hashing/parsing to support Windows outputs (including
mounted_cim). - Bump policy API version references to
0.11.0and update samples/docs accordingly.
Reviewed changes
Copilot reviewed 177 out of 178 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| src/confcom/setup.py | Bump extension version to 2.0.0b1 (preview). |
| src/confcom/HISTORY.rst | Add 2.0.0b1 release notes for Windows support. |
| src/confcom/README.md | Document platform support and Windows requirements. |
| src/confcom/azext_confcom/azext_metadata.json | Mark extension as preview. |
| src/confcom/azext_confcom/_params.py | Add --platform (linux/amd64, windows/amd64) to policy generation. |
| src/confcom/azext_confcom/_help.py | Document --platform usage and clarify containers-from-image --platform meaning (aci/vn2). |
| src/confcom/azext_confcom/custom.py | Thread platform through CLI entrypoints to policy generation and containers-from-image plumbing. |
| src/confcom/azext_confcom/security_policy.py | Add platform-aware policy boilerplate, platform validation, debug-mode exec selection, and Windows layer support (mounted_cim). |
| src/confcom/azext_confcom/template_util.py | Augment image info with detected platform; attempt multi-platform pulls. |
| src/confcom/azext_confcom/rootfs_proxy.py | Upgrade dmverity-vhd URLs/hashes and parse JSON output including Windows mounted_cim. |
| src/confcom/azext_confcom/config.py | Add Windows rego policy template and Windows debug mode settings; support mounted_cim field. |
| src/confcom/azext_confcom/container.py | Add platform tracking to container images and emit platform-specific policy JSON (Linux vs Windows fields). |
| src/confcom/azext_confcom/lib/images.py | Add multi-platform pull helpers and pass --platform to hashing binary. |
| src/confcom/azext_confcom/lib/containers.py | Add platform into container definitions and disambiguate aci/vn2 vs image platform. |
| src/confcom/azext_confcom/lib/defaults.py | Provide platform-specific debug-mode exec process defaults. |
| src/confcom/azext_confcom/lib/policy.py | Bump default api_version to 0.11.0. |
| src/confcom/azext_confcom/lib/serialization.py | Add rw_mount_device binding in serialized rego output. |
| src/confcom/azext_confcom/data/internal_config.json | Bump API version and add Windows debug mode config. |
| src/confcom/azext_confcom/data/customer_rego_policy.txt | Add rw_mount_device binding to Linux rego boilerplate template. |
| src/confcom/azext_confcom/data/customer_rego_policy_windows.txt | Add Windows-specific rego boilerplate template. |
| src/confcom/azext_confcom/data/README | Clarify “old style” vs new policy model locations. |
| src/confcom/azext_confcom/docs/policy_enforcement_points.md | Update example API version and add rw_mount_device binding. |
| src/confcom/azext_confcom/README.md | Update example API version and add rw_mount_device binding. |
| src/confcom/azext_confcom/sample_policy.md | Add rw_mount_device binding to sample policy doc. |
| src/confcom/azext_confcom/command/containers_from_image.py | Rename internal arg to aci_or_vn2 to disambiguate “platform”. |
| src/confcom/azext_confcom/command/containers_from_vn2.py | Update call to containers-from-image helper with new arg name. |
| src/confcom/azext_confcom/tests/latest/test_confcom_scenario.py | Adjust context-manager nesting for assertRaises(SystemExit) test. |
| src/confcom/azext_confcom/tests/latest/test_confcom_image.py | Ensure invalid-image policy generation is asserted inside assertRaises. |
| src/confcom/azext_confcom/tests/latest/test_confcom_containers_from_image.py | Update containers-from-image call to new aci_or_vn2 argument name. |
| src/confcom/samples/policies/allow_all.rego | Bump sample API version to 0.11.0. |
| src/confcom/samples/sample-policy-output.rego | Add a sample policy output file. |
| src/confcom/samples/aci/minimal/arm_template.json | Embed updated base64 policy output in sample ARM template. |
| src/confcom/samples/aci/volume_mounts/policy.rego | Bump API version and add rw_mount_device binding. |
| src/confcom/samples/aci/volume_mounts/policy_debug.rego | Bump API version and add rw_mount_device binding. |
| src/confcom/samples/aci/volume_mounts/policy_disable_stdio.rego | Bump API version and add rw_mount_device binding. |
| src/confcom/samples/aci/volume_mounts/policy_exclude_default_fragment.rego | Bump API version and add rw_mount_device binding. |
| src/confcom/samples/aci/volume_mounts/policy_fragment.rego | Bump API version and add rw_mount_device binding. |
| src/confcom/samples/aci/volume_mounts/policy_fragment_plus_infrastructure_svn.rego | Bump API version and add rw_mount_device binding. |
| src/confcom/samples/aci/volume_mounts/policy_infrastructure_svn.rego | Bump API version and add rw_mount_device binding. |
| src/confcom/samples/aci/volume_mount_secret/policy.rego | Bump API version and add rw_mount_device binding. |
| src/confcom/samples/aci/volume_mount_secret/policy_debug.rego | Bump API version and add rw_mount_device binding. |
| src/confcom/samples/aci/volume_mount_secret/policy_disable_stdio.rego | Bump API version and add rw_mount_device binding. |
| src/confcom/samples/aci/volume_mount_secret/policy_exclude_default_fragment.rego | Bump API version and add rw_mount_device binding. |
| src/confcom/samples/aci/volume_mount_secret/policy_fragment.rego | Bump API version and add rw_mount_device binding. |
| src/confcom/samples/aci/volume_mount_secret/policy_fragment_plus_infrastructure_svn.rego | Bump API version and add rw_mount_device binding. |
| src/confcom/samples/aci/volume_mount_secret/policy_infrastructure_svn.rego | Bump API version and add rw_mount_device binding. |
| src/confcom/samples/aci/variables/policy.rego | Bump API version and add rw_mount_device binding. |
| src/confcom/samples/aci/variables/policy_debug.rego | Bump API version and add rw_mount_device binding. |
| src/confcom/samples/aci/variables/policy_disable_stdio.rego | Bump API version and add rw_mount_device binding. |
| src/confcom/samples/aci/variables/policy_exclude_default_fragment.rego | Bump API version and add rw_mount_device binding. |
| src/confcom/samples/aci/variables/policy_fragment.rego | Bump API version and add rw_mount_device binding. |
| src/confcom/samples/aci/variables/policy_fragment_plus_infrastructure_svn.rego | Bump API version and add rw_mount_device binding. |
| src/confcom/samples/aci/variables/policy_infrastructure_svn.rego | Bump API version and add rw_mount_device binding. |
| src/confcom/samples/aci/security_context_run_as_user/policy.rego | Bump API version and add rw_mount_device binding. |
| src/confcom/samples/aci/security_context_run_as_user/policy_debug.rego | Bump API version and add rw_mount_device binding. |
| src/confcom/samples/aci/security_context_run_as_user/policy_disable_stdio.rego | Bump API version and add rw_mount_device binding. |
| src/confcom/samples/aci/security_context_run_as_user/policy_exclude_default_fragment.rego | Bump API version and add rw_mount_device binding. |
| src/confcom/samples/aci/security_context_run_as_user/policy_fragment.rego | Bump API version and add rw_mount_device binding. |
| src/confcom/samples/aci/security_context_run_as_user/policy_fragment_plus_infrastructure_svn.rego | Bump API version and add rw_mount_device binding. |
| src/confcom/samples/aci/security_context_run_as_user/policy_infrastructure_svn.rego | Bump API version and add rw_mount_device binding. |
| src/confcom/samples/aci/security_context_run_as_group/policy.rego | Bump API version and add rw_mount_device binding. |
| src/confcom/samples/aci/security_context_run_as_group/policy_debug.rego | Bump API version and add rw_mount_device binding. |
| src/confcom/samples/aci/security_context_run_as_group/policy_disable_stdio.rego | Bump API version and add rw_mount_device binding. |
| src/confcom/samples/aci/security_context_run_as_group/policy_exclude_default_fragment.rego | Bump API version and add rw_mount_device binding. |
| src/confcom/samples/aci/security_context_run_as_group/policy_fragment.rego | Bump API version and add rw_mount_device binding. |
| src/confcom/samples/aci/security_context_run_as_group/policy_fragment_plus_infrastructure_svn.rego | Bump API version and add rw_mount_device binding. |
| src/confcom/samples/aci/security_context_run_as_group/policy_infrastructure_svn.rego | Bump API version and add rw_mount_device binding. |
| src/confcom/samples/aci/security_context_capabilities_drop/policy.rego | Bump API version and add rw_mount_device binding. |
| src/confcom/samples/aci/security_context_capabilities_drop/policy_debug.rego | Bump API version and add rw_mount_device binding. |
| src/confcom/samples/aci/security_context_capabilities_drop/policy_disable_stdio.rego | Bump API version and add rw_mount_device binding. |
| src/confcom/samples/aci/security_context_capabilities_drop/policy_exclude_default_fragment.rego | Bump API version and add rw_mount_device binding. |
| src/confcom/samples/aci/security_context_capabilities_drop/policy_fragment.rego | Bump API version and add rw_mount_device binding. |
| src/confcom/samples/aci/security_context_capabilities_drop/policy_fragment_plus_infrastructure_svn.rego | Bump API version and add rw_mount_device binding. |
| src/confcom/samples/aci/security_context_capabilities_drop/policy_infrastructure_svn.rego | Bump API version and add rw_mount_device binding. |
| src/confcom/samples/aci/security_context_capabilities_add_drop/policy.rego | Bump API version and add rw_mount_device binding. |
| src/confcom/samples/aci/security_context_capabilities_add_drop/policy_debug.rego | Bump API version and add rw_mount_device binding. |
| src/confcom/samples/aci/security_context_capabilities_add_drop/policy_disable_stdio.rego | Bump API version and add rw_mount_device binding. |
| src/confcom/samples/aci/security_context_capabilities_add_drop/policy_exclude_default_fragment.rego | Bump API version and add rw_mount_device binding. |
| src/confcom/samples/aci/security_context_capabilities_add_drop/policy_fragment.rego | Bump API version and add rw_mount_device binding. |
| src/confcom/samples/aci/security_context_capabilities_add_drop/policy_fragment_plus_infrastructure_svn.rego | Bump API version and add rw_mount_device binding. |
| src/confcom/samples/aci/security_context_capabilities_add_drop/policy_infrastructure_svn.rego | Bump API version and add rw_mount_device binding. |
| src/confcom/samples/aci/security_context_capabilities_add/policy.rego | Bump API version and add rw_mount_device binding. |
| src/confcom/samples/aci/security_context_capabilities_add/policy_debug.rego | Bump API version and add rw_mount_device binding. |
| src/confcom/samples/aci/security_context_capabilities_add/policy_disable_stdio.rego | Bump API version and add rw_mount_device binding. |
| src/confcom/samples/aci/security_context_capabilities_add/policy_exclude_default_fragment.rego | Bump API version and add rw_mount_device binding. |
| src/confcom/samples/aci/security_context_capabilities_add/policy_fragment.rego | Bump API version and add rw_mount_device binding. |
| src/confcom/samples/aci/security_context_capabilities_add/policy_fragment_plus_infrastructure_svn.rego | Bump API version and add rw_mount_device binding. |
| src/confcom/samples/aci/security_context_capabilities_add/policy_infrastructure_svn.rego | Bump API version and add rw_mount_device binding. |
| src/confcom/samples/aci/multi_containers/policy.rego | Bump API version and add rw_mount_device binding. |
| src/confcom/samples/aci/multi_containers/policy_debug.rego | Bump API version and add rw_mount_device binding. |
| src/confcom/samples/aci/multi_containers/policy_disable_stdio.rego | Bump API version and add rw_mount_device binding. |
| src/confcom/samples/aci/multi_containers/policy_exclude_default_fragment.rego | Bump API version and add rw_mount_device binding. |
| src/confcom/samples/aci/multi_containers/policy_fragment.rego | Bump API version and add rw_mount_device binding. |
| src/confcom/samples/aci/multi_containers/policy_fragment_plus_infrastructure_svn.rego | Bump API version and add rw_mount_device binding. |
| src/confcom/samples/aci/multi_containers/policy_infrastructure_svn.rego | Bump API version and add rw_mount_device binding. |
| src/confcom/samples/aci/multi_container_groups/policy.rego | Bump API version and add rw_mount_device binding (multi-group example). |
| src/confcom/samples/aci/multi_container_groups/policy_debug.rego | Bump API version and add rw_mount_device binding (multi-group example). |
| src/confcom/samples/aci/multi_container_groups/policy_disable_stdio.rego | Bump API version and add rw_mount_device binding (multi-group example). |
| src/confcom/samples/aci/multi_container_groups/policy_exclude_default_fragment.rego | Bump API version and add rw_mount_device binding (multi-group example). |
| src/confcom/samples/aci/multi_container_groups/policy_fragment_plus_infrastructure_svn.rego | Bump API version and add rw_mount_device binding (multi-group example). |
| src/confcom/samples/aci/multi_container_groups/policy_infrastructure_svn.rego | Bump API version and add rw_mount_device binding (multi-group example). |
| src/confcom/samples/aci/minimal/policy.rego | Bump API version and add rw_mount_device binding. |
| src/confcom/samples/aci/minimal/policy_debug.rego | Bump API version and add rw_mount_device binding. |
| src/confcom/samples/aci/minimal/policy_disable_stdio.rego | Bump API version and add rw_mount_device binding. |
| src/confcom/samples/aci/minimal/policy_exclude_default_fragment.rego | Bump API version and add rw_mount_device binding. |
| src/confcom/samples/aci/minimal/policy_fragment.rego | Bump API version and add rw_mount_device binding. |
| src/confcom/samples/aci/minimal/policy_fragment_plus_infrastructure_svn.rego | Bump API version and add rw_mount_device binding. |
| src/confcom/samples/aci/minimal/policy_infrastructure_svn.rego | Bump API version and add rw_mount_device binding. |
| src/confcom/samples/aci/existing_policy_allow_all/policy.rego | Bump API version and add rw_mount_device binding. |
| src/confcom/samples/aci/existing_policy_allow_all/policy_debug.rego | Bump API version and add rw_mount_device binding. |
| src/confcom/samples/aci/existing_policy_allow_all/policy_disable_stdio.rego | Bump API version and add rw_mount_device binding. |
| src/confcom/samples/aci/existing_policy_allow_all/policy_exclude_default_fragment.rego | Bump API version and add rw_mount_device binding. |
| src/confcom/samples/aci/existing_policy_allow_all/policy_fragment.rego | Bump API version and add rw_mount_device binding. |
| src/confcom/samples/aci/existing_policy_allow_all/policy_fragment_plus_infrastructure_svn.rego | Bump API version and add rw_mount_device binding. |
| src/confcom/samples/aci/existing_policy_allow_all/policy_infrastructure_svn.rego | Bump API version and add rw_mount_device binding. |
| src/confcom/samples/aci/existing_policy/policy.rego | Bump API version and add rw_mount_device binding. |
| src/confcom/samples/aci/existing_policy/policy_debug.rego | Bump API version and add rw_mount_device binding. |
| src/confcom/samples/aci/existing_policy/policy_disable_stdio.rego | Bump API version and add rw_mount_device binding. |
| src/confcom/samples/aci/existing_policy/policy_exclude_default_fragment.rego | Bump API version and add rw_mount_device binding. |
| src/confcom/samples/aci/existing_policy/policy_fragment.rego | Bump API version and add rw_mount_device binding. |
| src/confcom/samples/aci/existing_policy/policy_fragment_plus_infrastructure_svn.rego | Bump API version and add rw_mount_device binding. |
| src/confcom/samples/aci/existing_policy/policy_infrastructure_svn.rego | Bump API version and add rw_mount_device binding. |
| src/confcom/samples/aci/environment_variables/policy.rego | Bump API version and add rw_mount_device binding. |
| src/confcom/samples/aci/environment_variables/policy_debug.rego | Bump API version and add rw_mount_device binding. |
| src/confcom/samples/aci/environment_variables/policy_disable_stdio.rego | Bump API version and add rw_mount_device binding. |
| src/confcom/samples/aci/environment_variables/policy_exclude_default_fragment.rego | Bump API version and add rw_mount_device binding. |
| src/confcom/samples/aci/environment_variables/policy_fragment.rego | Bump API version and add rw_mount_device binding. |
| src/confcom/samples/aci/environment_variables/policy_fragment_plus_infrastructure_svn.rego | Bump API version and add rw_mount_device binding. |
| src/confcom/samples/aci/environment_variables/policy_infrastructure_svn.rego | Bump API version and add rw_mount_device binding. |
| src/confcom/samples/aci/default_variables_override/policy.rego | Bump API version and add rw_mount_device binding. |
| src/confcom/samples/aci/default_variables_override/policy_debug.rego | Bump API version and add rw_mount_device binding. |
| src/confcom/samples/aci/default_variables_override/policy_disable_stdio.rego | Bump API version and add rw_mount_device binding. |
| src/confcom/samples/aci/default_variables_override/policy_exclude_default_fragment.rego | Bump API version and add rw_mount_device binding. |
| src/confcom/samples/aci/default_variables_override/policy_fragment.rego | Bump API version and add rw_mount_device binding. |
| src/confcom/samples/aci/default_variables_override/policy_fragment_plus_infrastructure_svn.rego | Bump API version and add rw_mount_device binding. |
| src/confcom/samples/aci/default_variables_override/policy_infrastructure_svn.rego | Bump API version and add rw_mount_device binding. |
| src/confcom/samples/aci/default_variables/policy.rego | Bump API version and add rw_mount_device binding. |
| src/confcom/samples/aci/default_variables/policy_debug.rego | Bump API version and add rw_mount_device binding. |
| src/confcom/samples/aci/default_variables/policy_disable_stdio.rego | Bump API version and add rw_mount_device binding. |
| src/confcom/samples/aci/default_variables/policy_exclude_default_fragment.rego | Bump API version and add rw_mount_device binding. |
| src/confcom/samples/aci/default_variables/policy_fragment.rego | Bump API version and add rw_mount_device binding. |
| src/confcom/samples/aci/default_variables/policy_fragment_plus_infrastructure_svn.rego | Bump API version and add rw_mount_device binding. |
| src/confcom/samples/aci/default_variables/policy_infrastructure_svn.rego | Bump API version and add rw_mount_device binding. |
| src/confcom/samples/aci/container_group_profiles/policy.rego | Bump API version and add rw_mount_device binding. |
| src/confcom/samples/aci/container_group_profiles/policy_debug.rego | Bump API version and add rw_mount_device binding. |
| src/confcom/samples/aci/container_group_profiles/policy_disable_stdio.rego | Bump API version and add rw_mount_device binding. |
| src/confcom/samples/aci/container_group_profiles/policy_exclude_default_fragment.rego | Bump API version and add rw_mount_device binding. |
| src/confcom/samples/aci/container_group_profiles/policy_fragment.rego | Bump API version and add rw_mount_device binding. |
| src/confcom/samples/aci/container_group_profiles/policy_fragment_plus_infrastructure_svn.rego | Bump API version and add rw_mount_device binding. |
| src/confcom/samples/aci/container_group_profiles/policy_infrastructure_svn.rego | Bump API version and add rw_mount_device binding. |
| src/confcom/samples/aci/conflicting_variables/policy.rego | Bump API version and add rw_mount_device binding. |
| src/confcom/samples/aci/conflicting_variables/policy_debug.rego | Bump API version and add rw_mount_device binding. |
| src/confcom/samples/aci/conflicting_variables/policy_disable_stdio.rego | Bump API version and add rw_mount_device binding. |
| src/confcom/samples/aci/conflicting_variables/policy_exclude_default_fragment.rego | Bump API version and add rw_mount_device binding. |
| src/confcom/samples/aci/conflicting_variables/policy_fragment.rego | Bump API version and add rw_mount_device binding. |
| src/confcom/samples/aci/conflicting_variables/policy_fragment_plus_infrastructure_svn.rego | Bump API version and add rw_mount_device binding. |
| src/confcom/samples/aci/conflicting_variables/policy_infrastructure_svn.rego | Bump API version and add rw_mount_device binding. |
| src/confcom/samples/aci/command/policy.rego | Bump API version and add rw_mount_device binding. |
| src/confcom/samples/aci/command/policy_debug.rego | Bump API version and add rw_mount_device binding. |
| src/confcom/samples/aci/command/policy_disable_stdio.rego | Bump API version and add rw_mount_device binding. |
| src/confcom/samples/aci/command/policy_exclude_default_fragment.rego | Bump API version and add rw_mount_device binding. |
| src/confcom/samples/aci/command/policy_fragment.rego | Bump API version and add rw_mount_device binding. |
| src/confcom/samples/aci/command/policy_fragment_plus_infrastructure_svn.rego | Bump API version and add rw_mount_device binding. |
| src/confcom/samples/aci/command/policy_infrastructure_svn.rego | Bump API version and add rw_mount_device binding. |
| src/confcom/samples/vn2/basic_command_args/policy.rego | Bump API version and add rw_mount_device binding. |
| src/confcom/samples/vn2/configmap_secret_env/policy.rego | Bump API version and add rw_mount_device binding. |
| src/confcom/samples/vn2/fieldref_env/policy.rego | Bump API version and add rw_mount_device binding. |
| src/confcom/samples/vn2/init_and_lifecycle/policy.rego | Bump API version and add rw_mount_device binding. |
| src/confcom/samples/vn2/multi_container/policy.rego | Bump API version and add rw_mount_device binding. |
| src/confcom/samples/vn2/privileged_container/policy.rego | Bump API version and add rw_mount_device binding. |
| src/confcom/samples/vn2/read_only_mounts/policy.rego | Bump API version and add rw_mount_device binding. |
| src/confcom/samples/vn2/resourcefieldref_env/policy.rego | Bump API version and add rw_mount_device binding. |
| src/confcom/samples/vn2/seccomp_profile/policy.rego | Bump API version and add rw_mount_device binding. |
| src/confcom/samples/vn2/security_context_merge/policy.rego | Bump API version and add rw_mount_device binding. |
| src/confcom/samples/vn2/signals/policy.rego | Bump API version and add rw_mount_device binding. |
| src/confcom/samples/vn2/special_env_regex/policy.rego | Bump API version and add rw_mount_device binding. |
| src/confcom/samples/vn2/volume_claim_templates/policy.rego | Bump API version and add rw_mount_device binding. |
| src/confcom/samples/vn2/workload_identity/policy.rego | Bump API version and add rw_mount_device binding. |
| pretty_print_func(self._allow_runtime_logging), | ||
| pretty_print_func(self._allow_environment_variable_dropping), | ||
| ) | ||
|
|
There was a problem hiding this comment.
_add_rego_boilerplate now has Linux/Windows branches but falls through without returning anything if _platform is neither (returns None). Even if the CLI currently restricts choices, it’s safer to explicitly raise ValueError/eprint+exit for unsupported platforms so callers don’t later fail with confusing TypeErrors.
Suggested change
| raise ValueError("Unsupported platform for rego boilerplate: {}".format(self._platform)) |
Member
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
MahatiC
force-pushed
the
latest-windows-support
branch
from
565ddf3 to
bd51664
Compare
Author
|
/azp run |
|
Commenter does not have sufficient privileges for PR 9783 in repo Azure/azure-cli-extensions |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.