{aks-preview} Migrate commands calling Compute module to aaz-based implementation#9793
{aks-preview} Migrate commands calling Compute module to aaz-based implementation#9793william051200 wants to merge 6 commits intoAzure:mainfrom
Conversation
william051200
requested review from
FumingZhang and
andyliuliming
as code owners
️✔️Azure CLI Extensions Breaking Change Test
|
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
microsoft-github-policy-service
bot
requested review from
yanzhudd,
yonzhan and
zhoxing-ms
CodeGen Tools Feedback CollectionThank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey |
|
There was a problem hiding this comment.
Pull request overview
Migrates aks-preview extension code paths that previously depended on azure.mgmt.compute to instead call compute operations via Azure CLI’s AAZ/operations implementations, and bumps the extension version accordingly.
Changes:
- Replace compute
runCommand, VMSS/VM list/show, and SKU listing calls with AAZ/CLI operation implementations. - Remove the now-unused
get_compute_clientfactory. - Bump extension version to
20.0.0b3and add release notes entry.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/aks-preview/setup.py | Bumps extension version to 20.0.0b3. |
| src/aks-preview/azext_aks_preview/custom.py | Migrates VM/VMSS-related operations (run-command, list/show) to AAZ/CLI ops and adjusts result parsing. |
| src/aks-preview/azext_aks_preview/azurecontainerstorage/_helpers.py | Switches VM SKU enumeration to AAZ-based SKU listing and adapts to dict-shaped results. |
| src/aks-preview/azext_aks_preview/_completers.py | Switches VM size completion data source to CLI operations and adapts to dict-shaped results. |
| src/aks-preview/azext_aks_preview/_client_factory.py | Removes get_compute_client factory after migration away from mgmt.compute. |
| src/aks-preview/HISTORY.rst | Adds 20.0.0b3 release notes entry. |
| +++++++ | ||
|
|
||
| 20.0.0b3 | ||
| +++++++ |
There was a problem hiding this comment.
The reStructuredText section underline for 20.0.0b3 is shorter than the heading text, which can break RST parsing/rendering. Update the underline length (or style) so it is at least as long as the version string, consistent with the other headings.
| +++++++ | |
| ++++++++ |
| cf_agent_pools, | ||
| get_compute_client, | ||
| ) | ||
| cf_agent_pools) |
There was a problem hiding this comment.
The multi-line import from _client_factory is now formatted with the closing parenthesis on the same line as the last imported name and without a trailing comma. This deviates from the surrounding import style in this file and makes future diffs noisier; please format it consistently with the other parenthesized imports.
| cf_agent_pools) | |
| cf_agent_pools, | |
| ) |
FumingZhang
left a comment
FumingZhang
left a comment
There was a problem hiding this comment.
Queued live test to validate the change.
- test_aks_check_network
- test_aks_kollect
- test_aks_kollect_with_managed_aad
- test_aks_create_with_azurecontainerstorage_v1
- test_aks_create_with_azurecontainerstorage_v1_with_ephemeral_disk_parameters
- test_aks_create_with_azurecontainerstorage_v1_with_nodepool_name
- test_aks_create_with_azurecontainerstorage
- test_aks_create_with_azurecontainerstorage_with_ephemeral_disk_parameters
- test_aks_create_with_azurecontainerstorage_with_elastic_san_parameters
- test_aks_create_with_azurecontainerstorage_with_multiple_parameters
- test_aks_update_with_azurecontainerstorage
- test_aks_update_with_azurecontainerstorage_with_ephemeral_disk
- test_aks_update_with_azurecontainerstorage_with_elastic_san
- test_aks_update_with_azurecontainerstorage_with_multiple_parameters
- test_aks_update_with_azurecontainerstorage_v1
- test_aks_update_with_azurecontainerstorage_v1_with_ephemeral_disk_parameters
Migration from mgmt.compute to aaz-based
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.