Skip to content

Quantum: fix e2e submit tests#9803

Merged
necusjz merged 5 commits intoAzure:mainfrom
rigidit:users/rigidit/fix-submit
Apr 21, 2026
Merged

Quantum: fix e2e submit tests#9803
necusjz merged 5 commits intoAzure:mainfrom
rigidit:users/rigidit/fix-submit

Conversation

@rigidit
Copy link
Copy Markdown
Contributor

@rigidit rigidit commented Apr 20, 2026

Description

This is tests change only, no changes to the actual extension:

  • Fixed test_submit e2e test
  • Updated test_submit_with_disabled_then_enabled_storage_key_access test to check for user delegation related params

This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copilot AI review requested due to automatic review settings April 20, 2026 22:53
@azure-client-tools-bot-prd
Copy link
Copy Markdown

azure-client-tools-bot-prd bot commented Apr 20, 2026

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

@azure-client-tools-bot-prd
Copy link
Copy Markdown

Hi @rigidit,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Copy Markdown
Collaborator

yonzhan commented Apr 20, 2026

Thank you for your contribution! We will review the pull request and get back to you soon.

@github-actions
Copy link
Copy Markdown
Contributor

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

@github-actions
Copy link
Copy Markdown
Contributor

@microsoft-github-policy-service microsoft-github-policy-service bot added the customer-reported Issues that are reported by GitHub users external to the Azure organization. label Apr 20, 2026
@microsoft-github-policy-service
Copy link
Copy Markdown
Contributor

Thank you for your contribution @rigidit! We will review the pull request and get back to you soon.

@microsoft-github-policy-service microsoft-github-policy-service bot added the Auto-Assign Auto assign by bot label Apr 20, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Quantum extension’s live e2e “submit” job tests to validate SAS URI behavior more accurately, including differentiating user delegation SAS vs service SAS when storage shared key access is toggled.

Changes:

  • Refactors SAS substring assertions into helper assertion methods for reuse.
  • Extends test_submit_with_disabled_then_enabled_storage_key_access to validate user delegation SAS parameters when shared key access is disabled, and absence of those parameters after re-enabling.
  • Adjusts wait timing between toggling shared key access and subsequent validation.

Comment thread src/quantum/azext_quantum/tests/latest/test_quantum_jobs.py Outdated
Comment thread src/quantum/azext_quantum/tests/latest/test_quantum_jobs.py Outdated
Comment thread src/quantum/azext_quantum/tests/latest/test_quantum_jobs.py Outdated
Comment thread src/quantum/azext_quantum/tests/latest/test_quantum_jobs.py
@yonzhan yonzhan requested a review from necusjz April 21, 2026 00:06
@rigidit
Copy link
Copy Markdown
Contributor Author

rigidit commented Apr 21, 2026

@necusjz could you please help to merge this changes related to only tests fixes? No extension release needed.

@necusjz necusjz merged commit 91ee5b4 into Azure:main Apr 21, 2026
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Auto-Assign Auto assign by bot customer-reported Issues that are reported by GitHub users external to the Azure organization.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants