Conversation
️✔️Azure CLI Extensions Breaking Change Test
|
|
Hi @rigidit, |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
|
|
Thank you for your contribution @rigidit! We will review the pull request and get back to you soon. |
There was a problem hiding this comment.
Pull request overview
This PR updates the Quantum extension’s live e2e “submit” job tests to validate SAS URI behavior more accurately, including differentiating user delegation SAS vs service SAS when storage shared key access is toggled.
Changes:
- Refactors SAS substring assertions into helper assertion methods for reuse.
- Extends
test_submit_with_disabled_then_enabled_storage_key_accessto validate user delegation SAS parameters when shared key access is disabled, and absence of those parameters after re-enabling. - Adjusts wait timing between toggling shared key access and subsequent validation.
|
@necusjz could you please help to merge this changes related to only tests fixes? No extension release needed. |
Description
This is tests change only, no changes to the actual extension:
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.