Skip to content

Quantum: fix e2e submit tests #9803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
necusjz merged 5 commits into from
Apr 21, 2026
+69 −30
Merged

Quantum: fix e2e submit tests #9803

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
543c8a3
Fix test submit test, update test for disabled and enabled storage ke…
rigidit Apr 20, 2026
d343bb4
Improve sas uri params checks
rigidit Apr 20, 2026
ef4f022
Remove duplicate -t cli param
rigidit Apr 20, 2026
2888ef0
Revert "Remove duplicate -t cli param"
rigidit Apr 20, 2026
dab52f6
Remove duplicate -t cli param
rigidit Apr 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
99 changes: 69 additions & 30 deletions src/quantum/azext_quantum/tests/latest/test_quantum_jobs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
import random
import time
import unittest
from urllib.parse import urlparse, parse_qs

from azure.cli.testsdk.scenario_tests import AllowLargeResponse, live_only
from azure.cli.testsdk import ScenarioTest
Expand Down Expand Up @@ -205,38 +206,19 @@ def test_submit(self):
self.cmd(f"az quantum workspace set -g {test_resource_group} -w {test_workspace_temp} -l {test_location}")

# Submit a job to Rigetti and look for SAS tokens in URIs in the output
results = self.cmd("az quantum job submit -t rigetti.sim.qvm --job-input-format rigetti.quil.v1 -t rigetti.sim.qvm --job-input-file src/quantum/azext_quantum/tests/latest/input_data/bell-state.quil --job-output-format rigetti.quil-results.v1 -o json").get_output_in_json()
self.assertNotIn("?sv=", results["containerUri"])
self.assertNotIn("&sig=", results["containerUri"])

self.assertNotIn("?sv=", results["inputDataUri"])
self.assertNotIn("&sig=", results["inputDataUri"])

self.assertNotIn("?sv=", results["outputDataUri"])
self.assertNotIn("&sig=", results["outputDataUri"])
results = self.cmd("az quantum job submit -t rigetti.sim.qvm --job-input-format rigetti.quil.v1 --job-input-file src/quantum/azext_quantum/tests/latest/input_data/bell-state.quil --job-output-format rigetti.quil-results.v1 -o json").get_output_in_json()
self.assert_not_contains_standard_sas_params(results["containerUri"])
self.assert_not_contains_standard_sas_params(results["inputDataUri"])
self.assert_not_contains_standard_sas_params(results["outputDataUri"])

job = self.cmd(f"az quantum job show -j {results['id']} -o json").get_output_in_json()

self.assertIn("?sv=", job["containerUri"])
self.assertIn("&st=", job["containerUri"])
self.assertIn("&se=", job["containerUri"])
self.assertIn("&sp=", job["containerUri"])
self.assertIn("&sig=", job["containerUri"])

self.assertIn("?sv=", job["inputDataUri"])
self.assertIn("&st=", job["inputDataUri"])
self.assertIn("&se=", job["inputDataUri"])
self.assertIn("&sp=", job["inputDataUri"])
self.assertIn("&sig=", job["inputDataUri"])

self.assertIn("?sv=", job["outputDataUri"])
self.assertIn("&st=", job["outputDataUri"])
self.assertIn("&se=", job["outputDataUri"])
self.assertIn("&sp=", job["outputDataUri"])
self.assertIn("&sig=", job["outputDataUri"])

self.assert_contains_standard_sas_params(job["containerUri"])
self.assert_contains_standard_sas_params(job["inputDataUri"])
self.assert_contains_standard_sas_params(job["outputDataUri"])

# Run a Quil pass-through job on Rigetti
results = self.cmd("az quantum run -t rigetti.sim.qvm --job-input-format rigetti.quil.v1 -t rigetti.sim.qvm --job-input-file src/quantum/azext_quantum/tests/latest/input_data/bell-state.quil --job-output-format rigetti.quil-results.v1 -o json").get_output_in_json()
results = self.cmd("az quantum run -t rigetti.sim.qvm --job-input-format rigetti.quil.v1 --job-input-file src/quantum/azext_quantum/tests/latest/input_data/bell-state.quil --job-output-format rigetti.quil-results.v1 -o json").get_output_in_json()
self.assertIn("ro", results)

# Run an IonQ Circuit pass-through job on IonQ
Expand Down Expand Up @@ -291,17 +273,34 @@ def test_submit_with_disabled_then_enabled_storage_key_access(self):
# Test that job submission works with disabled access keys on linked storage (/sasUri returns user delegation SAS)
results = self.cmd("az quantum job submit -t rigetti.sim.qvm --job-input-format rigetti.quil.v1 --job-input-file src/quantum/azext_quantum/tests/latest/input_data/bell-state.quil --job-output-format rigetti.quil-results.v1 -o json").get_output_in_json()
self.assertIn("id", results)


job = self.cmd(f"az quantum job show -j {results['id']} -o json").get_output_in_json()
self.assert_contains_standard_sas_params(job["containerUri"])
self.assert_contains_standard_sas_params(job["inputDataUri"])
self.assert_contains_standard_sas_params(job["outputDataUri"])
self.assert_contains_user_delegation_sas_params(job["containerUri"])
self.assert_contains_user_delegation_sas_params(job["inputDataUri"])
self.assert_contains_user_delegation_sas_params(job["outputDataUri"])

# Enable access keys on the storage account
updated = self.cmd(f"az storage account update -g {test_resource_group} -n {test_storage_temp} --allow-shared-key-access true -o json").get_output_in_json()
self.assertTrue(updated["allowSharedKeyAccess"], "Access keys should be enabled after update")

time.sleep(60) # wait for the cache to update
time.sleep(300) # wait for the cache to update
Comment thread
rigidit marked this conversation as resolved.

# Test that job submission works with enabled access keys on linked storage (/sasUri returns container-scoped Service SAS)
results = self.cmd("az quantum job submit -t rigetti.sim.qvm --job-input-format rigetti.quil.v1 --job-input-file src/quantum/azext_quantum/tests/latest/input_data/bell-state.quil --job-output-format rigetti.quil-results.v1 -o json").get_output_in_json()
self.assertIn("id", results)

job = self.cmd(f"az quantum job show -j {results['id']} -o json").get_output_in_json()
self.assert_contains_standard_sas_params(job["containerUri"])
self.assert_contains_standard_sas_params(job["inputDataUri"])
self.assert_contains_standard_sas_params(job["outputDataUri"])
self.assert_not_contains_user_delegation_sas_params(job["containerUri"])
self.assert_not_contains_user_delegation_sas_params(job["inputDataUri"])
self.assert_not_contains_user_delegation_sas_params(job["outputDataUri"])

# Clean up
self.cmd(f'az quantum workspace delete -g {test_resource_group} -w {test_workspace_temp}')
self.cmd(f'az storage account delete -g {test_resource_group} -n {test_storage_temp} --yes')

Expand Down Expand Up @@ -397,3 +396,43 @@ def test_job_list_param_formating(self):
assert False
except RequiredArgumentMissingError as e:
assert str(e) == ERROR_MSG_MISSING_ORDERBY_ARGUMENT

def assert_contains_user_delegation_sas_params(self, uri: str):
"""Assert that the given URI contains user delegation SAS parameters."""
params = parse_qs(urlparse(uri).query)
self.assertIn("skoid", params) # signed key object ID (service principal OID)
self.assertIn("sktid", params) # signed key tenant ID
self.assertIn("skt", params) # signed key start time
self.assertIn("ske", params) # signed key expiry time
self.assertIn("sks", params) # signed key service (b = Blob)
self.assertIn("skv", params) # signed key version

def assert_not_contains_user_delegation_sas_params(self, uri: str):
"""Assert that the given URI does not contain user delegation SAS parameters."""
params = parse_qs(urlparse(uri).query)
self.assertNotIn("skoid", params)
self.assertNotIn("sktid", params)
self.assertNotIn("skt", params)
self.assertNotIn("ske", params)
self.assertNotIn("sks", params)
self.assertNotIn("skv", params)

def assert_contains_standard_sas_params(self, uri: str):
"""Assert that the given URI contains standard SAS parameters."""
params = parse_qs(urlparse(uri).query)
self.assertIn("sv", params) # SAS version
self.assertIn("st", params) # start time
self.assertIn("se", params) # expiry time
self.assertIn("sr", params) # signed resource (e.g. c = container)
self.assertIn("sp", params) # permissions
self.assertIn("sig", params) # signature

def assert_not_contains_standard_sas_params(self, uri: str):
"""Assert that the given URI does not contain standard SAS parameters."""
params = parse_qs(urlparse(uri).query)
self.assertNotIn("sv", params)
self.assertNotIn("st", params)
self.assertNotIn("se", params)
self.assertNotIn("sr", params)
self.assertNotIn("sp", params)
self.assertNotIn("sig", params)
Loading