[Fileshare] 2026-06-01 api version GA#9904
Merged
Merged
Conversation
…ne through codegen not manually
|
Validation for Breaking Change Starting...
Thanks for your contribution! |
|
Hi @calvinhzy, |
Collaborator
|
Fileshare |
…--allowed-subnets` for `az fileshare create/update` test `--initiator-id` for `az fileshare snapshot create`
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the File Share CLI extension to the GA management-plane API version (2026-06-01), restructures the extension under the singular fileshare name, and refreshes generated AAZ command surfaces/tests accordingly.
Changes:
- Promote API usage from
2025-09-01-previewto2026-06-01across generated AAZ commands and recordings. - Rename/reshape the extension package from
fileshares→fileshare(setup metadata, imports, command loader). - Add/extend scenario tests and recordings for the new API surface (usage-show, limits-show, private-link-resource, snapshot, etc.).
Reviewed changes
Copilot reviewed 52 out of 64 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/fileshares/azext_fileshares/tests/latest/test_fileshares.py | Removes legacy scenario tests for the old fileshares extension. |
| src/fileshares/azext_fileshares/tests/latest/recordings/test_fileshares_limits_show.yaml | Removes legacy recording tied to the old preview API/version. |
| src/fileshares/azext_fileshares/commands.py | Removes legacy command table loader stub. |
| src/fileshares/azext_fileshares/aaz/latest/fileshare/snapshot/_wait.py | Removes legacy snapshot wait implementation from the old extension. |
| src/fileshares/azext_fileshares/aaz/latest/fileshare/private_endpoint_connection/_reject.py | Removes legacy reject implementation from the old extension. |
| src/fileshares/azext_fileshares/aaz/latest/fileshare/private_endpoint_connection/_approve.py | Removes legacy approve implementation from the old extension. |
| src/fileshares/azext_fileshares/_params.py | Removes legacy arg aliasing layer from the old extension. |
| src/fileshares/azext_fileshares/_help.py | Removes legacy help entries from the old extension. |
| src/fileshare/setup.py | Bumps extension to 1.0.0, renames wheel to fileshare, and updates packaging metadata. |
| src/fileshare/setup.cfg | Adds a placeholder setup.cfg file. |
| src/fileshare/README.md | Updates install command to the new extension name (fileshare). |
| src/fileshare/HISTORY.rst | Marks GA release and documents API version 2026-06-01. |
| src/fileshare/azext_fileshare/tests/latest/test_fileshare.py | Adds/updates scenario tests for CRUD, usage/limits, snapshots, private link resources, and private endpoint connections. |
| src/fileshare/azext_fileshare/tests/latest/recordings/test_fileshares_usage_show.yaml | Adds new recording for fileshare usage-show against 2026-06-01. |
| src/fileshare/azext_fileshare/tests/latest/recordings/test_fileshares_snapshot.yaml | Adds new recording for snapshot create/show/list/delete interactions on 2026-06-01. |
| src/fileshare/azext_fileshare/tests/latest/recordings/test_fileshares_private_link_resource.yaml | Adds new recording for private link resource list/show on 2026-06-01. |
| src/fileshare/azext_fileshare/tests/latest/recordings/test_fileshares_limits_show.yaml | Adds new recording for fileshare limits-show against 2026-06-01. |
| src/fileshare/azext_fileshare/tests/latest/recordings/test_fileshares_get_provisioning_recommendation.yaml | Updates recording to use 2026-06-01 and updated parameter casing. |
| src/fileshare/azext_fileshare/tests/latest/recordings/test_fileshares_check_name_availability.yaml | Updates recording to use 2026-06-01. |
| src/fileshare/azext_fileshare/tests/latest/init.py | Adds generated test package init. |
| src/fileshare/azext_fileshare/tests/init.py | Adds generated tests package init. |
| src/fileshare/azext_fileshare/custom.py | Adds custom overrides for check-name-availability, snapshot create LRO output handling, and approve/reject convenience commands. |
| src/fileshare/azext_fileshare/commands.py | Registers custom command classes for specific commands that need overrides. |
| src/fileshare/azext_fileshare/azext_metadata.json | Adds extension metadata (preview flag, min core version). |
| src/fileshare/azext_fileshare/aaz/latest/fileshare/snapshot/_update.py | Updates snapshot update command to 2026-06-01 and docstring adjustments. |
| src/fileshare/azext_fileshare/aaz/latest/fileshare/snapshot/_show.py | Updates snapshot show command to 2026-06-01 and docstring adjustments. |
| src/fileshare/azext_fileshare/aaz/latest/fileshare/snapshot/_list.py | Updates snapshot list command to 2026-06-01 and docstring adjustments. |
| src/fileshare/azext_fileshare/aaz/latest/fileshare/snapshot/_delete.py | Updates snapshot delete command to 2026-06-01 and docstring adjustments. |
| src/fileshare/azext_fileshare/aaz/latest/fileshare/snapshot/_create.py | Updates snapshot create command to 2026-06-01 and refactors LRO output handling (customized in custom.py). |
| src/fileshare/azext_fileshare/aaz/latest/fileshare/snapshot/init.py | Updates snapshot command exports. |
| src/fileshare/azext_fileshare/aaz/latest/fileshare/snapshot/__cmd_group.py | Minor docstring punctuation for snapshot command group. |
| src/fileshare/azext_fileshare/aaz/latest/fileshare/private_link_resource/_show.py | Updates private link resource show to 2026-06-01 and docstring examples. |
| src/fileshare/azext_fileshare/aaz/latest/fileshare/private_link_resource/_list.py | Updates private link resource list to 2026-06-01 and docstring examples. |
| src/fileshare/azext_fileshare/aaz/latest/fileshare/private_link_resource/init.py | Adds exports for private link resource commands. |
| src/fileshare/azext_fileshare/aaz/latest/fileshare/private_link_resource/__cmd_group.py | Introduces the private link resource command group. |
| src/fileshare/azext_fileshare/aaz/latest/fileshare/private_endpoint_connection/_wait.py | Updates private endpoint connection wait to 2026-06-01. |
| src/fileshare/azext_fileshare/aaz/latest/fileshare/private_endpoint_connection/_update.py | Updates private endpoint connection update to 2026-06-01 and docstring example. |
| src/fileshare/azext_fileshare/aaz/latest/fileshare/private_endpoint_connection/_show.py | Updates private endpoint connection show to 2026-06-01 and docstring example. |
| src/fileshare/azext_fileshare/aaz/latest/fileshare/private_endpoint_connection/_list.py | Updates private endpoint connection list to 2026-06-01 and docstring example. |
| src/fileshare/azext_fileshare/aaz/latest/fileshare/private_endpoint_connection/_delete.py | Updates private endpoint connection delete to 2026-06-01 and docstring example. |
| src/fileshare/azext_fileshare/aaz/latest/fileshare/private_endpoint_connection/_create.py | Updates private endpoint connection create to 2026-06-01 and registers the create command. |
| src/fileshare/azext_fileshare/aaz/latest/fileshare/private_endpoint_connection/init.py | Adds exports for private endpoint connection commands. |
| src/fileshare/azext_fileshare/aaz/latest/fileshare/private_endpoint_connection/__cmd_group.py | Introduces the private endpoint connection command group. |
| src/fileshare/azext_fileshare/aaz/latest/fileshare/_wait.py | Updates fileshare wait to 2026-06-01 and adds schema for encryptionInTransitRequired. |
| src/fileshare/azext_fileshare/aaz/latest/fileshare/_usage_show.py | Updates usage-show to 2026-06-01 and adds docstring example. |
| src/fileshare/azext_fileshare/aaz/latest/fileshare/_update.py | Updates fileshare update to 2026-06-01, refactors args for NFS/PublicAccess properties, and adds encryption-in-transit. |
| src/fileshare/azext_fileshare/aaz/latest/fileshare/_show.py | Updates fileshare show to 2026-06-01 and adds schema for encryptionInTransitRequired. |
| src/fileshare/azext_fileshare/aaz/latest/fileshare/_list.py | Updates fileshare list to 2026-06-01 and adds schema for encryptionInTransitRequired. |
| src/fileshare/azext_fileshare/aaz/latest/fileshare/_limits_show.py | Updates limits-show to 2026-06-01 and adds docstring example. |
| src/fileshare/azext_fileshare/aaz/latest/fileshare/_get_provisioning_recommendation.py | Updates get-provisioning-recommendation to 2026-06-01 and updates parameter casing in help text. |
| src/fileshare/azext_fileshare/aaz/latest/fileshare/_delete.py | Updates delete to 2026-06-01 and adds docstring example. |
| src/fileshare/azext_fileshare/aaz/latest/fileshare/_create.py | Updates create to 2026-06-01, refactors args for NFS/PublicAccess properties, and adds encryption-in-transit. |
| src/fileshare/azext_fileshare/aaz/latest/fileshare/_check_name_availability.py | Updates check-name-availability to 2026-06-01 and shifts type handling to custom.py. |
| src/fileshare/azext_fileshare/aaz/latest/fileshare/init.py | Adds exports for all fileshare commands. |
| src/fileshare/azext_fileshare/aaz/latest/fileshare/__cmd_group.py | Minor docstring punctuation for fileshare command group. |
| src/fileshare/azext_fileshare/aaz/latest/init.py | Adds generated aaz latest package init. |
| src/fileshare/azext_fileshare/aaz/init.py | Adds generated aaz package init. |
| src/fileshare/azext_fileshare/_params.py | Replaces previous argument aliasing with a stub load_arguments. |
| src/fileshare/azext_fileshare/_help.py | Adds help entries for approve/reject convenience commands. |
| src/fileshare/azext_fileshare/init.py | Updates loader wiring for the renamed extension and loads AAZ commands + custom overrides. |
Comments suppressed due to low confidence (8)
src/fileshare/azext_fileshare/aaz/latest/fileshare/_check_name_availability.py:65
--nameis no longer marked as required, sofileshare check-name-availabilitycan be invoked without a name and will send an invalid request body. Make--namerequired again to fail fast with a clear CLI error.
src/fileshare/azext_fileshare/aaz/latest/fileshare/_create.py:97- This change drops the previously supported flag alias
--provisioned-storage-GiB. Azure CLI option names are case-sensitive, so this is a breaking change for existing scripts. Keep the old alias for backward compatibility.
src/fileshare/azext_fileshare/aaz/latest/fileshare/_update.py:95 - This change drops the previously supported flag aliases
--provisioned-storage-GiB/--provisioned-throughput-MiB. Azure CLI option names are case-sensitive, so this is a breaking change for existing scripts. Keep the old aliases for backward compatibility.
src/fileshare/azext_fileshare/aaz/latest/fileshare/_get_provisioning_recommendation.py:53 - This change drops the previously supported flag alias
--provisioned-storage-GiB. Azure CLI option names are case-sensitive, so this is a breaking change for existing scripts. Keep the old alias for backward compatibility.
src/fileshare/azext_fileshare/aaz/latest/fileshare/_check_name_availability.py:65 --nameis no longer marked as required, sofileshare check-name-availabilitycan be invoked without a name and will send an invalid request body. Make--namerequired again to fail fast with a clear CLI error.
src/fileshare/azext_fileshare/aaz/latest/fileshare/_create.py:97- This change drops the previously supported flag alias
--provisioned-storage-GiB. Azure CLI option names are case-sensitive, so this is a breaking change for existing scripts. Keep the old alias for backward compatibility.
src/fileshare/azext_fileshare/aaz/latest/fileshare/_update.py:95 - This change drops the previously supported flag aliases
--provisioned-storage-GiB/--provisioned-throughput-MiB. Azure CLI option names are case-sensitive, so this is a breaking change for existing scripts. Keep the old aliases for backward compatibility.
src/fileshare/azext_fileshare/aaz/latest/fileshare/_get_provisioning_recommendation.py:53 - This change drops the previously supported flag alias
--provisioned-storage-GiB. Azure CLI option names are case-sensitive, so this is a breaking change for existing scripts. Keep the old alias for backward compatibility.
necusjz
approved these changes
Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
aaz: Azure/aaz#1019
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.