Skip to content

Commit 0918dd5

Browse files
committed
add _braking_change.py
1 parent e90faad commit 0918dd5

2 files changed

Lines changed: 19 additions & 30 deletions

File tree

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,19 @@
1+
# --------------------------------------------------------------------------------------------
2+
# Copyright (c) Microsoft Corporation. All rights reserved.
3+
# Licensed under the MIT License. See License.txt in the project root for license information.
4+
# --------------------------------------------------------------------------------------------
5+
from azure.cli.core.breaking_change import register_required_flag_breaking_change, register_default_value_breaking_change, register_other_breaking_change, register_argument_deprecate
6+
7+
register_argument_deprecate('netappfiles volume create', '--is-restoring', target_version='2.73.0')
8+
register_argument_deprecate('netappfiles volume update', '--avs-data-store', target_version='2.73.0')
9+
register_argument_deprecate('netappfiles volume update', '--creation-token', target_version='2.73.0')
10+
register_argument_deprecate('netappfiles volume update', '--is-large-volume', target_version='2.73.0')
11+
register_argument_deprecate('netappfiles volume update', '--is-restoring', target_version='2.73.0')
12+
register_argument_deprecate('netappfiles volume update', '--ldap-enabled', target_version='2.73.0')
13+
register_argument_deprecate('netappfiles volume update', '--network-features', target_version='2.73.0')
14+
register_argument_deprecate('netappfiles volume update', '--security-style', target_version='2.73.0')
15+
register_argument_deprecate('netappfiles volume update', '--volume-type', target_version='2.73.0')
16+
17+
# register_required_flag_breaking_change('bar foo', '--name')
18+
# register_default_value_breaking_change('bar foo baz', '--foobar', 'A', 'B', target_version='May 2025')
19+
# register_other_breaking_change('bar foo baz', 'During May 2024, another Breaking Change would happen in Build Event.')

src/azure-cli/azure/cli/command_modules/netappfiles/custom.py

Lines changed: 0 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -404,10 +404,6 @@ def pre_operations(self):
404404
else:
405405
logger.debug("ANF log: Don't create export policy")
406406

407-
if has_value(args.is_restoring):
408-
logger.warning("ANF log: is_restoring is deprecated, do not use it. It will be removed in future version.")
409-
args.is_restoring = None
410-
411407

412408
# check if flattening dataprotection works
413409
class VolumeUpdate(_VolumeUpdate):
@@ -492,32 +488,6 @@ def pre_operations(self):
492488
if has_value(args.usage_threshold) and args.usage_threshold.to_serialized_data() is not None:
493489
args.usage_threshold = int(args.usage_threshold.to_serialized_data()) * gib_scale
494490

495-
# For backwards compat, in next breaking change window, those will be removed
496-
if has_value(args.avs_data_store):
497-
logger.warning("ANF log: avs_data_store is deprecated, do not use it. It will be removed in future version.")
498-
args.avs_data_store = None
499-
if has_value(args.creation_token):
500-
logger.warning("ANF log: creation_token is deprecated, do not use it. It will be removed in future version.")
501-
args.creation_token = None
502-
if has_value(args.is_large_volume):
503-
logger.warning("ANF log: is_large_volume is deprecated, do not use it. It will be removed in future version.")
504-
args.is_large_volume = None
505-
if has_value(args.is_restoring):
506-
logger.warning("ANF log: is_restoring is deprecated, do not use it. It will be removed in future version.")
507-
args.is_restoring = None
508-
if has_value(args.ldap_enabled):
509-
logger.warning("ANF log: ldap_enabled is deprecated, do not use it. It will be removed in future version.")
510-
args.ldap_enabled = None
511-
if has_value(args.network_features):
512-
logger.warning("ANF log: network_features is deprecated, do not use it. It will be removed in future version.")
513-
args.network_features = None
514-
if has_value(args.security_style):
515-
logger.warning("ANF log: security_style is deprecated, do not use it. It will be removed in future version.")
516-
args.security_style = None
517-
if has_value(args.volume_type):
518-
logger.warning("ANF log: volume_type is deprecated, do not use it. It will be removed in future version.")
519-
args.volume_type = None
520-
521491

522492
class VolumeBreakFileLocks(_BreakFileLocks):
523493
@classmethod

0 commit comments

Comments
 (0)