use get_by_id

Author: zanejohnson-azure

src/azure-cli/azure/cli/command_modules/acs/addonconfiguration.py

@@ -738,26 +738,21 @@ def is_ampls_scoped_exist(cmd, ampls_resource_id, scoped_resource_id):
         # Get the resources client (same as used elsewhere in this file)
         resources = get_resources_client(cmd.cli_ctx, subscription_id)
 
-        # Use the resources client to list scoped resources
-        # This is the proper SDK way to make the API call
-        scoped_resources_list_id = f"{ampls_resource_id}/scopedResources"
-        
         try:
-            # Use the resources client's list method
-            scoped_resources = resources.list_by_id(scoped_resources_list_id, "2019-10-17-preview")
+            # Use resources.get_by_id() to get the AMPLS resource with scoped resources
+            ampls_resource = resources.get_by_id(ampls_resource_id, "2019-10-17-preview")
 
-            # Iterate through the scoped resources
-            for scoped_resource in scoped_resources:
-                if hasattr(scoped_resource, 'properties') and hasattr(scoped_resource.properties, 'linked_resource_id'):
-                    linked_resource_id = scoped_resource.properties.linked_resource_id
-                    scoped_resource_name = getattr(scoped_resource, 'name', 'unknown')
-                    
+            # Check if the AMPLS has any scoped resources property
+            if hasattr(ampls_resource, 'properties') and hasattr(ampls_resource.properties, 'scoped_resources'):
+                scoped_resources = ampls_resource.properties.scoped_resources
+                
+                for scoped_resource in scoped_resources:
+                    linked_resource_id = scoped_resource.get('linkedResourceId', '')
                     print(f"DEBUG: Found linked resource: {linked_resource_id}")
 
-                    # Compare case-insensitively since Azure resource IDs can have case variations
                     if linked_resource_id.lower() == scoped_resource_id.lower():
                         print(f"DEBUG: MATCH FOUND!")
-                        logger.info("Resource already scoped in AMPLS. Scoped resource name: %s, LinkedResourceId: %s", scoped_resource_name, linked_resource_id)
+                        logger.info("Resource already scoped in AMPLS. LinkedResourceId: %s", linked_resource_id)
                         return True
 
         except HttpResponseError as e: