Skip to content

Commit 110f7b4

Browse files
authored
{Pylint} Fix consider-using-from-import (#20236)
1 parent 1d9fcb5 commit 110f7b4

22 files changed

Lines changed: 28 additions & 29 deletions

File tree

pylintrc

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,6 @@ disable=
3737
wrong-import-order,
3838
consider-using-f-string,
3939
unspecified-encoding,
40-
consider-using-from-import,
4140
use-maxsplit-arg,
4241
arguments-renamed,
4342
consider-using-in,

src/azure-cli-core/azure/cli/core/__init__.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,7 @@ def refresh_request_id(self):
107107
self.data['headers']['x-ms-client-request-id'] = str(uuid.uuid1())
108108

109109
def get_progress_controller(self, det=False, spinner=None):
110-
import azure.cli.core.commands.progress as progress
110+
from azure.cli.core.commands import progress
111111
if not self.progress_controller:
112112
self.progress_controller = progress.ProgressHook()
113113

@@ -279,7 +279,7 @@ def _update_command_table_from_modules(args, command_modules=None):
279279
except Exception as ex: # pylint: disable=broad-except
280280
# Changing this error message requires updating CI script that checks for failed
281281
# module loading.
282-
import azure.cli.core.telemetry as telemetry
282+
from azure.cli.core import telemetry
283283
logger.error("Error loading command module '%s': %s", mod, ex)
284284
telemetry.set_exception(exception=ex, fault_type='module-load-error-' + mod,
285285
summary='Error loading module: {}'.format(mod))

src/azure-cli-core/azure/cli/core/azclierror.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55

66
import sys
77

8-
import azure.cli.core.telemetry as telemetry
8+
from azure.cli.core import telemetry
99
from knack.util import CLIError
1010
from knack.log import get_logger
1111

src/azure-cli-core/azure/cli/core/command_recommender.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55

66
from enum import Enum
77

8-
import azure.cli.core.telemetry as telemetry
8+
from azure.cli.core import telemetry
99
from knack.log import get_logger
1010

1111

src/azure-cli-core/azure/cli/core/commands/__init__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@
2626
from azure.cli.core.util import (
2727
get_command_type_kwarg, read_file_content, get_arg_list, poller_classes)
2828
from azure.cli.core.local_context import LocalContextAction
29-
import azure.cli.core.telemetry as telemetry
29+
from azure.cli.core import telemetry
3030
from azure.cli.core.commands.progress import IndeterminateProgressBar
3131

3232
from knack.arguments import CLICommandArgument

src/azure-cli-core/azure/cli/core/commands/arm.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -115,7 +115,7 @@ def handle_template_based_exception(ex):
115115

116116

117117
def handle_long_running_operation_exception(ex):
118-
import azure.cli.core.telemetry as telemetry
118+
from azure.cli.core import telemetry
119119

120120
telemetry.set_exception(
121121
ex,

src/azure-cli-core/azure/cli/core/commands/client_factory.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
# Licensed under the MIT License. See License.txt in the project root for license information.
44
# --------------------------------------------------------------------------------------------
55

6-
import azure.cli.core._debug as _debug
6+
from azure.cli.core import _debug
77
from azure.cli.core.auth.util import resource_to_scopes
88
from azure.cli.core.extension import EXTENSIONS_MOD_PREFIX
99
from azure.cli.core.profiles import ResourceType, CustomResourceType, get_api_version, get_sdk

src/azure-cli-core/azure/cli/core/commands/transform.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77

88
from azure.cli.core.util import b64_to_hex
99

10-
import knack.events as events
10+
from knack import events
1111

1212

1313
def register_global_transforms(cli_ctx):

src/azure-cli-core/azure/cli/core/extension/dynamic_install.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
# Licensed under the MIT License. See License.txt in the project root for license information.
44
# --------------------------------------------------------------------------------------------
55

6-
import azure.cli.core.telemetry as telemetry
6+
from azure.cli.core import telemetry
77
from azure.cli.core.commands import AzCliCommandInvoker
88
from azure.cli.core.azclierror import CommandNotFoundError
99
from knack.log import get_logger

src/azure-cli-core/azure/cli/core/parser.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
import argparse
99
import argcomplete
1010

11-
import azure.cli.core.telemetry as telemetry
11+
from azure.cli.core import telemetry
1212
from azure.cli.core.extension import get_extension
1313
from azure.cli.core.commands import ExtensionCommandSource
1414
from azure.cli.core.commands import AzCliCommandInvoker

0 commit comments

Comments
 (0)