pylint

Author: jiasli

src/azure-cli-core/azure/cli/core/_profile.py

@@ -206,7 +206,6 @@ def login_with_managed_identity(self, identity_id=None, allow_no_subscriptions=N
             else:
                 authenticated = False
                 # Use trial and error approach to determine the ID type - client ID or object ID
-                from azure.cli.core.azclierror import AuthenticationError
                 try:
                     cred = ManagedIdentityCredential(client_id=identity_id)
                     cred.get_token(*self._arm_scope)
@@ -714,7 +713,7 @@ def get_installation_id(self):
         return installation_id
 
 
-class ManagedIdentityAuth:
+class ManagedIdentityAuth:  # pylint: disable=too-few-public-methods
 
     # String constants defined in this class are saved to azureProfile.json, so this class shouldn't be put
     # under auth/identity.py

src/azure-cli-core/azure/cli/core/auth/msal_authentication.py

@@ -157,25 +157,24 @@ def get_token(self, *scopes, **kwargs):
         return build_sdk_access_token(result)
 
 
-class CloudShellCredential:
+class CloudShellCredential:  # pylint: disable=too-few-public-methods
 
-    def get_token(self, *scopes, **kwargs):
-        logger.debug("CloudShellCredential.get_token: scopes=%r, kwargs=%r", scopes, kwargs)
-
-        import msal
-        from .util import check_result, build_sdk_access_token
+    def __init__(self):
         from .identity import AZURE_CLI_CLIENT_ID
-        app = msal.PublicClientApplication(
+        self.msal_app = PublicClientApplication(
             AZURE_CLI_CLIENT_ID,  # Use a real client_id, so that cache would work
             # TODO: This PoC does not currently maintain a token cache;
             #   Ideally we should reuse the real MSAL app object which has cache configured.
             # token_cache=...,
         )
+
+    def get_token(self, *scopes, **kwargs):  # pylint: disable=no-self-use
+        logger.debug("CloudShellCredential.get_token: scopes=%r, kwargs=%r", scopes, kwargs)
         if 'data' in kwargs:
             # Get a VM SSH certificate
-            result = app.acquire_token_interactive(list(scopes), prompt="none", data=kwargs["data"])
+            result = self.msal_app.acquire_token_interactive(list(scopes), prompt="none", data=kwargs["data"])
         else:
             # Get an access token
-            result = app.acquire_token_interactive(list(scopes), prompt="none")
+            result = self.msal_app.acquire_token_interactive(list(scopes), prompt="none")
         check_result(result, scopes=scopes)
         return build_sdk_access_token(result)