Skip to content

Commit 1ad62b0

Browse files
{ARM} Pick up new azure-mgmt-resource packages
1 parent fd4a6cd commit 1ad62b0

60 files changed

Lines changed: 16072 additions & 15685 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.
545 KB
Binary file not shown.

src/azure-cli-core/azure/cli/core/profiles/_shared.py

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -58,6 +58,7 @@ class ResourceType(Enum): # pylint: disable=too-few-public-methods
5858
MGMT_RESOURCE_POLICY = ('azure.mgmt.resource.policy', 'PolicyClient')
5959
MGMT_RESOURCE_RESOURCES = ('azure.mgmt.resource.resources', 'ResourceManagementClient')
6060
MGMT_RESOURCE_SUBSCRIPTIONS = ('azure.mgmt.resource.subscriptions', 'SubscriptionClient')
61+
MGMT_RESOURCE_DEPLOYMENTS = ('azure.mgmt.resource.deployments', 'DeploymentsMgmtClient')
6162
MGMT_RESOURCE_DEPLOYMENTSCRIPTS = ('azure.mgmt.resource.deploymentscripts', 'DeploymentScriptsClient')
6263
MGMT_RESOURCE_TEMPLATESPECS = ('azure.mgmt.resource.templatespecs', 'TemplateSpecsClient')
6364
MGMT_RESOURCE_DEPLOYMENTSTACKS = ('azure.mgmt.resource.deploymentstacks', 'DeploymentStacksClient')
@@ -179,9 +180,10 @@ def default_api_version(self):
179180
}),
180181
ResourceType.MGMT_RESOURCE_RESOURCES: '2024-11-01',
181182
ResourceType.MGMT_RESOURCE_SUBSCRIPTIONS: '2022-12-01',
182-
ResourceType.MGMT_RESOURCE_DEPLOYMENTSCRIPTS: '2020-10-01',
183-
ResourceType.MGMT_RESOURCE_TEMPLATESPECS: '2021-05-01',
184-
ResourceType.MGMT_RESOURCE_DEPLOYMENTSTACKS: '2024-03-01',
183+
ResourceType.MGMT_RESOURCE_DEPLOYMENTS: None,
184+
ResourceType.MGMT_RESOURCE_DEPLOYMENTSCRIPTS: None,
185+
ResourceType.MGMT_RESOURCE_TEMPLATESPECS: None,
186+
ResourceType.MGMT_RESOURCE_DEPLOYMENTSTACKS: None,
185187
ResourceType.MGMT_RESOURCE_PRIVATELINKS: '2020-05-01',
186188
ResourceType.MGMT_RESOURCE_MANAGEDAPPLICATIONS: '2019-07-01',
187189
ResourceType.MGMT_NETWORK_DNS: '2018-05-01',

src/azure-cli/azure/cli/command_modules/appservice/appservice_environment.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,8 @@
99
from azure.mgmt.privatedns import PrivateDnsManagementClient
1010

1111
# Models
12-
from azure.mgmt.resource.resources.models import (DeploymentProperties, Deployment, SubResource)
12+
from azure.mgmt.resource.deployments.models import (DeploymentProperties, Deployment)
13+
from azure.mgmt.resource.resources.models import SubResource
1314
from azure.mgmt.privatedns.models import (PrivateZone, VirtualNetworkLink, RecordSet, ARecord)
1415

1516
# Utils

src/azure-cli/azure/cli/command_modules/resource/_client_factory.py

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,12 @@ def _resource_links_client_factory(cli_ctx, **_):
3434
return get_mgmt_service_client(cli_ctx, ResourceType.MGMT_RESOURCE_LINKS)
3535

3636

37+
def _resource_deployments_client_factory(cli_ctx, **_):
38+
from azure.cli.core.commands.client_factory import get_mgmt_service_client
39+
from azure.cli.core.profiles import ResourceType
40+
return get_mgmt_service_client(cli_ctx, ResourceType.MGMT_RESOURCE_DEPLOYMENTS)
41+
42+
3743
def _resource_deploymentscripts_client_factory(cli_ctx, **_):
3844
from azure.cli.core.commands.client_factory import get_mgmt_service_client
3945
from azure.cli.core.profiles import ResourceType
@@ -93,11 +99,11 @@ def cf_tags(cli_ctx, _):
9399

94100

95101
def cf_deployments(cli_ctx, _):
96-
return _resource_client_factory(cli_ctx).deployments
102+
return _resource_deployments_client_factory(cli_ctx).deployments
97103

98104

99105
def cf_deployment_operations(cli_ctx, _):
100-
return _resource_client_factory(cli_ctx).deployment_operations
106+
return _resource_deployments_client_factory(cli_ctx).deployment_operations
101107

102108

103109
def cf_features(cli_ctx, _):

src/azure-cli/azure/cli/command_modules/resource/_formatters.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55

66
from itertools import groupby
77

8-
from azure.mgmt.resource.resources.models import ChangeType, PropertyChangeType, Level
8+
from azure.mgmt.resource.deployments.models import ChangeType, PropertyChangeType, Level
99

1010
from ._symbol import Symbol
1111
from ._color import Color, ColoredStringBuilder

src/azure-cli/azure/cli/command_modules/resource/_utils.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55

66
import re
77
import json
8+
from azure.core.exceptions import HttpResponseError
89

910
_management_group_pattern = (
1011
r"^\/?providers\/Microsoft.Management\/managementGroups\/(?P<management_group_id>[\w\d_\.\(\)-]+)"
@@ -87,9 +88,10 @@ def _build_preflight_error_message(preflight_error):
8788

8889

8990
def _build_http_response_error_message(http_error):
90-
error_txt = http_error.response.internal_response.text
91+
if not isinstance(http_error, HttpResponseError):
92+
raise TypeError("http_error must be an instance of HttpResponseError")
9193

92-
error_info = json.loads(error_txt)['error']
94+
error_info = http_error.response.json()['error']
9395
error_details = error_info.pop('details') if 'details' in error_info else []
9496
err_messages = [f'{json.dumps(error_info)}']
9597

src/azure-cli/azure/cli/command_modules/resource/commands.py

Lines changed: 22 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -158,15 +158,15 @@ def load_command_table(self, _):
158158
)
159159

160160
resource_deployment_sdk = CliCommandType(
161-
operations_tmpl='azure.mgmt.resource.resources.operations#DeploymentsOperations.{}',
161+
operations_tmpl='azure.mgmt.resource.deployments.operations#DeploymentsOperations.{}',
162162
client_factory=cf_deployments,
163-
resource_type=ResourceType.MGMT_RESOURCE_RESOURCES
163+
resource_type=ResourceType.MGMT_RESOURCE_DEPLOYMENTS
164164
)
165165

166166
resource_deployment_operation_sdk = CliCommandType(
167-
operations_tmpl='azure.mgmt.resource.resources.operations#DeploymentOperationsOperations.{}',
167+
operations_tmpl='azure.mgmt.resource.deployments.operations#DeploymentOperationsOperations.{}',
168168
client_factory=cf_deployment_operations,
169-
resource_type=ResourceType.MGMT_RESOURCE_RESOURCES
169+
resource_type=ResourceType.MGMT_RESOURCE_DEPLOYMENTS
170170
)
171171

172172
resource_policy_definitions_sdk = CliCommandType(
@@ -333,24 +333,23 @@ def load_command_table(self, _):
333333
g.command('remove-value', 'delete_value')
334334

335335
# az group deployment
336-
with self.command_group('group deployment', resource_deployment_sdk, deprecate_info=self.deprecate(redirect='deployment group', hide=True)) as g:
336+
with self.command_group('group deployment', resource_deployment_sdk, resource_type=ResourceType.MGMT_RESOURCE_DEPLOYMENTS, deprecate_info=self.deprecate(redirect='deployment group', hide=True)) as g:
337337
g.custom_command('create', 'deploy_arm_template', supports_no_wait=True, validator=process_deployment_create_namespace,
338338
table_transformer=transform_deployment, exception_handler=handle_template_based_exception)
339-
g.command('list', 'list_by_resource_group', table_transformer=transform_deployments_list, min_api='2017-05-10')
340-
g.command('list', 'list', table_transformer=transform_deployments_list, max_api='2016-09-01')
339+
g.command('list', 'list_by_resource_group', table_transformer=transform_deployments_list)
341340
g.show_command('show', 'get', table_transformer=transform_deployment)
342341
g.command('delete', 'begin_delete', supports_no_wait=True)
343342
g.custom_command('validate', 'validate_arm_template', table_transformer=deployment_validate_table_format, exception_handler=handle_template_based_exception)
344343
g.custom_command('export', 'export_deployment_as_template')
345344
g.wait_command('wait')
346345
g.command('cancel', 'cancel')
347346

348-
with self.command_group('group deployment operation', resource_deployment_operation_sdk, deprecate_info=self.deprecate(redirect='deployment operation group', hide=True)) as g:
347+
with self.command_group('group deployment operation', resource_deployment_operation_sdk, resource_type=ResourceType.MGMT_RESOURCE_DEPLOYMENTS, deprecate_info=self.deprecate(redirect='deployment operation group', hide=True)) as g:
349348
g.command('list', 'list')
350349
g.custom_show_command('show', 'get_deployment_operations', client_factory=cf_deployment_operations)
351350

352351
# az deployment
353-
with self.command_group('deployment', resource_deployment_sdk, min_api='2018-05-01', resource_type=ResourceType.MGMT_RESOURCE_RESOURCES) as g:
352+
with self.command_group('deployment', resource_deployment_sdk, resource_type=ResourceType.MGMT_RESOURCE_DEPLOYMENTS) as g:
354353
g.custom_command('list', 'list_deployments_at_subscription_scope', table_transformer=transform_deployments_list, deprecate_info=g.deprecate(redirect='deployment sub list', hide=True))
355354
g.custom_show_command('show', 'get_deployment_at_subscription_scope', deprecate_info=g.deprecate(redirect='deployment sub show', hide=True))
356355
g.custom_command('delete', 'delete_deployment_at_subscription_scope', supports_no_wait=True, deprecate_info=g.deprecate(redirect='deployment sub delete', hide=True))
@@ -363,14 +362,14 @@ def load_command_table(self, _):
363362
g.custom_wait_command('wait', 'get_deployment_at_subscription_scope', deprecate_info=g.deprecate(redirect='deployment sub wait', hide=True))
364363
g.custom_command('cancel', 'cancel_deployment_at_subscription_scope', deprecate_info=g.deprecate(redirect='deployment sub cancel', hide=True))
365364

366-
with self.command_group('deployment operation', resource_deployment_operation_sdk, min_api='2018-05-01', resource_type=ResourceType.MGMT_RESOURCE_RESOURCES) as g:
365+
with self.command_group('deployment operation', resource_deployment_operation_sdk, resource_type=ResourceType.MGMT_RESOURCE_DEPLOYMENTS) as g:
367366
g.custom_command('list', 'list_deployment_operations_at_subscription_scope',
368367
deprecate_info=self.deprecate(redirect='deployment operation sub list', hide=True))
369368
g.custom_show_command('show', 'get_deployment_operations_at_subscription_scope', client_factory=cf_deployment_operations,
370369
deprecate_info=self.deprecate(redirect='deployment operation sub show', hide=True))
371370

372371
# az deployment sub
373-
with self.command_group('deployment sub', resource_deployment_sdk, min_api='2018-05-01', resource_type=ResourceType.MGMT_RESOURCE_RESOURCES) as g:
372+
with self.command_group('deployment sub', resource_deployment_sdk, resource_type=ResourceType.MGMT_RESOURCE_DEPLOYMENTS) as g:
374373
g.custom_command('list', 'list_deployments_at_subscription_scope', table_transformer=transform_deployments_list)
375374
g.custom_show_command('show', 'get_deployment_at_subscription_scope', table_transformer=transform_deployment)
376375
g.custom_command('delete', 'delete_deployment_at_subscription_scope', supports_no_wait=True)
@@ -379,12 +378,12 @@ def load_command_table(self, _):
379378
g.custom_command('create', 'deploy_arm_template_at_subscription_scope', supports_no_wait=True, validator=process_deployment_create_namespace,
380379
table_transformer=transform_deployment, exception_handler=handle_template_based_exception)
381380
g.custom_command('what-if', 'what_if_deploy_arm_template_at_subscription_scope', validator=process_deployment_create_namespace,
382-
exception_handler=handle_template_based_exception, min_api='2019-07-01')
381+
exception_handler=handle_template_based_exception)
383382
g.custom_command('export', 'export_template_at_subscription_scope')
384383
g.custom_wait_command('wait', 'get_deployment_at_subscription_scope')
385384
g.custom_command('cancel', 'cancel_deployment_at_subscription_scope')
386385

387-
with self.command_group('deployment operation sub', resource_deployment_operation_sdk, min_api='2018-05-01', resource_type=ResourceType.MGMT_RESOURCE_RESOURCES) as g:
386+
with self.command_group('deployment operation sub', resource_deployment_operation_sdk, resource_type=ResourceType.MGMT_RESOURCE_DEPLOYMENTS) as g:
388387
g.custom_command('list', 'list_deployment_operations_at_subscription_scope')
389388
g.custom_show_command('show', 'get_deployment_operations_at_subscription_scope', client_factory=cf_deployment_operations)
390389

@@ -394,7 +393,7 @@ def load_command_table(self, _):
394393
g.custom_command('show-log', 'get_deployment_script_logs')
395394
g.custom_command('delete', 'delete_deployment_script', confirmation=True)
396395

397-
with self.command_group('ts', resource_templatespecs_sdk, resource_type=ResourceType.MGMT_RESOURCE_TEMPLATESPECS, min_api='2019-06-01-preview') as g:
396+
with self.command_group('ts', resource_templatespecs_sdk, resource_type=ResourceType.MGMT_RESOURCE_TEMPLATESPECS) as g:
398397
g.custom_command('create', 'create_template_spec', validator=process_ts_create_or_update_namespace)
399398
g.custom_command('update', 'update_template_spec', validator=process_ts_create_or_update_namespace, confirmation=True)
400399
g.custom_command('export', 'export_template_spec', validator=_validate_template_spec_out)
@@ -441,7 +440,7 @@ def load_command_table(self, _):
441440
exception_handler=handle_template_based_exception)
442441

443442
# az deployment group
444-
with self.command_group('deployment group', resource_deployment_sdk, resource_type=ResourceType.MGMT_RESOURCE_RESOURCES) as g:
443+
with self.command_group('deployment group', resource_deployment_sdk, resource_type=ResourceType.MGMT_RESOURCE_DEPLOYMENTS) as g:
445444
g.custom_command('list', 'list_deployments_at_resource_group', table_transformer=transform_deployments_list)
446445
g.custom_show_command('show', 'get_deployment_at_resource_group', table_transformer=transform_deployment)
447446
g.custom_command('delete', 'delete_deployment_at_resource_group', supports_no_wait=True)
@@ -450,17 +449,17 @@ def load_command_table(self, _):
450449
g.custom_command('create', 'deploy_arm_template_at_resource_group', supports_no_wait=True, validator=process_deployment_create_namespace,
451450
table_transformer=transform_deployment, exception_handler=handle_template_based_exception)
452451
g.custom_command('what-if', 'what_if_deploy_arm_template_at_resource_group', validator=process_deployment_create_namespace,
453-
exception_handler=handle_template_based_exception, min_api='2019-07-01')
452+
exception_handler=handle_template_based_exception)
454453
g.custom_command('export', 'export_template_at_resource_group')
455454
g.custom_wait_command('wait', 'get_deployment_at_resource_group')
456455
g.custom_command('cancel', 'cancel_deployment_at_resource_group')
457456

458-
with self.command_group('deployment operation group', resource_deployment_operation_sdk, resource_type=ResourceType.MGMT_RESOURCE_RESOURCES) as g:
457+
with self.command_group('deployment operation group', resource_deployment_operation_sdk, resource_type=ResourceType.MGMT_RESOURCE_DEPLOYMENTS) as g:
459458
g.custom_command('list', 'list_deployment_operations_at_resource_group')
460459
g.custom_show_command('show', 'get_deployment_operations_at_resource_group', client_factory=cf_deployment_operations)
461460

462461
# az deployment mg
463-
with self.command_group('deployment mg', resource_deployment_sdk, min_api='2019-07-01', resource_type=ResourceType.MGMT_RESOURCE_RESOURCES) as g:
462+
with self.command_group('deployment mg', resource_deployment_sdk, resource_type=ResourceType.MGMT_RESOURCE_DEPLOYMENTS) as g:
464463
g.custom_command('list', 'list_deployments_at_management_group', table_transformer=transform_deployments_list)
465464
g.custom_show_command('show', 'get_deployment_at_management_group', table_transformer=transform_deployment)
466465
g.custom_command('delete', 'delete_deployment_at_management_group', supports_no_wait=True)
@@ -469,17 +468,17 @@ def load_command_table(self, _):
469468
g.custom_command('create', 'deploy_arm_template_at_management_group', supports_no_wait=True, validator=process_deployment_create_namespace,
470469
table_transformer=transform_deployment, exception_handler=handle_template_based_exception)
471470
g.custom_command('what-if', 'what_if_deploy_arm_template_at_management_group', validator=process_deployment_create_namespace,
472-
exception_handler=handle_template_based_exception, min_api='2019-10-01')
471+
exception_handler=handle_template_based_exception)
473472
g.custom_command('export', 'export_template_at_management_group')
474473
g.custom_wait_command('wait', 'get_deployment_at_management_group')
475474
g.custom_command('cancel', 'cancel_deployment_at_management_group')
476475

477-
with self.command_group('deployment operation mg', resource_deployment_operation_sdk, min_api='2019-07-01', resource_type=ResourceType.MGMT_RESOURCE_RESOURCES) as g:
476+
with self.command_group('deployment operation mg', resource_deployment_operation_sdk, resource_type=ResourceType.MGMT_RESOURCE_DEPLOYMENTS) as g:
478477
g.custom_command('list', 'list_deployment_operations_at_management_group')
479478
g.custom_show_command('show', 'get_deployment_operations_at_management_group', client_factory=cf_deployment_operations)
480479

481480
# az deployment tenant
482-
with self.command_group('deployment tenant', resource_deployment_sdk, min_api='2019-07-01', resource_type=ResourceType.MGMT_RESOURCE_RESOURCES) as g:
481+
with self.command_group('deployment tenant', resource_deployment_sdk, resource_type=ResourceType.MGMT_RESOURCE_DEPLOYMENTS) as g:
483482
g.custom_command('list', 'list_deployments_at_tenant_scope', table_transformer=transform_deployments_list)
484483
g.custom_show_command('show', 'get_deployment_at_tenant_scope', table_transformer=transform_deployment)
485484
g.custom_command('delete', 'delete_deployment_at_tenant_scope', supports_no_wait=True)
@@ -488,12 +487,12 @@ def load_command_table(self, _):
488487
g.custom_command('create', 'deploy_arm_template_at_tenant_scope', supports_no_wait=True, validator=process_deployment_create_namespace,
489488
table_transformer=transform_deployment, exception_handler=handle_template_based_exception)
490489
g.custom_command('what-if', 'what_if_deploy_arm_template_at_tenant_scope', validator=process_deployment_create_namespace,
491-
exception_handler=handle_template_based_exception, min_api='2019-10-01')
490+
exception_handler=handle_template_based_exception)
492491
g.custom_command('export', 'export_template_at_tenant_scope')
493492
g.custom_wait_command('wait', 'get_deployment_at_tenant_scope')
494493
g.custom_command('cancel', 'cancel_deployment_at_tenant_scope')
495494

496-
with self.command_group('deployment operation tenant', resource_deployment_operation_sdk, min_api='2019-07-01', resource_type=ResourceType.MGMT_RESOURCE_RESOURCES) as g:
495+
with self.command_group('deployment operation tenant', resource_deployment_operation_sdk, resource_type=ResourceType.MGMT_RESOURCE_DEPLOYMENTS) as g:
497496
g.custom_command('list', 'list_deployment_operations_at_tenant_scope')
498497
g.custom_show_command('show', 'get_deployment_operations_at_tenant_scope', client_factory=cf_deployment_operations)
499498

0 commit comments

Comments
 (0)