[Service Fabric] BREAKING CHANGE: az sf managed-application update: Remove argument options to fix --help formatting (#31814)

Author: iliu816

linter_exclusions.yml

@@ -3257,6 +3257,14 @@ sf application update:
     upgrade_replica_set_check_timeout:
       rule_exclusions:
       - option_length_too_long
+sf managed-application update:
+  parameters:
+    instance_close_delay_duration:
+      rule_exclusions:
+      - option_length_too_long
+    service_type_health_policy_map:
+      rule_exclusions:
+      - option_length_too_long
 sf cluster certificate add:
   parameters:
     certificate_output_folder:

src/azure-cli/azure/cli/command_modules/servicefabric/_breaking_change.py

@@ -1,67 +1,8 @@
-# --------------------------------------------------------------------------------------------
 # Copyright (c) Microsoft Corporation. All rights reserved.
 # Licensed under the MIT License. See License.txt in the project root for license information.
 # --------------------------------------------------------------------------------------------
 
-from azure.cli.core.breaking_change import register_argument_deprecate, register_required_flag_breaking_change
+from azure.cli.core.breaking_change import register_other_breaking_change
 
-register_argument_deprecate(
-    "az sf application update",
-    "--service-type-policy",
-    hide=True)
-register_argument_deprecate(
-    "az sf application update",
-    "--upgrade-replica-set-check-timeout",
-    hide=True)
-register_argument_deprecate(
-    "az sf application update",
-    "--max-porcent-unhealthy-partitions",
-    hide=True)
-register_argument_deprecate(
-    "az sf application update",
-    "--max-porcent-unhealthy-replicas",
-    hide=True)
-register_argument_deprecate(
-    "az sf application update",
-    "--max-porcent-unhealthy-services",
-    hide=True)
-register_argument_deprecate(
-    "az sf application update",
-    "--max-porcent-unhealthy-apps",
-    hide=True)
-register_argument_deprecate(
-    "az sf managed-application update",
-    "--service-type-policy",
-    hide=True)
-register_argument_deprecate(
-    "az sf managed-application update",
-    "--upgrade-replica-set-check-timeout",
-    hide=True)
-register_argument_deprecate(
-    "az sf managed-application update",
-    "--instance-close-duration",
-    hide=True)
-register_argument_deprecate(
-    "az sf managed-application update",
-    "--consider-warning-as-error",
-    hide=True)
-register_argument_deprecate(
-    "az sf managed-application update",
-    "--max-percent-unhealthy-partitions",
-    hide=True)
-register_argument_deprecate(
-    "az sf managed-application update",
-    "--max-percent-unhealthy-replicas",
-    hide=True)
-register_argument_deprecate(
-    "az sf managed-application update",
-    "--max-percent-unhealthy-services",
-    hide=True)
-register_argument_deprecate(
-    "az sf managed-application update",
-    "--max-percent-unhealthy-deployed-applications",
-    hide=True)
-register_required_flag_breaking_change(
-    "az sf managed-application-type version update",
-    "--package-url"
-)
+register_other_breaking_change('sf managed-application update',
+                               'Options list has changed, run help command to see allowed options')

src/azure-cli/azure/cli/command_modules/servicefabric/_help.py

@@ -40,7 +40,7 @@
     text: >
         az sf application update -g testRG -c testCluster --application-name testApp --application-type-version v2 \\
           --application-parameters key0=value0 --health-check-stable-duration 0 --health-check-wait-duration 0 --health-check-retry-timeout 0 \\
-            --upgrade-domain-timeout 5000 --upgrade-timeout 7000 --failure-action Rollback --upgrade-replica-set-check-timeout 300 --force-restart
+            --upgrade-domain-timeout 5000 --upgrade-timeout 7000 --failure-action Rollback --replica-check-timeout 300 --force-restart
   - name: Update application minimum and maximum nodes.
     text: >
         az sf application update -g testRG -c testCluster --application-name testApp --minimum-nodes 1 --maximum-nodes 3
@@ -680,7 +680,7 @@
     text: >
         az sf managed-application update -g testRG -c testCluster --application-name testApp --application-type-version v2 \\
           --application-parameters key0=value0 --health-check-stable-duration 0 --health-check-wait-duration 0 --health-check-retry-timeout 0 \\
-            --upgrade-domain-timeout 5000 --upgrade-timeout 7000 --failure-action Rollback --upgrade-replica-set-check-timeout 300 --force-restart
+            --upgrade-domain-timeout 5000 --upgrade-timeout 7000 --failure-action Rollback --replica-check-timeout 300 --force-restart
   - name: Update managed application service type health policy map.
     text: >
         az sf managed-application update -g testRG -c testCluster --application-name testApp --service-type-health-policy-map  \"ServiceTypeName01\"=\"5,10,5\" \"ServiceTypeName02\"=\"5,5,5\"