[container app] Fix #28226: az containerapp job update: Update existing scale rules if --scale-rule-name is passed (#28408)

Author: anandanthony

src/azure-cli/azure/cli/command_modules/containerapp/custom.py

@@ -51,7 +51,6 @@
     RegistryCredentials as RegistryCredentialsModel,
     ContainerResources as ContainerResourcesModel,
     Scale as ScaleModel,
-    JobScale as JobScaleModel,
     Container as ContainerModel,
     GitHubActionConfiguration,
     RegistryInfo as RegistryInfoModel,
@@ -1200,16 +1199,7 @@ def update_containerappsjob_logic(cmd,
                     eventTriggerConfig_def["scale"]["maxExecutions"] = max_executions
                 if polling_interval is not None:
                     eventTriggerConfig_def["scale"]["pollingInterval"] = polling_interval
-
-                scale_def = None
-                if min_executions is not None or max_executions is not None or polling_interval is not None:
-                    scale_def = JobScaleModel
-                    scale_def["pollingInterval"] = polling_interval
-                    scale_def["minExecutions"] = min_executions
-                    scale_def["maxReplicas"] = max_executions
-                # so we don't overwrite rules
-                if safe_get(new_containerappsjob, "properties", "template", "scale", "rules"):
-                    new_containerappsjob["properties"]["template"]["scale"].pop(["rules"])
+                # ScaleRule
                 if scale_rule_name:
                     scale_rule_type = scale_rule_type.lower()
                     scale_rule_def = ScaleRuleModel
@@ -1220,10 +1210,17 @@ def update_containerappsjob_logic(cmd,
                     scale_rule_def["type"] = scale_rule_type
                     scale_rule_def["metadata"] = metadata_def
                     scale_rule_def["auth"] = auth_def
-                    if not scale_def:
-                        scale_def = JobScaleModel
-                    scale_def["rules"] = [scale_rule_def]
-                    eventTriggerConfig_def["scale"]["rules"] = scale_def["rules"]
+                    if safe_get(eventTriggerConfig_def, "scale", "rules") is None:
+                        eventTriggerConfig_def["scale"]["rules"] = []
+                    existing_rules = eventTriggerConfig_def["scale"]["rules"]
+                    updated_rule = False
+                    for rule in existing_rules:
+                        if rule["name"] == scale_rule_name:
+                            rule.update(scale_rule_def)
+                            updated_rule = True
+                            break
+                    if not updated_rule:
+                        existing_rules.append(scale_rule_def)
 
             new_containerappsjob["properties"]["configuration"]["eventTriggerConfig"] = eventTriggerConfig_def