[Compute] az vm disk attach: Add new parameters --source-snapshots-or-disks and --source-disk-restore-point to support implicit disk creation from snapshot and disk restore points(#31830)

Author: Jing-song

src/azure-cli/azure/cli/command_modules/vm/_params.py

@@ -544,6 +544,8 @@ def load_arguments(self, _):
                    completer=get_resource_name_completion_list('Microsoft.Compute/disks'))
         c.argument('ids', deprecate_info=c.deprecate(target='--ids', redirect='--disks', hide=True))
         c.argument('disk_ids', nargs='+', min_api='2024-03-01', help='The disk IDs of the managed disk (space-delimited).')
+        c.argument('source_snapshots_or_disks', options_list=['--source-snapshots-or-disks', '--source-resource'], nargs='+', min_api='2024-11-01', help='Create a data disk from a snapshot or another disk. Can use the ID of a disk or snapshot.')
+        c.argument('source_disk_restore_point', options_list=['--source-disk-restore-point', '--source-disk-rp'], nargs='+', min_api='2024-11-01', help='create a data disk from a disk restore point. Can use the ID of a disk restore point.')
 
     with self.argument_context('vm disk detach') as c:
         c.argument('disk_name', arg_type=name_arg_type, help='The data disk name.')

src/azure-cli/azure/cli/command_modules/vm/_validators.py

@@ -1886,8 +1886,10 @@ def validate_vmss_update_namespace(cmd, namespace):  # pylint: disable=unused-ar
 
 # region disk, snapshot, image validators
 def process_vm_disk_attach_namespace(cmd, namespace):
-    if not namespace.disks and not namespace.disk and not namespace.disk_ids:
-        raise RequiredArgumentMissingError("Please use at least one of --name, --disks and --disk-ids")
+    if not namespace.disks and not namespace.disk and not namespace.disk_ids and \
+            not namespace.source_snapshots_or_disks and not namespace.source_disk_restore_point:
+        raise RequiredArgumentMissingError("Please use at least one of --name, --disks, --disk-ids,"
+                                           " --source-snapshots-or-disks and --source-disk-restore-point")
 
     if namespace.disk and namespace.disks:
         raise MutuallyExclusiveArgumentError("You can only specify one of --name and --disks")

src/azure-cli/azure/cli/command_modules/vm/custom.py

@@ -2092,7 +2092,8 @@ def show_default_diagnostics_configuration(is_windows_os=False):
 
 # region VirtualMachines Disks (Managed)
 def attach_managed_data_disk(cmd, resource_group_name, vm_name, disk=None, ids=None, disks=None, new=False, sku=None,
-                             size_gb=None, lun=None, caching=None, enable_write_accelerator=False, disk_ids=None):
+                             size_gb=None, lun=None, caching=None, enable_write_accelerator=False, disk_ids=None,
+                             source_snapshots_or_disks=None, source_disk_restore_point=None):
     # attach multiple managed disks using disk attach API
     vm = get_vm_to_update(cmd, resource_group_name, vm_name)
     if not new and not sku and not size_gb and disk_ids is not None:
@@ -2148,6 +2149,33 @@ def attach_managed_data_disk(cmd, resource_group_name, vm_name, disk=None, ids=N
                 data_disk.write_accelerator_enabled = enable_write_accelerator
 
             vm.storage_profile.data_disks.append(data_disk)
+        disk_lun = _get_disk_lun(vm.storage_profile.data_disks)
+        if source_snapshots_or_disks is not None:
+            for disk_item in source_snapshots_or_disks:
+                disk = {
+                    'create_option': 'Copy',
+                    'caching': caching,
+                    'lun': disk_lun,
+                    'writeAcceleratorEnabled': enable_write_accelerator,
+                    "sourceResource": {
+                        "id": disk_item
+                    }
+                }
+                disk_lun += 1
+                vm.storage_profile.data_disks.append(disk)
+        if source_disk_restore_point is not None:
+            for disk_item in source_disk_restore_point:
+                disk = {
+                    'create_option': 'Restore',
+                    'caching': caching,
+                    'lun': disk_lun,
+                    'writeAcceleratorEnabled': enable_write_accelerator,
+                    "sourceResource": {
+                        "id": disk_item
+                    }
+                }
+                disk_lun += 1
+                vm.storage_profile.data_disks.append(disk)
 
         set_vm(cmd, vm)