Skip to content

Commit 755c2e7

Browse files
committed
PR fixes
1 parent 2b07fdb commit 755c2e7

2 files changed

Lines changed: 13 additions & 13 deletions

File tree

src/azure-cli/HISTORY.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -134,7 +134,7 @@ Release History
134134
* Fix #33180: `az functionapp plan create`: Simplify reserved parameter assignment in AppServicePlan (#33202)
135135
* `az webapp sitecontainers convert`: Add support for converting Docker Compose multi-container apps to Sitecontainers mode (#33131)
136136
* `az webapp up/deploy`: Add `--enriched-errors` parameter to see detailed deployment failure log (#32940)
137-
* `az webapp status`: Add new command to show per-instance Site Runtime Status (#160)
137+
* `az webapp status`: Add new command to show per-instance Site Runtime Status (#33632)
138138
* `az webapp create`: Add error message that clearly lists all valid options and specifies how to discover available runtimes (#33252)
139139
* `az appservice plan create`: Make `P0V3` as default SKU when `--sku` is omitted for linux webapp (#33237)
140140
* `az appservice plan create`: Add `PREMIUM0V3` tier for elastic scale (#33237)

src/azure-cli/azure/cli/command_modules/appservice/custom.py

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -390,7 +390,7 @@ def create_webapp(cmd, resource_group_name, name, plan, runtime=None, startup_fi
390390
multicontainer_config_type, sitecontainers_app,
391391
deployment_source_url, deployment_local_git]):
392392
logger.warning("Webapp '%s' created. Deploy your code with: az webapp deploy", name)
393-
_log_webapp_status_tip(name, resource_group_name)
393+
_log_webapp_status_tip(name, resource_group_name, is_linux)
394394
return webapp
395395

396396

@@ -2462,7 +2462,11 @@ def show_app(cmd, resource_group_name, name, slot=None):
24622462
return app
24632463

24642464

2465-
def _log_webapp_status_tip(name, resource_group_name):
2465+
def _log_webapp_status_tip(name, resource_group_name, is_linux):
2466+
# Per-instance runtime status (siteStatus) is a Linux App Service feature,
2467+
# so only surface the tip for Linux webapps.
2468+
if not is_linux:
2469+
return
24662470
logger.warning("Tip: run 'az webapp status --name %s --resource-group %s' "
24672471
"to see per-instance runtime status.",
24682472
name, resource_group_name)
@@ -3656,15 +3660,11 @@ def stop_webapp(cmd, resource_group_name, name, slot=None):
36563660

36573661

36583662
def start_webapp(cmd, resource_group_name, name, slot=None):
3659-
result = _generic_site_operation(cmd.cli_ctx, resource_group_name, name, 'start', slot)
3660-
_log_webapp_status_tip(name, resource_group_name)
3661-
return result
3663+
return _generic_site_operation(cmd.cli_ctx, resource_group_name, name, 'start', slot)
36623664

36633665

36643666
def restart_webapp(cmd, resource_group_name, name, slot=None):
3665-
result = _generic_site_operation(cmd.cli_ctx, resource_group_name, name, 'restart', slot)
3666-
_log_webapp_status_tip(name, resource_group_name)
3667-
return result
3667+
return _generic_site_operation(cmd.cli_ctx, resource_group_name, name, 'restart', slot)
36683668

36693669

36703670
def get_site_configs(cmd, resource_group_name, name, slot=None):
@@ -10024,14 +10024,14 @@ def _poll_deployment_runtime_status(cmd, resource_group_name, webapp_name, slot,
1002410024
logger.warning("Status: %s Time: %s(s)", status, time_elapsed)
1002510025
if deployment_status == "RuntimeStarting":
1002610026
if not status_tip_logged:
10027-
_log_webapp_status_tip(webapp_name, resource_group_name)
10027+
_log_webapp_status_tip(webapp_name, resource_group_name, True)
1002810028
status_tip_logged = True
1002910029
logger.info("InprogressInstances: %s, SuccessfulInstances: %s",
1003010030
deployment_properties.get('numberOfInstancesInProgress'),
1003110031
deployment_properties.get('numberOfInstancesSuccessful'))
1003210032
if deployment_status == "RuntimeSuccessful":
1003310033
if not status_tip_logged:
10034-
_log_webapp_status_tip(webapp_name, resource_group_name)
10034+
_log_webapp_status_tip(webapp_name, resource_group_name, True)
1003510035
break
1003610036
if deployment_status == "RuntimeFailed":
1003710037
error_text = ""
@@ -10917,7 +10917,7 @@ def webapp_up(cmd, name=None, resource_group_name=None, plan=None, location=None
1091710917
logger.warning("You can launch the app at %s", _url)
1091810918
create_json.update({'URL': _url})
1091910919

10920-
_log_webapp_status_tip(name, rg_name)
10920+
_log_webapp_status_tip(name, rg_name, _is_linux)
1092110921

1092210922
if logs:
1092310923
_configure_default_logging(cmd, rg_name, name)
@@ -11674,7 +11674,7 @@ def _make_onedeploy_request(params):
1167411674
response_body = response.json().get("properties", {})
1167511675
logger.warning("Deployment has completed successfully")
1167611676
if not (poll_async_deployment_for_debugging and params.track_status):
11677-
_log_webapp_status_tip(params.webapp_name, params.resource_group_name)
11677+
_log_webapp_status_tip(params.webapp_name, params.resource_group_name, params.is_linux_webapp)
1167811678
logger.warning("You can visit your app at: %s", _get_visit_url(params))
1167911679
return response_body
1168011680

0 commit comments

Comments
 (0)