Skip to content

Commit 7b824e2

Browse files
FumingZhangnaga-nandyala
authored andcommitted
{AKS} az aks enable-addons: Terminate progress bar on role assignment/deletion failure in AKS addon configuration (#32928)
1 parent b2a0692 commit 7b824e2

1 file changed

Lines changed: 4 additions & 2 deletions

File tree

src/azure-cli/azure/cli/command_modules/acs/_roleassignments.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -125,8 +125,9 @@ def add_role_assignment(cmd, role, service_principal_msi_id, is_service_principa
125125
logger.error(str(ex))
126126
time.sleep(delay + delay * x)
127127
else:
128+
hook.end(message="AAD role propagation failed", value=1.0, total_val=1.0)
128129
return False
129-
hook.add(message="AAD role propagation done", value=1.0, total_val=1.0)
130+
hook.end(message="AAD role propagation done", value=1.0, total_val=1.0)
130131
logger.info("AAD role propagation done")
131132
return True
132133

@@ -205,8 +206,9 @@ def delete_role_assignments(cli_ctx, role, service_principal, delay=2, scope=Non
205206
logger.error(str(ex))
206207
time.sleep(delay + delay * x)
207208
else:
209+
hook.end(message="AAD role deletion failed", value=1.0, total_val=1.0)
208210
return False
209-
hook.add(message="AAD role deletion done", value=1.0, total_val=1.0)
211+
hook.end(message="AAD role deletion done", value=1.0, total_val=1.0)
210212
logger.info("AAD role deletion done")
211213
return True
212214

0 commit comments

Comments
 (0)