Skip to content

Commit a4ee13b

Browse files
bastianbeischernaga-nandyala
authored andcommitted
{ACR} az acr build: Correctly identify .dockerignore file (#30231) (#32633)
1 parent 750e363 commit a4ee13b

File tree

1 file changed

+8
-9
lines changed

1 file changed

+8
-9
lines changed

src/azure-cli/azure/cli/command_modules/acr/_archive_utils.py

Lines changed: 8 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -63,8 +63,7 @@ def upload_source_code(cmd, client,
6363
def _pack_source_code(source_location, tar_file_path, docker_file_path, docker_file_in_tar):
6464
logger.warning("Packing source code into tar to upload...")
6565

66-
original_docker_file_name = os.path.basename(docker_file_path.replace("\\", os.sep))
67-
ignore_list, ignore_list_size = _load_dockerignore_file(source_location, original_docker_file_name)
66+
ignore_list, ignore_list_size = _load_dockerignore_file(source_location, docker_file_path)
6867
common_vcs_ignore_list = {'.git', '.gitignore', '.bzr', 'bzrignore', '.hg', '.hgignore', '.svn'}
6968
# Directories that should be completely excluded (no recursive descent) for performance reasons.
7069
# These typically contain large numbers of files that are not needed for container build context.
@@ -156,15 +155,15 @@ def __init__(self, rule):
156155

157156

158157
def _load_dockerignore_file(source_location, original_docker_file_name):
158+
docker_file_name = original_docker_file_name.replace("\\", os.sep)
159159
# reference: https://docs.docker.com/engine/reference/builder/#dockerignore-file
160160
docker_ignore_file = os.path.join(source_location, ".dockerignore")
161-
docker_ignore_file_override = None
162-
if original_docker_file_name != "Dockerfile":
163-
docker_ignore_file_override = os.path.join(
164-
source_location, "{}.dockerignore".format(original_docker_file_name))
165-
if os.path.exists(docker_ignore_file_override):
166-
logger.warning("Overriding .dockerignore with %s", docker_ignore_file_override)
167-
docker_ignore_file = docker_ignore_file_override
161+
docker_ignore_file_override = os.path.join(
162+
source_location, "{}.dockerignore".format(docker_file_name)
163+
)
164+
if os.path.exists(docker_ignore_file_override):
165+
logger.warning("Overriding .dockerignore with %s", docker_ignore_file_override)
166+
docker_ignore_file = docker_ignore_file_override
168167

169168
if not os.path.exists(docker_ignore_file):
170169
return None, 0

0 commit comments

Comments
 (0)