Skip to content

Commit ab29784

Browse files
committed
update test case
1 parent e5d20e2 commit ab29784

1 file changed

Lines changed: 3 additions & 36 deletions

File tree

src/azure-cli/azure/cli/command_modules/acs/tests/latest/test_aks_commands.py

Lines changed: 3 additions & 36 deletions
Original file line numberDiff line numberDiff line change
@@ -7392,16 +7392,13 @@ def test_aks_create_network_cidr(self, resource_group, resource_group_location):
73927392
@live_only()
73937393
@AllowLargeResponse()
73947394
@AKSCustomResourceGroupPreparer(random_name_length=17, name_prefix='clitest', location='westus2')
7395-
@AKSCustomRoleBasedServicePrincipalPreparer()
7396-
def test_aks_create_attach_acr(self, resource_group, resource_group_location, sp_name, sp_password):
7395+
def test_aks_create_attach_acr(self, resource_group, resource_group_location):
73977396
aks_name = self.create_random_name('cliakstest', 16)
73987397
acr_name = self.create_random_name('cliaksacr', 16)
73997398
self.kwargs.update({
74007399
'name': aks_name,
74017400
'resource_group': resource_group,
74027401
'ssh_key_value': self.generate_ssh_keys(),
7403-
'service_principal': sp_name,
7404-
'client_secret': sp_password,
74057402
'acr_name': acr_name
74067403
})
74077404

@@ -7413,18 +7410,9 @@ def test_aks_create_attach_acr(self, resource_group, resource_group_location, sp
74137410

74147411
# create
74157412
create_cmd = 'aks create --resource-group={resource_group} --name={name} ' \
7416-
'--service-principal={service_principal} --client-secret={client_secret} ' \
74177413
'--ssh-key-value={ssh_key_value} --attach-acr={acr_name}'
74187414
self.cmd(create_cmd, checks=[
74197415
self.check('provisioningState', 'Succeeded'),
7420-
self.check('servicePrincipalProfile.clientId', sp_name)
7421-
])
7422-
7423-
# add Mariner node pool
7424-
node_pool_cmd = 'aks nodepool add --resource-group={resource_group} --cluster-name={name} ' \
7425-
'-n marinerpool --os-sku mariner'
7426-
self.cmd(node_pool_cmd, checks=[
7427-
self.check('provisioningState', 'Succeeded')
74287416
])
74297417

74307418
# install kubectl
@@ -7457,7 +7445,7 @@ def test_aks_create_attach_acr(self, resource_group, resource_group_location, sp
74577445
finally:
74587446
os.close(fd)
74597447
# get node name
7460-
k_get_node_cmd = ["kubectl", "get", "node", "-l", "kubernetes.azure.com/os-sku=Ubuntu", "-o", "name", "--kubeconfig", browse_path]
7448+
k_get_node_cmd = ["kubectl", "get", "node", "-o", "name", "--kubeconfig", browse_path]
74617449
k_get_node_output = subprocess.check_output(
74627450
k_get_node_cmd,
74637451
universal_newlines=True,
@@ -7470,35 +7458,14 @@ def test_aks_create_attach_acr(self, resource_group, resource_group_location, sp
74707458
"node_name": node_name,
74717459
}
74727460
)
7473-
# check acr from Ubuntu node
7461+
# check acr
74747462
check_cmd = "aks check-acr -n {name} -g {resource_group} --acr {acr_name}.azurecr.io --node-name {node_name}"
74757463
self.cmd(
74767464
check_cmd,
74777465
checks=[
74787466
StringContainCheck("Your cluster can pull images from {}.azurecr.io!".format(acr_name)),
74797467
],
74807468
)
7481-
# check acr from Mariner node
7482-
k_get_mariner_node_cmd = ["kubectl", "get", "node", "-l", "kubernetes.azure.com/os-sku=Mariner", "-o", "name", "--kubeconfig", browse_path]
7483-
k_get_node_output = subprocess.check_output(
7484-
k_get_mariner_node_cmd,
7485-
universal_newlines=True,
7486-
stderr=subprocess.STDOUT,
7487-
)
7488-
mariner_node_names = k_get_node_output.split("\n")
7489-
mariner_node_name = mariner_node_names[0].strip().strip("node/").strip()
7490-
self.kwargs.update(
7491-
{
7492-
"mariner_node_name": mariner_node_name,
7493-
}
7494-
)
7495-
check_mariner_cmd = "aks check-acr -n {name} -g {resource_group} --acr {acr_name}.azurecr.io --node-name {mariner_node_name}"
7496-
self.cmd(
7497-
check_mariner_cmd,
7498-
checks=[
7499-
StringContainCheck("Your cluster can pull images from {}.azurecr.io!".format(acr_name)),
7500-
],
7501-
)
75027469
# clean up test hook file even if test failed
75037470
finally:
75047471
if os.path.exists(hook_file_path):

0 commit comments

Comments
 (0)