Address review comments and fix style: slot_cfg reconciliation, stronger test assertions

- Fix pylint R1735: use dict literal instead of dict() call (line 6009)
- In replace_all mode, reconcile slot_cfg_names.connection_string_names
  to exactly match new slotSetting=true entries, removing stale names
- Strengthen test_slot_param_configured_with_id_part to check that the
  slot argument specifically (not just any argument) has id_part
- Fix TestListSslCertsPagination docstring: remove incorrect Issue #29495
  reference since that issue is about az webapp list, not SSL cert pagination

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Author: seligj95

src/azure-cli/azure/cli/command_modules/appservice/custom.py

@@ -3569,7 +3569,13 @@ def update_connection_strings(cmd, resource_group_name, name, connection_string_
                                          'update_connection_strings',
                                          conn_strings, slot, client)
 
-    if sticky_slot_settings or rm_sticky_slot_settings:
+    if replace_all:
+        # Replace-all: slot config names must exactly match new slotSetting=true entries
+        new_slot_setting_names = set(n['name'] for n in sticky_slot_settings)
+        slot_cfg_names = client.web_apps.list_slot_configuration_names(resource_group_name, name)
+        slot_cfg_names.connection_string_names = list(new_slot_setting_names)
+        client.web_apps.update_slot_configuration_names(resource_group_name, name, slot_cfg_names)
+    elif sticky_slot_settings or rm_sticky_slot_settings:
         new_slot_setting_names = set(n['name'] for n in sticky_slot_settings)  # add setting name
         slot_cfg_names = client.web_apps.list_slot_configuration_names(resource_group_name, name)
         slot_cfg_names.connection_string_names = set(slot_cfg_names.connection_string_names or [])
@@ -6006,8 +6012,8 @@ def create_managed_ssl_cert(cmd, resource_group_name, name, hostname, slot=None,
 
     server_farm_id = webapp.server_farm_id
     location = webapp.location
-    cert_kwargs = dict(location=location, canonical_name=hostname,
-                       server_farm_id=server_farm_id, password='')
+    cert_kwargs = {"location": location, "canonical_name": hostname,
+                   "server_farm_id": server_farm_id, "password": ''}
     if domain_validation_method:
         cert_kwargs['domain_validation_method'] = domain_validation_method
     easy_cert_def = Certificate(**cert_kwargs)

src/azure-cli/azure/cli/command_modules/appservice/tests/latest/test_webapp_commands_thru_mock.py

@@ -779,6 +779,11 @@ def test_json_settings_replaces_all(self, mock_redact, mock_client_factory, mock
         client_mock = mock.MagicMock()
         mock_client_factory.return_value = client_mock
 
+        # Simulate stale slot config names for connection strings that will be removed
+        slot_cfg_mock = mock.MagicMock()
+        slot_cfg_mock.connection_string_names = ['OldConn', 'KeepConn']
+        client_mock.web_apps.list_slot_configuration_names.return_value = slot_cfg_mock
+
         json_settings = ['[{"name":"NewConn","value":"new_val","type":"SQLAzure"}]']
         update_connection_strings(cmd_mock, 'rg', 'app', settings=json_settings)
 
@@ -787,6 +792,11 @@ def test_json_settings_replaces_all(self, mock_redact, mock_client_factory, mock
         self.assertNotIn('KeepConn', existing_conn_strings.properties)
         self.assertIn('NewConn', existing_conn_strings.properties)
 
+        # Stale slot config names should be cleared in replace-all mode
+        client_mock.web_apps.update_slot_configuration_names.assert_called_once()
+        updated_cfg = client_mock.web_apps.update_slot_configuration_names.call_args[0][2]
+        self.assertEqual(updated_cfg.connection_string_names, [])
+
     @mock.patch('azure.cli.command_modules.appservice.custom._generic_settings_operation')
     @mock.patch('azure.cli.command_modules.appservice.custom._generic_site_operation')
     @mock.patch('azure.cli.command_modules.appservice.custom.web_client_factory')
@@ -819,7 +829,7 @@ def test_key_value_settings_merges(self, mock_redact, mock_client_factory, mock_
 
 
 class TestListSslCertsPagination(unittest.TestCase):
-    """Tests for list_ssl_certs pagination fix (Issue #29495)."""
+    """Tests for list_ssl_certs pagination behavior."""
 
     @mock.patch('azure.cli.command_modules.appservice.custom.web_client_factory')
     def test_list_ssl_certs_returns_list(self, mock_client_factory):
@@ -875,9 +885,13 @@ def test_slot_param_configured_with_id_part(self):
         from azure.cli.command_modules.appservice import _params
 
         source = inspect.getsource(_params.load_arguments)
-        # The webapp context should have slot configured with id_part='child_name_1'
-        self.assertIn("id_part='child_name_1'", source,
-                       "slot argument must have id_part='child_name_1' for --ids slot parsing")
+        # Find the specific line that configures the slot argument with id_part
+        slot_lines = [line.strip() for line in source.splitlines()
+                      if "argument('slot'" in line and "id_part=" in line]
+        self.assertTrue(len(slot_lines) > 0,
+                        "Expected c.argument('slot', ..., id_part=...) in load_arguments")
+        self.assertTrue(any("child_name_1" in line for line in slot_lines),
+                        "slot argument must have id_part='child_name_1' for --ids slot parsing")
 
 
 class FakedResponse:  # pylint: disable=too-few-public-methods