Skip to content

Commit d1c44e9

Browse files
author
Rena Chen
committed
Update addressing comments
1 parent 7ff92c9 commit d1c44e9

3 files changed

Lines changed: 4 additions & 3 deletions

File tree

src/azure-cli/azure/cli/command_modules/batch/_breaking_change.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,10 +29,10 @@
2929
# Outputs
3030
register_output_breaking_change(
3131
"batch pool show",
32-
description="Reduce output field `targetNodeCommunicationMode`, `currentNodeCommunicationMode`, and `resourceTags`"
32+
description="Remove output fields `targetNodeCommunicationMode`, `currentNodeCommunicationMode`, and `resourceTags`"
3333
)
3434

3535
register_output_breaking_change(
3636
"batch pool list",
37-
description="Reduce output field `targetNodeCommunicationMode`, `currentNodeCommunicationMode`, and `resourceTags`"
37+
description="Remove output fields `targetNodeCommunicationMode`, `currentNodeCommunicationMode`, and `resourceTags`"
3838
)

src/azure-cli/azure/cli/command_modules/batch/_params.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -382,6 +382,7 @@ def load_arguments(self, _):
382382

383383
with self.argument_context('batch pool create') as c:
384384
c.argument('json_file', help='The file containing pool create properties parameter specification in JSON(formatted to match REST API request body). If this parameter is specified, all \'Pool Create Properties Parameter Arguments\' are ignored. See https://learn.microsoft.com/rest/api/batchservice/pool/add?tabs=HTTP#request-body')
385+
# Add action=None to work around an error registering a breaking change for this argument
385386
c.argument('resource_tags', action=None, arg_group='Pool', type=resource_tag_format, help="User is able to specify resource tags for the pool. Any resource created for the pool will then also be tagged by the same resource tags")
386387
c.argument('target_node_communication_mode', options_list=['--target-communication'],
387388
help="The desired node communication mode for the pool. If this element is present, it replaces the existing targetNodeCommunicationMode configured on the Pool. If omitted, any existing metadata is left unchanged.",

src/azure-cli/azure/cli/command_modules/batch/tests/latest/test_batch_transformers.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ class TestBatchTransformers(unittest.TestCase):
1313

1414
def test_transform_object_empty_list(self):
1515
fake_transformer = Transformer({"testing": "potato"})
16-
result = fake_transformer.transform_result([]) 
16+
result = fake_transformer.transform_result([])
1717
self.assertEqual(result, [])
1818

1919
def test_transform_object(self):

0 commit comments

Comments
 (0)