Skip to content

Commit d2d8493

Browse files
committed
Address Copilot PR review: fix pool casing, README filename, docstring
1 parent 024df3a commit d2d8493

4 files changed

Lines changed: 7 additions & 7 deletions

File tree

.azure-pipelines/templates/variables.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,5 +4,5 @@ variables:
44
windows_pool: 'pool-windows-2019'
55
ubuntu_arm64_pool: 'pool-ubuntu-latest-arm64'
66
macos_pool: 'macOS-14'
7-
macos_intel_pool: 'macos-15'
8-
macos_arm64_pool: 'macos-15-arm64'
7+
macos_intel_pool: 'macOS-15'
8+
macos_arm64_pool: 'macOS-15-arm64'

azure-pipelines.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -725,15 +725,15 @@ jobs:
725725
parameters:
726726
PythonVersion: $(macos_cask_python_version)
727727
MacosArm64Image: ${{ variables.macos_arm64_pool }}
728-
MacosIntelImage: ${{ variables.macos_pool }}
728+
MacosIntelImage: ${{ variables.macos_intel_pool }}
729729
condition: and(succeeded(), in(variables['Build.Reason'], 'IndividualCI', 'BatchedCI', 'Manual', 'Schedule'))
730730
dependsOn: ['ExtractMetadata']
731731

732732
# Phase 2: Sign and notarize via ESRP
733733
- template: .azure-pipelines/templates/macos/macos-sign-notarize-jobs.yml
734734
parameters:
735735
MacosArm64Image: ${{ variables.macos_arm64_pool }}
736-
MacosIntelImage: ${{ variables.macos_pool }}
736+
MacosIntelImage: ${{ variables.macos_intel_pool }}
737737
BundleId: 'com.microsoft.azure.cli'
738738
PythonVersion: $(macos_cask_python_version)
739739
ESRPServiceConnection: 'ame_esrp_connection'
@@ -744,7 +744,7 @@ jobs:
744744
- template: .azure-pipelines/templates/macos/macos-cask-generation-and-tests.yml
745745
parameters:
746746
MacosArm64Image: ${{ variables.macos_arm64_pool }}
747-
MacosIntelImage: ${{ variables.macos_pool }}
747+
MacosIntelImage: ${{ variables.macos_intel_pool }}
748748
PythonVersion: $(macos_cask_python_version)
749749
GitHubRepo: $(Build.Repository.Name)
750750
Debug: false

scripts/release/macos/build_binary_tar_gz.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -176,7 +176,7 @@ def install_azure_cli(venv_python: Path) -> None:
176176
177177
Mirrors the run.sh approach:
178178
1. Install all src packages with --no-deps (local source code takes precedence)
179-
2. Install pinned dependencies from requirements.py3.MacOS.txt
179+
2. Install pinned dependencies from requirements.py3.Darwin.txt
180180
"""
181181
# Step 1: install every package found under SRC_DIR from source, without pulling
182182
# transitive deps from PyPI (--no-deps). This ensures the locally-built wheels

scripts/release/macos/templates/README.txt.in

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ Note: The homebrew based install pulls in the required Python {PYTHON_MAJOR_MINO
2727
Manual Installation (Offline/Tarball):
2828
--------------------------------------
2929
1. Install Python from python.org or another source
30-
2. Extract: tar xzf azure-cli-{AZURE_CLI_VERSION}-{PLATFORM_TAG}-nopython.tar.gz
30+
2. Extract: tar xzf azure-cli-{AZURE_CLI_VERSION}-{PLATFORM_TAG}.tar.gz
3131
3. Set AZ_PYTHON to your Python {PYTHON_MAJOR_MINOR} path
3232
4. Run: ./libexec/bin/az --version
3333

0 commit comments

Comments
 (0)