Skip to content

Commit d49109c

Browse files
committed
PR fixes
1 parent a10bcbf commit d49109c

2 files changed

Lines changed: 13 additions & 13 deletions

File tree

src/azure-cli/HISTORY.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ Release History
3838
* Fix #33180: `az functionapp plan create`: Simplify reserved parameter assignment in AppServicePlan (#33202)
3939
* `az webapp sitecontainers convert`: Add support for converting Docker Compose multi-container apps to Sitecontainers mode (#33131)
4040
* `az webapp up/deploy`: Add `--enriched-errors` parameter to see detailed deployment failure log (#32940)
41-
* `az webapp status`: Add new command to show per-instance Site Runtime Status (#160)
41+
* `az webapp status`: Add new command to show per-instance Site Runtime Status (#33632)
4242
* `az webapp create`: Add error message that clearly lists all valid options and specifies how to discover available runtimes (#33252)
4343
* `az appservice plan create`: Make `P0V3` as default SKU when `--sku` is omitted for linux webapp (#33237)
4444
* `az appservice plan create`: Add `PREMIUM0V3` tier for elastic scale (#33237)

src/azure-cli/azure/cli/command_modules/appservice/custom.py

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -387,7 +387,7 @@ def create_webapp(cmd, resource_group_name, name, plan, runtime=None, startup_fi
387387
multicontainer_config_type, sitecontainers_app,
388388
deployment_source_url, deployment_local_git]):
389389
logger.warning("Webapp '%s' created. Deploy your code with: az webapp deploy", name)
390-
_log_webapp_status_tip(name, resource_group_name)
390+
_log_webapp_status_tip(name, resource_group_name, is_linux)
391391
return webapp
392392

393393

@@ -2429,7 +2429,11 @@ def show_app(cmd, resource_group_name, name, slot=None):
24292429
return app
24302430

24312431

2432-
def _log_webapp_status_tip(name, resource_group_name):
2432+
def _log_webapp_status_tip(name, resource_group_name, is_linux):
2433+
# Per-instance runtime status (siteStatus) is a Linux App Service feature,
2434+
# so only surface the tip for Linux webapps.
2435+
if not is_linux:
2436+
return
24332437
logger.warning("Tip: run 'az webapp status --name %s --resource-group %s' "
24342438
"to see per-instance runtime status.",
24352439
name, resource_group_name)
@@ -3623,15 +3627,11 @@ def stop_webapp(cmd, resource_group_name, name, slot=None):
36233627

36243628

36253629
def start_webapp(cmd, resource_group_name, name, slot=None):
3626-
result = _generic_site_operation(cmd.cli_ctx, resource_group_name, name, 'start', slot)
3627-
_log_webapp_status_tip(name, resource_group_name)
3628-
return result
3630+
return _generic_site_operation(cmd.cli_ctx, resource_group_name, name, 'start', slot)
36293631

36303632

36313633
def restart_webapp(cmd, resource_group_name, name, slot=None):
3632-
result = _generic_site_operation(cmd.cli_ctx, resource_group_name, name, 'restart', slot)
3633-
_log_webapp_status_tip(name, resource_group_name)
3634-
return result
3634+
return _generic_site_operation(cmd.cli_ctx, resource_group_name, name, 'restart', slot)
36353635

36363636

36373637
def get_site_configs(cmd, resource_group_name, name, slot=None):
@@ -9628,14 +9628,14 @@ def _poll_deployment_runtime_status(cmd, resource_group_name, webapp_name, slot,
96289628
logger.warning("Status: %s Time: %s(s)", status, time_elapsed)
96299629
if deployment_status == "RuntimeStarting":
96309630
if not status_tip_logged:
9631-
_log_webapp_status_tip(webapp_name, resource_group_name)
9631+
_log_webapp_status_tip(webapp_name, resource_group_name, True)
96329632
status_tip_logged = True
96339633
logger.info("InprogressInstances: %s, SuccessfulInstances: %s",
96349634
deployment_properties.get('numberOfInstancesInProgress'),
96359635
deployment_properties.get('numberOfInstancesSuccessful'))
96369636
if deployment_status == "RuntimeSuccessful":
96379637
if not status_tip_logged:
9638-
_log_webapp_status_tip(webapp_name, resource_group_name)
9638+
_log_webapp_status_tip(webapp_name, resource_group_name, True)
96399639
break
96409640
if deployment_status == "RuntimeFailed":
96419641
error_text = ""
@@ -10468,7 +10468,7 @@ def webapp_up(cmd, name=None, resource_group_name=None, plan=None, location=None
1046810468
logger.warning("You can launch the app at %s", _url)
1046910469
create_json.update({'URL': _url})
1047010470

10471-
_log_webapp_status_tip(name, rg_name)
10471+
_log_webapp_status_tip(name, rg_name, _is_linux)
1047210472

1047310473
if logs:
1047410474
_configure_default_logging(cmd, rg_name, name)
@@ -11076,7 +11076,7 @@ def _make_onedeploy_request(params):
1107611076
response_body = response.json().get("properties", {})
1107711077
logger.warning("Deployment has completed successfully")
1107811078
if not (poll_async_deployment_for_debugging and params.track_status):
11079-
_log_webapp_status_tip(params.webapp_name, params.resource_group_name)
11079+
_log_webapp_status_tip(params.webapp_name, params.resource_group_name, params.is_linux_webapp)
1108011080
logger.warning("You can visit your app at: %s", _get_url(params.cmd, params.resource_group_name,
1108111081
params.webapp_name, params.slot))
1108211082
return response_body

0 commit comments

Comments
 (0)