Skip to content

Commit e99faad

Browse files
committed
Address Copilot review: fix misleading comment and remove unused params in build_binary_tar_gz.py
1 parent ea8ae1c commit e99faad

File tree

1 file changed

+2
-4
lines changed

1 file changed

+2
-4
lines changed

scripts/release/macos/build_binary_tar_gz.py

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@
8080
TARBALL_NAME_TEMPLATE_DEFAULT = "{APP_NAME}-{VERSION}-{PLATFORM_TAG}-nopython.tar.gz"
8181

8282
# Python version we're building for (must match Homebrew python@X.Y)
83-
# Can be overridden via --python-version CLI arg or PYTHON_MAJOR_MINOR env var
83+
# Can be overridden via PYTHON_MAJOR_MINOR env var
8484
PYTHON_MAJOR_MINOR = os.environ.get("PYTHON_MAJOR_MINOR", "3.13")
8585
PYTHON_BIN = "python3"
8686
TEMPLATE_DIR = Path(__file__).resolve().parent / "templates"
@@ -225,7 +225,7 @@ def install_azure_cli(venv_python: Path) -> None:
225225
subprocess.run([str(venv_python), "-m", "azure.cli", "--version"], check=True)
226226

227227

228-
def create_install_structure(venv_dir: Path, install_dir: Path, version: str, platform_tag: str) -> None:
228+
def create_install_structure(venv_dir: Path, install_dir: Path) -> None:
229229
"""Create the final installation directory structure."""
230230
print("\n=== Creating installation structure ===")
231231

@@ -475,8 +475,6 @@ def main() -> int:
475475
create_install_structure(
476476
venv_dir=venv_dir,
477477
install_dir=install_dir,
478-
version=version,
479-
platform_tag=args.platform_tag,
480478
)
481479

482480
tarball_path = create_tarball(

0 commit comments

Comments
 (0)