Skip to content

Commit f209cca

Browse files
committed
Fix test cases
1 parent ebbc7c8 commit f209cca

2 files changed

Lines changed: 19 additions & 9 deletions

File tree

src/azure-cli-core/azure/cli/core/breaking_change.py

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -153,9 +153,12 @@ def version(self):
153153
class NextBreakingChangeWindow(TargetVersion):
154154
def __str__(self):
155155
next_breaking_change_version = _next_breaking_change_version()
156+
message = 'in next breaking change release'
156157
if next_breaking_change_version:
157-
return f'in next breaking change release({next_breaking_change_version}) scheduled for {NEXT_BREAKING_CHANGE_DATE}'
158-
return 'in next breaking change release'
158+
message += f'({next_breaking_change_version})'
159+
if NEXT_BREAKING_CHANGE_DATE:
160+
message += f' scheduled for {NEXT_BREAKING_CHANGE_DATE}'
161+
return message
159162

160163
def version(self):
161164
return _next_breaking_change_version()

src/azure-cli-core/azure/cli/core/tests/test_breaking_change.py

Lines changed: 14 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -133,14 +133,15 @@ def test_command_deprecate(self):
133133
self.assertIn('[Deprecated]', captured_output.getvalue())
134134

135135
@mock.patch('azure.cli.core.breaking_change.NEXT_BREAKING_CHANGE_RELEASE', '3.0.0')
136+
@mock.patch('azure.cli.core.breaking_change.NEXT_BREAKING_CHANGE_DATE', 'May 2024')
136137
def test_argument_deprecate(self):
137138
from contextlib import redirect_stderr, redirect_stdout
138139

139140
from azure.cli.core.breaking_change import register_argument_deprecate
140141

141142
register_argument_deprecate('test group cmd', argument='arg1', redirect='arg2')
142-
warning = ("Argument 'arg1' has been deprecated and will be removed in next breaking change release(3.0.0). "
143-
"Use 'arg2' instead.")
143+
warning = ("Argument 'arg1' has been deprecated and will be removed in next breaking change release(3.0.0) "
144+
"scheduled for May 2024. Use 'arg2' instead.")
144145
cli = DummyCli(commands_loader_cls=TestCommandsLoader)
145146

146147
captured_err = io.StringIO()
@@ -156,14 +157,15 @@ def test_argument_deprecate(self):
156157
self.assertIn('[Deprecated]', captured_output.getvalue())
157158

158159
@mock.patch('azure.cli.core.breaking_change.NEXT_BREAKING_CHANGE_RELEASE', '3.0.0')
160+
@mock.patch('azure.cli.core.breaking_change.NEXT_BREAKING_CHANGE_DATE', 'May 2024')
159161
def test_option_deprecate(self):
160162
from contextlib import redirect_stderr, redirect_stdout
161163

162164
from azure.cli.core.breaking_change import register_argument_deprecate
163165

164166
register_argument_deprecate('test group cmd', argument='--arg1', redirect='--arg1-alias')
165-
warning = ("Option '--arg1' has been deprecated and will be removed in next breaking change release(3.0.0). "
166-
"Use '--arg1-alias' instead.")
167+
warning = ("Option '--arg1' has been deprecated and will be removed in next breaking change release(3.0.0) "
168+
"scheduled for May 2024. Use '--arg1-alias' instead.")
167169
cli = DummyCli(commands_loader_cls=TestCommandsLoader)
168170

169171
captured_err = io.StringIO()
@@ -180,6 +182,7 @@ def test_option_deprecate(self):
180182
self.assertIn(' --arg1 [Deprecated]', captured_output.getvalue())
181183

182184
@mock.patch('azure.cli.core.breaking_change.NEXT_BREAKING_CHANGE_RELEASE', '3.0.0')
185+
@mock.patch('azure.cli.core.breaking_change.NEXT_BREAKING_CHANGE_DATE', None)
183186
def test_be_required(self):
184187
from contextlib import redirect_stderr, redirect_stdout
185188

@@ -207,6 +210,7 @@ def test_be_required(self):
207210
self.assertIn('[Breaking Change]', captured_output.getvalue())
208211

209212
@mock.patch('azure.cli.core.breaking_change.NEXT_BREAKING_CHANGE_RELEASE', '3.0.0')
213+
@mock.patch('azure.cli.core.breaking_change.NEXT_BREAKING_CHANGE_DATE', None)
210214
def test_default_change(self):
211215
from contextlib import redirect_stderr, redirect_stdout
212216

@@ -236,15 +240,16 @@ def test_default_change(self):
236240
self.assertIn('[Breaking Change]', captured_output.getvalue())
237241

238242
@mock.patch('azure.cli.core.breaking_change.NEXT_BREAKING_CHANGE_RELEASE', '3.0.0')
243+
@mock.patch('azure.cli.core.breaking_change.NEXT_BREAKING_CHANGE_DATE', 'May 2024')
239244
def test_output_change(self):
240245
from contextlib import redirect_stderr, redirect_stdout
241246

242247
from azure.cli.core.breaking_change import register_output_breaking_change
243248

244249
register_output_breaking_change('test group cmd', description="The output of 'test group cmd' "
245250
"would be changed.")
246-
warning = ("The output will be changed in next breaking change release(3.0.0). The output of 'test group cmd' "
247-
"would be changed.")
251+
warning = ("The output will be changed in next breaking change release(3.0.0) scheduled for May 2024. "
252+
"The output of 'test group cmd' would be changed.")
248253
cli = DummyCli(commands_loader_cls=TestCommandsLoader)
249254

250255
captured_err = io.StringIO()
@@ -265,13 +270,14 @@ def test_output_change(self):
265270
self.assertIn('[Breaking Change]', captured_output.getvalue())
266271

267272
@mock.patch('azure.cli.core.breaking_change.NEXT_BREAKING_CHANGE_RELEASE', '3.0.0')
273+
@mock.patch('azure.cli.core.breaking_change.NEXT_BREAKING_CHANGE_DATE', 'May 2024')
268274
def test_logic_change(self):
269275
from contextlib import redirect_stderr, redirect_stdout
270276

271277
from azure.cli.core.breaking_change import register_logic_breaking_change
272278

273279
register_logic_breaking_change('test group cmd', summary="Logic Change Summary")
274-
warning = "Logic Change Summary in next breaking change release(3.0.0)."
280+
warning = "Logic Change Summary in next breaking change release(3.0.0) scheduled for May 2024."
275281
cli = DummyCli(commands_loader_cls=TestCommandsLoader)
276282

277283
captured_err = io.StringIO()
@@ -292,6 +298,7 @@ def test_logic_change(self):
292298
self.assertIn('[Breaking Change]', captured_output.getvalue())
293299

294300
@mock.patch('azure.cli.core.breaking_change.NEXT_BREAKING_CHANGE_RELEASE', '3.0.0')
301+
@mock.patch('azure.cli.core.breaking_change.NEXT_BREAKING_CHANGE_DATE', None)
295302
def test_multi_breaking_change(self):
296303
from contextlib import redirect_stderr, redirect_stdout
297304

0 commit comments

Comments
 (0)