Skip to content

{KeyVault} Support quoted object id for set-policy and delete-policy #13146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bim-msft wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

{KeyVault} Support quoted object id for set-policy and delete-policy #13146

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5d97367
Support quoted object id
bim-msft Apr 24, 2020
11b9888
keep the original format of UPN and SPN
bim-msft Apr 24, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/azure-cli/azure/cli/command_modules/keyvault/_validators.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,6 +189,11 @@ def validate_principal(ns):
raise argparse.ArgumentError(
None, 'specify exactly one: --object-id, --spn, --upn')

attrs = ['object_id', 'spn', 'upn']
for attr in attrs:
if getattr(ns, attr):
setattr(ns, attr, getattr(ns, attr).strip('"'))
Copy link
Copy Markdown
Member

@yungezz yungezz Apr 24, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for upn, is it safe to strip " ? what's the name convention? suggest only change object_id for now.

Copy link
Copy Markdown
Contributor Author

@bim-msft bim-msft Apr 24, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for upn, is it safe to strip " ? what's the name convention? suggest only change object_id for now.

Most of UPN names are email-like: https://docs.microsoft.com/en-us/azure/active-directory/hybrid/plan-connect-userprincipalname
As far as I know there is also a type of UPN for external users like this: bim_microsoft.com#EXT#@AzureSDKTeam.onmicrosoft.com

Both formats don't have leading or tailing quotes.
But in case that there are maybe some unknown formats may have quotes, I will keep the original format for UPN and SPN. Will investigate them again when we have new user ask.



def validate_resource_group_name(cmd, ns):
"""
Expand Down
Loading