Skip to content

{CI} Support multiple parameters check #21801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wangzelin007 wants to merge 4 commits into
base: dev
Choose a base branch
from
Draft

{CI} Support multiple parameters check #21801

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a6d86bc
Update check_pull_request.py
wangzelin007 Mar 25, 2022
6953fda
Update check_pull_request.py
wangzelin007 Mar 25, 2022
07ee5c7
Update check_pull_request.py
wangzelin007 Mar 25, 2022
75b5d13
Update check_pull_request.py
wangzelin007 Apr 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 28 additions & 12 deletions scripts/ci/check_pull_request.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,8 @@ def check_pull_request(title, body):

def regex_line(line):
error_flag = False
enclosed_begin = False
enclosed_end = True
# Check Fix #number in title, just give a warning here, because it is not necessarily.
if 'Fix' in line:
sub_pattern = r'#\d'
Expand Down Expand Up @@ -147,18 +149,27 @@ def regex_line(line):
logger.error(' ' * index + '↑')
error_flag = True
# --xxx parameters must be enclosed in `, e.g., `--size`
if i == '-' and line[idx + 1] == '-':
param = '--'
index = idx + 2
while index < len(line) and line[index] != ' ':
param += line[index]
index += 1
try:
assert line[idx - 1] == '`'
except:
logger.info('%s%s: missing ` around %s', line, yellow, param)
logger.error(' ' * idx + '↑' + ' ' * (index - idx - 2) + '↑')
error_flag = True
if line[idx] == '`' and not enclosed_begin:
enclosed_begin = True
enclosed_end = False
elif line[idx] == '`' and enclosed_begin:
enclosed_begin = False
enclosed_end = True
if i == '-' and (idx + 1) < len(line) and line[idx + 1] == '-':
if not enclosed_begin:
param = '--'
index = idx + 2
# get each parameter separate by space or /
while index < len(line) and line[index] not in [' ', '/']:
param += line[index]
index += 1
Comment thread
wangzelin007 marked this conversation as resolved.
# Check the starting ` character
try:
assert line[idx - 1] == '`'
except:
logger.info('%s%s: missing ` around %s', line, yellow, param)
logger.error(' ' * idx + '↑' + ' ' * (index - idx - 2) + '↑')
error_flag = True
# verb check: only check the first word after ] or :
if i in [']', ':']:
word = ''
Expand Down Expand Up @@ -188,6 +199,11 @@ def regex_line(line):
logger.error(' ' * idx + '↑')
error_flag = True

# check the ending ` character
if not enclosed_end:
logger.info('%s%s: unable to find the ending ` character', line, yellow)
error_flag = True

return error_flag


Expand Down
Loading