[Packaging] Fix deb: Set correct architecture in control#22658
Open
[Packaging] Fix deb: Set correct architecture in control#22658
Conversation
cpuguy83
requested review from
calvinhzy,
jiasli,
kairu-ms and
wangzelin007
as code owners
ghost
requested a review
from 
ghost
added
the
Collaborator
|
Packaging |
yonzhan
previously approved these changes
May 28, 2022
Member
Author
|
Realized this breaks the release scripts in scripts/release/debian. |
yonzhan
reviewed
May 28, 2022
Collaborator
yonzhan
left a comment
yonzhan
left a comment
There was a problem hiding this comment.
Need full test before changing
These packages are architecture specific so `all` is invalid here. Instead use `linux-any` which will give the packages the architecture for the target platform (default would be the host's architecture). Example file with old architecture: azure-cli_2.37.0-1~bionic_all.deb Example file with corrected architecture: azure-cli_2.37.0-1~bionic_amd64.deb
yonzhan
modified the milestones:
Aug 2022 (2022-09-06),
Sep 2022 (2022-10-12) - For Ignite
yonzhan
modified the milestones:
Sep 2022 (2022-10-12) - For Ignite,
Oct 2022 (2022-11-01)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
N/A
Description
These packages are architecture specific so
allis invalid here.Instead use
linux-anywhich will give the packages the architecturefor the target platform (default would be the host's architecture).
Example file with old architecture:
azure-cli_2.37.0-1~bionic_all.debExample file with corrected architecture:
azure-cli_2.37.0-1~bionic_amd64.debTesting Guide
N/A
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.