{App Service}: Updating the adhoc network api-version to the latest#23586
{App Service}: Updating the adhoc network api-version to the latest#23586panchagnula wants to merge 2 commits intoAzure:devfrom
Conversation
panchagnula
requested review from
calvinhzy,
evelyn-ys,
jiasli,
jsntcy,
kairu-ms,
necusjz and
zhoxing-ms
as code owners
ghost
requested a review
from 
ghost
added
the
|
App Service |
panchagnula
force-pushed
the
sisirap/networkDefaults
branch
from
6d5e1e2 to
b718715
Compare
| 'container_network': '2018-08-01', | ||
| 'appservice_network': '2020-04-01', | ||
| 'appservice_ensure_subnet': '2019-02-01' | ||
| 'appservice_network': '2021-08-01' |
There was a problem hiding this comment.
I think it's better for us to totally remove adhoc api versions and use
There was a problem hiding this comment.
Makes sense - will make this change , after rebasing, since looks like I need to re-record some tests anyway :)
|
The change to use this model was not done by me - but @fengzhou-msft |
Btw while I did see the core-cli make this change - seems like they moved the versions from the code to adhoc versions under_shared.py , which I assumed you were originally the creator of. Apologize if this assumption was incorrect & randomizing you. 6173ee4#diff-8d2a65b8bdb03df2a25f1e9e5f2fa12fc680887b4274ed1e5b76bdf9ef26b6dc |
|
Marking Draft, since we need to wait for the new SDK/ api-version update on networking extension. |
necusjz
modified the milestones:
Aug 2022 (2022-09-06),
Sep 2022 (2022-10-12) - For Ignite
yonzhan
modified the milestones:
Sep 2022 (2022-10-12) - For Ignite,
Oct 2022 (2022-11-01)
7 participants
Resolves #23389
Related command
Description
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.