{Packaging} Fix #23559: Disable build_id links#23798
Open
{Packaging} Fix #23559: Disable build_id links#23798
Conversation
ghost
requested review from
ghost
added
the
Collaborator
|
Packaging |
yonzhan
modified the milestones:
Sep 2022 (2022-10-12) - For Ignite,
Oct 2022 (2022-11-01)
Closed
7 tasks
markuslf
added a commit
to Linuxfabrik/monitoring-plugins
that referenced
this pull request
Apr 14, 2026
Follow-up to the previous attempt at #979. Commit 54dadc3 used `%global debug_package %{nil}` to sidestep the /usr/lib/.build-id/ file conflict, which works but is a sledgehammer: it disables the entire debuginfo subpackage generation so there is no way for a user or another tool to consume ELF debug information for the bundled .so modules in the venv. A canonical reviewer on the original issue pointed out the surgical alternative used by the azure-cli project (Azure/azure-cli#23798): set `_build_id_links` to `none`, which keeps debuginfo extraction running in general and only skips the /usr/lib/.build-id/ symlink creation that is actually colliding. Swap both spec files (EL and SLE) to `%define _build_id_links none`, update the inline comment and the CHANGELOG entry. Fixes the same root cause as 54dadc3 but leaves the door open to a -debuginfo subpackage in the future if we ever ship one. Refs #979
markuslf
added a commit
to Linuxfabrik/monitoring-plugins
that referenced
this pull request
Apr 14, 2026
Re-read the issues and linked PRs more carefully after a review comment. The inline comment in both spec files cited Azure/azure-cli#23798 as the canonical reference for the `_build_id_links none` workaround, but that PR has been open (not merged) since 2022; the azure-cli maintainers were actually sceptical on the linked Azure/azure-cli#23559 discussion and never integrated the fix. The real precedent is microsoft/vscode#116105, which used the exact same `%define _build_id_links none` line and was merged in February 2021 to solve the same class of conflict between the `code` and `code-insiders` RPMs (both ship the same Electron binary). VS Code has been shipping this workaround for nearly five years with no reported side effects. Update both spec file comments to reference the merged VS Code fix as the primary precedent and keep azure-cli only as "this is where the conflict in issue #979 was reported", not as a canonical-fix citation. Also broaden the example of the colliding shared object beyond libpython - in practice the same thing happens to ordinary compiled wheels like charset_normalizer (see the datadog-agent reports on Azure/azure-cli#23559). No code change, no CHANGELOG churn.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #23559. This PR disables the generation of build_id links to prevent conflicting with
azure-securitypackage in RHEL 8.5 on Azure.This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.