Skip to content

{App Service} az webapp config container show: Fix accidental side-effect plus make sure this function handles both types of input data, lists and dict #24735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
antimirov wants to merge 2 commits into
base: dev
Choose a base branch
from
+7 −3
Open

{App Service} az webapp config container show: Fix accidental side-effect plus make sure this function handles both types of input data, lists and dict #24735

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
704bcd0
fix accidental side-effect, plus make sure this function handles both…
antimirov Nov 24, 2022
a0ef00c
fix a flake8 issue
antimirov Nov 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions src/azure-cli/azure/cli/command_modules/appservice/custom.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1619,9 +1619,13 @@ def _filter_for_container_settings(cmd, resource_group_name, name, settings,

# TODO: remove this when #3660(service tracking issue) is resolved
def _mask_creds_related_appsettings(settings):
for x in [x1 for x1 in settings if x1 in APPSETTINGS_TO_MASK]:
settings[x] = None
return settings
if isinstance(settings, list):
return [
{**x, **{'value': None if x['name'] in APPSETTINGS_TO_MASK else x['value']}}
for x in settings
]

return {k: None if k in APPSETTINGS_TO_MASK else v for k, v in settings.items()}


def add_hostname(cmd, resource_group_name, webapp_name, hostname, slot=None):
Expand Down
Loading