{webapp} Fix description of --identities parameter#25535
Open
SaurabhSharma-MSFT wants to merge 2 commits intoAzure:devfrom
Open
{webapp} Fix description of --identities parameter#25535SaurabhSharma-MSFT wants to merge 2 commits intoAzure:devfrom
SaurabhSharma-MSFT wants to merge 2 commits intoAzure:devfrom
Conversation
SaurabhSharma-MSFT
requested review from
jsntcy,
yanzhudd and
zhoxing-ms
as code owners
ghost
added
the
ghost
requested a review
from 
Collaborator
|
webapp |
zhoxing-ms
reviewed
Mar 2, 2023
| c.argument('role', help="Role name or id the managed identity will be assigned") | ||
| with self.argument_context(scope + ' identity assign') as c: | ||
| c.argument('assign_identities', options_list=['--identities'], nargs='*', help="Space-separated identities to assign. Use '{0}' to refer to the system assigned identity. Default: '{0}'".format(MSI_LOCAL_ID)) | ||
| c.argument('assign_identities', options_list=['--identities'], nargs='*', help="Space-separated identities to assign. For User Assigned Identities, pass ids as full qualified resource ids like '/subscriptions/subscriptionId/resourceGroups/resourceGroupName/providers/Microsoft.ManagedIdentity/userAssignedIdentities/identityName'. Use '{0}' to refer to the system assigned identity. For User Assigned Identities, pass ids as full qualified resource ids like '/subscriptions/subscriptionId/resourceGroups/resourceGroupName/providers/Microsoft.ManagedIdentity/userAssignedIdentities/identityName'. Default: '{0}'".format(MSI_LOCAL_ID)) |
Contributor
There was a problem hiding this comment.
Personally, I think adding help examples is better than adding too many descriptions directly in the help message
Member
Author
There was a problem hiding this comment.
@zhoxing-ms Ok. got it. Do you want me to update the examples instead.
Member
Author
There was a problem hiding this comment.
@zhoxing-ms Sounds good. I will update here once done.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
az webapp identity assignDescription
{webapp} Fix description of --identities parameter to mention passing the full qualified resource id.
Fixes GitHub Issue 25401
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.