az vm create optional parameter update.#26350
Open
ManishaSinha0410 wants to merge 1 commit intoAzure:devfrom
Open
az vm create optional parameter update.#26350ManishaSinha0410 wants to merge 1 commit intoAzure:devfrom
ManishaSinha0410 wants to merge 1 commit intoAzure:devfrom
Conversation
ManishaSinha0410
requested review from
jsntcy,
wangzelin007,
yanzhudd and
zhoxing-ms
as code owners
|
Validation for Azure CLI Full Test Starting...
Thanks for your contribution! |
azure-client-tools-bot-prd
bot
added this to the
May 2023 (2023-05-23) - For Build (Breaking change release) milestone
ghost
added
the
customer-reported
|
Thank you for your contribution ManishaSinha0410! We will review the pull request and get back to you soon. |
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
ghost
requested a review
from 
zhoxing-ms
modified the milestones:
May 2023 (2023-05-23) - For Build (Breaking change release),
Backlog
Contributor
Author
|
Please let me know if any info is required from my end. |
zhoxing-ms
reviewed
May 24, 2023
Comment on lines
+3819
to
+3820
| --public-ip-address | ||
| Name of the public IP address when creating one (default) or referencing an existing one. Can also reference an existing public IP by ID or specify "" for None ('""' in Azure CLI using PowerShell or --% operator). For Azure CLI using powershell core edition 7.3.4, specify '' or "" (--public-ip-address '' or --public-ip-address "") |
Contributor
There was a problem hiding this comment.
Thanks for your contribution. Actually, this is not the correct place to modify the help message for --public-ip-address. Please modify the help message here https://github.com/Azure/azure-cli/blob/dev/src/azure-cli/azure/cli/command_modules/vm/_params.py#L1056.
ManishaSinha0410
added a commit
to ManishaSinha0410/azure-cli
that referenced
this pull request
May 30, 2023
Submitting request here as suggested in below pull request: Azure#26350 (review)
zhoxing-ms
pushed a commit
that referenced
this pull request
Jun 21, 2023
…26563) Submitting request here as suggested in below pull request: #26350 (review)
avgale
pushed a commit
to avgale/azure-cli
that referenced
this pull request
Aug 24, 2023
…zure#26563) Submitting request here as suggested in below pull request: Azure#26350 (review)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--public-ip-address
Name of the public IP address when creating one (default) or referencing an existing one. Can also reference an existing public IP by ID or specify "" for None ('""' in Azure CLI using PowerShell or --% operator).
Description
We have tested with different versions of OS and PowerShell core version 7.3.4 to test the public-ip-address parameter behavior and below is our findings when we have to create VM without public IP:
For PowerShell core version 7.2.* & below === --public-ip-address '""'
For PowerShell core version 7.3.4 ===== --public-ip-address ‘’ or --public-ip-address “” ---------------------------------------- Here we just have to use single field i.e., either single inverted comma (‘’) or just double inverted comma (“”).
Since, cloud shell also uses PowerShell core edition so here also we saw the same behavior in past. This not specific to any OS version as such, we just need to do slight modification in command while using PowerShell core version 7.3.4.
Testing Guide
az vm create --name newvm --resource-group testazcli --image Win2022Datacenter --admin-username sinhamanisha --admin-password Manishasinha*10 --subnet /subscriptions/6b26da86-6cfd-4198-afde-fb754b11c54e/resourceGroups/testazcli/providers/Microsoft.Network/virtualNetworks/testvnet/subnets/testsubnet --location southindia --size Standard_E32s_v3 --public-ip-address ''
OR
az vm create --name newvm --resource-group testazcli --image Win2022Datacenter --admin-username sinhamanisha --admin-password Manishasinha*10 --subnet /subscriptions/6b26da86-6cfd-4198-afde-fb754b11c54e/resourceGroups/testazcli/providers/Microsoft.Network/virtualNetworks/testvnet/subnets/testsubnet --location southindia --size Standard_E32s_v3 --public-ip-address ""
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.