{APIM} public network access parameter values should be Enabled or Disabled#26380
Open
navba-MSFT wants to merge 1 commit intoAzure:devfrom
Open
{APIM} public network access parameter values should be Enabled or Disabled#26380navba-MSFT wants to merge 1 commit intoAzure:devfrom
navba-MSFT wants to merge 1 commit intoAzure:devfrom
Conversation
Seeing the below REST API Specs swagger, I see the accepted values are Enabled or Disabled for the `--public-network-access` setting. https://github.com/Azure/azure-rest-api-specs/blob/main/specification/apimanagement/resource-manager/Microsoft.ApiManagement/preview/2021-12-01-preview/apimdeployment.json#L1323
️✔️AzureCLI-FullTest
|
|
Hi @navba-MSFT, |
ghost
requested review from
Collaborator
|
APIM |
ghost
added
the
Contributor
|
Could you please add a test for this case? |
Contributor
|
@navba-MSFT Any update? |
Contributor
Author
I will check this and get back to you. |
Contributor
|
@navba-MSFT Please note that we are launching the release for this sprint this week. Please resolve all comments by tomorrow, otherwise the release of this PR will have to be postponed to the next sprint (on 08-01) |
Contributor
|
@Anand0046 Could you please help review the APIM related PR? |
zhoxing-ms
modified the milestones:
August 2023 (2023-09-05),
September 2023 (2023-09-26)
Contributor
|
@navba-MSFT please note that there is a code freeze for this sprint in 9-19. Please resolve all comments before the date, otherwise this PR will have to be postponed to next sprint (11-07). |
zhoxing-ms
modified the milestones:
September 2023 (2023-09-26),
October 2023 (2023-11-15)❗ Breaking change release ❗
zhoxing-ms
modified the milestones:
October 2023 (2023-11-14)❗ Breaking change release ❗,
November 2023 (2023-12-05)
zhoxing-ms
modified the milestones:
November 2023 (2023-12-05),
December 2023 (2024-01-02)
zhoxing-ms
modified the milestones:
December 2023 (2024-01-09),
January 2024 (2024-02-06)
zhoxing-ms
modified the milestones:
January 2024 (2024-02-06),
February 2024 (2024-03-05)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes Azure/azure-rest-api-specs#23683
This REST API where it clearly talks about the --public-network-access accepting the values Enabled or Disabled.
Seeing the REST API Specs swagger, I see the accepted values are Enabled or Disabled.
However in Azure CLI, apim update and apim create is expecting true or false. This is causing an unexpected behavior with the apim creation and updating the --public-network-access setting.
Related command
Description
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.